diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-05-03 13:42:47 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-05-15 10:27:51 +0000 |
commit | 8c5c43c7b138c9b4b0bf56d946e61d3bbc111bec (patch) | |
tree | d29d987c4d7b173cf853279b79a51598f104b403 /chromium/components/feature_engagement | |
parent | 830c9e163d31a9180fadca926b3e1d7dfffb5021 (diff) | |
download | qtwebengine-chromium-8c5c43c7b138c9b4b0bf56d946e61d3bbc111bec.tar.gz |
BASELINE: Update Chromium to 66.0.3359.156
Change-Id: I0c9831ad39911a086b6377b16f995ad75a51e441
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Diffstat (limited to 'chromium/components/feature_engagement')
10 files changed, 14 insertions, 16 deletions
diff --git a/chromium/components/feature_engagement/BUILD.gn b/chromium/components/feature_engagement/BUILD.gn index 1c520848170..e415d23ea63 100644 --- a/chromium/components/feature_engagement/BUILD.gn +++ b/chromium/components/feature_engagement/BUILD.gn @@ -10,14 +10,14 @@ if (is_android) { import("//build/config/android/rules.gni") } -buildflag_header("features") { - header = "features.h" +buildflag_header("buildflags") { + header = "buildflags.h" flags = [ "ENABLE_DESKTOP_IN_PRODUCT_HELP=$enable_desktop_in_product_help" ] } group("feature_engagement") { public_deps = [ - ":features", + ":buildflags", "//components/feature_engagement/public", ] diff --git a/chromium/components/feature_engagement/internal/in_memory_event_store.cc b/chromium/components/feature_engagement/internal/in_memory_event_store.cc index 140d6ea571b..348727a939f 100644 --- a/chromium/components/feature_engagement/internal/in_memory_event_store.cc +++ b/chromium/components/feature_engagement/internal/in_memory_event_store.cc @@ -5,6 +5,7 @@ #include "components/feature_engagement/internal/in_memory_event_store.h" #include <memory> +#include <utility> #include <vector> #include "base/bind.h" @@ -44,7 +45,7 @@ void InMemoryEventStore::DeleteEvent(const std::string& event_name) { void InMemoryEventStore::HandleLoadResult(const OnLoadedCallback& callback, bool success) { base::ThreadTaskRunnerHandle::Get()->PostTask( - FROM_HERE, base::Bind(callback, success, base::Passed(&events_))); + FROM_HERE, base::BindOnce(callback, success, std::move(events_))); ready_ = success; } diff --git a/chromium/components/feature_engagement/internal/tracker_impl_unittest.cc b/chromium/components/feature_engagement/internal/tracker_impl_unittest.cc index 2de896253fc..bbcf9235695 100644 --- a/chromium/components/feature_engagement/internal/tracker_impl_unittest.cc +++ b/chromium/components/feature_engagement/internal/tracker_impl_unittest.cc @@ -8,6 +8,7 @@ #include <utility> #include "base/bind.h" +#include "base/bind_helpers.h" #include "base/feature_list.h" #include "base/message_loop/message_loop.h" #include "base/run_loop.h" @@ -175,8 +176,6 @@ class TestDisplayLockController : public DisplayLockController { next_display_lock_handle_ = std::move(display_lock_handle); } - void NoopCallback() {} - private: // The next DisplayLockHandle to return. std::unique_ptr<DisplayLockHandle> next_display_lock_handle_; @@ -858,9 +857,7 @@ TEST_F(TrackerImplTest, TestNotifyEvent) { } TEST_F(TrackerImplTest, ShouldPassThroughAcquireDisplayLock) { - auto lock_handle = std::make_unique<DisplayLockHandle>( - base::Bind(&TestDisplayLockController::NoopCallback, - base::Unretained(display_lock_controller_))); + auto lock_handle = std::make_unique<DisplayLockHandle>(base::DoNothing()); DisplayLockHandle* lock_handle_ptr = lock_handle.get(); display_lock_controller_->SetNextDisplayLockHandle(std::move(lock_handle)); EXPECT_EQ(lock_handle_ptr, tracker_->AcquireDisplayLock().get()); diff --git a/chromium/components/feature_engagement/public/BUILD.gn b/chromium/components/feature_engagement/public/BUILD.gn index 88ee1bd7523..ede4df0a652 100644 --- a/chromium/components/feature_engagement/public/BUILD.gn +++ b/chromium/components/feature_engagement/public/BUILD.gn @@ -21,7 +21,7 @@ source_set("public") { deps = [ "//base", - "//components/feature_engagement:features", + "//components/feature_engagement:buildflags", "//components/flags_ui", "//components/keyed_service/core", ] diff --git a/chromium/components/feature_engagement/public/event_constants.cc b/chromium/components/feature_engagement/public/event_constants.cc index 5d93f962d5b..b0e351a465f 100644 --- a/chromium/components/feature_engagement/public/event_constants.cc +++ b/chromium/components/feature_engagement/public/event_constants.cc @@ -5,7 +5,7 @@ #include "components/feature_engagement/public/event_constants.h" #include "build/build_config.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" namespace feature_engagement { diff --git a/chromium/components/feature_engagement/public/event_constants.h b/chromium/components/feature_engagement/public/event_constants.h index 1d087288c31..1b95ad1b7ab 100644 --- a/chromium/components/feature_engagement/public/event_constants.h +++ b/chromium/components/feature_engagement/public/event_constants.h @@ -6,7 +6,7 @@ #define COMPONENTS_FEATURE_ENGAGEMENT_PUBLIC_EVENT_CONSTANTS_H_ #include "build/build_config.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" namespace feature_engagement { diff --git a/chromium/components/feature_engagement/public/feature_constants.cc b/chromium/components/feature_engagement/public/feature_constants.cc index 4ad114103d0..3c44da07016 100644 --- a/chromium/components/feature_engagement/public/feature_constants.cc +++ b/chromium/components/feature_engagement/public/feature_constants.cc @@ -4,7 +4,7 @@ #include "components/feature_engagement/public/feature_constants.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" namespace feature_engagement { diff --git a/chromium/components/feature_engagement/public/feature_constants.h b/chromium/components/feature_engagement/public/feature_constants.h index fb513ffa82d..bf2857d4042 100644 --- a/chromium/components/feature_engagement/public/feature_constants.h +++ b/chromium/components/feature_engagement/public/feature_constants.h @@ -7,7 +7,7 @@ #include "base/feature_list.h" #include "build/build_config.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" namespace feature_engagement { diff --git a/chromium/components/feature_engagement/public/feature_list.cc b/chromium/components/feature_engagement/public/feature_list.cc index 91666e5d0f1..9b7a306176a 100644 --- a/chromium/components/feature_engagement/public/feature_list.cc +++ b/chromium/components/feature_engagement/public/feature_list.cc @@ -4,7 +4,7 @@ #include "components/feature_engagement/public/feature_list.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" #include "components/feature_engagement/public/feature_constants.h" namespace feature_engagement { diff --git a/chromium/components/feature_engagement/public/feature_list.h b/chromium/components/feature_engagement/public/feature_list.h index 4e5ad21e20f..2b189656a00 100644 --- a/chromium/components/feature_engagement/public/feature_list.h +++ b/chromium/components/feature_engagement/public/feature_list.h @@ -9,7 +9,7 @@ #include "base/feature_list.h" #include "build/build_config.h" -#include "components/feature_engagement/features.h" +#include "components/feature_engagement/buildflags.h" #include "components/feature_engagement/public/feature_constants.h" #include "components/flags_ui/feature_entry.h" |