diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-03-11 11:32:04 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-03-18 13:40:17 +0000 |
commit | 31ccca0778db85c159634478b4ec7997f6704860 (patch) | |
tree | 3d33fc3afd9d5ec95541e1bbe074a9cf8da12a0e /chromium/components/feature_engagement | |
parent | 248b70b82a40964d5594eb04feca0fa36716185d (diff) | |
download | qtwebengine-chromium-31ccca0778db85c159634478b4ec7997f6704860.tar.gz |
BASELINE: Update Chromium to 80.0.3987.136
Change-Id: I98e1649aafae85ba3a83e67af00bb27ef301db7b
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Diffstat (limited to 'chromium/components/feature_engagement')
10 files changed, 87 insertions, 21 deletions
diff --git a/chromium/components/feature_engagement/internal/chrome_variations_configuration_unittest.cc b/chromium/components/feature_engagement/internal/chrome_variations_configuration_unittest.cc index 23a5cceab0e..828c5483707 100644 --- a/chromium/components/feature_engagement/internal/chrome_variations_configuration_unittest.cc +++ b/chromium/components/feature_engagement/internal/chrome_variations_configuration_unittest.cc @@ -45,7 +45,7 @@ SessionRateImpact CreateSessionRateImpactExplicit( class ChromeVariationsConfigurationTest : public ::testing::Test { public: - ChromeVariationsConfigurationTest() : field_trials_(nullptr) { + ChromeVariationsConfigurationTest() { base::FieldTrial* foo_trial = base::FieldTrialList::CreateFieldTrial(kFooTrialName, kGroupName); base::FieldTrial* bar_trial = @@ -67,7 +67,7 @@ class ChromeVariationsConfigurationTest : public ::testing::Test { kChromeTestFeatureQux.name, base::FeatureList::OVERRIDE_ENABLE_FEATURE, qux_trial); - scoped_feature_list.InitWithFeatureList(std::move(feature_list)); + scoped_feature_list_.InitWithFeatureList(std::move(feature_list)); EXPECT_EQ(foo_trial, base::FeatureList::GetFieldTrial(kChromeTestFeatureFoo)); EXPECT_EQ(bar_trial, @@ -111,9 +111,8 @@ class ChromeVariationsConfigurationTest : public ::testing::Test { ChromeVariationsConfiguration configuration_; private: - base::FieldTrialList field_trials_; + base::test::ScopedFeatureList scoped_feature_list_; std::map<std::string, base::FieldTrial*> trials_; - base::test::ScopedFeatureList scoped_feature_list; DISALLOW_COPY_AND_ASSIGN(ChromeVariationsConfigurationTest); }; diff --git a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java index 5d1bac869a3..9fa9efa313c 100644 --- a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java +++ b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java @@ -29,12 +29,6 @@ public final class EventConstants { public static final String DOWNLOAD_HOME_OPENED = "download_home_opened"; /** - * The user triggered pull to refresh. Used to help determine when to show the Chrome Home - * in-product help. - */ - public static final String PULL_TO_REFRESH = "pull_to_refresh"; - - /** * Screenshot is taken with Chrome in the foreground. */ public static final String SCREENSHOT_TAKEN_CHROME_IN_FOREGROUND = @@ -160,6 +154,9 @@ public final class EventConstants { /** User has finished drop-to-merge to create a group. */ public static final String TAB_DRAG_AND_DROP_TO_GROUP = "tab_drag_and_drop_to_group"; + /** User has tapped on Identity Disc. */ + public static final String IDENTITY_DISC_USED = "identity_disc_used"; + /** * Do not instantiate. */ diff --git a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java index e70dd4aa3cb..92f14f1ca49 100644 --- a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java +++ b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java @@ -15,7 +15,9 @@ import java.lang.annotation.RetentionPolicy; */ @StringDef({FeatureConstants.DOWNLOAD_PAGE_FEATURE, FeatureConstants.DOWNLOAD_PAGE_SCREENSHOT_FEATURE, FeatureConstants.DOWNLOAD_HOME_FEATURE, - FeatureConstants.CHROME_DUET_FEATURE, FeatureConstants.CHROME_HOME_EXPAND_FEATURE, + FeatureConstants.CHROME_DUET_SEARCH_FEATURE, + FeatureConstants.CHROME_DUET_TAB_SWITCHER_FEATURE, + FeatureConstants.CHROME_HOME_EXPAND_FEATURE, FeatureConstants.CHROME_HOME_PULL_TO_REFRESH_FEATURE, FeatureConstants.DATA_SAVER_PREVIEW_FEATURE, FeatureConstants.DATA_SAVER_DETAIL_FEATURE, FeatureConstants.PREVIEWS_OMNIBOX_UI_FEATURE, @@ -34,13 +36,16 @@ import java.lang.annotation.RetentionPolicy; FeatureConstants.TAB_GROUPS_TAP_TO_SEE_ANOTHER_TAB_FEATURE, FeatureConstants.TAB_GROUPS_YOUR_TABS_ARE_TOGETHER_FEATURE, FeatureConstants.FEED_CARD_MENU_FEATURE, FeatureConstants.IDENTITY_DISC_FEATURE, - FeatureConstants.TAB_GROUPS_DRAG_AND_DROP_FEATURE}) + FeatureConstants.TAB_GROUPS_DRAG_AND_DROP_FEATURE, + FeatureConstants.QUIET_NOTIFICATION_PROMPTS_FEATURE}) @Retention(RetentionPolicy.SOURCE) public @interface FeatureConstants { String DOWNLOAD_PAGE_FEATURE = "IPH_DownloadPage"; String DOWNLOAD_PAGE_SCREENSHOT_FEATURE = "IPH_DownloadPageScreenshot"; String DOWNLOAD_HOME_FEATURE = "IPH_DownloadHome"; - String CHROME_DUET_FEATURE = "IPH_ChromeDuet"; + String CHROME_DUET_HOME_BUTTON_FEATURE = "IPH_ChromeDuetHomeButton"; + String CHROME_DUET_SEARCH_FEATURE = "IPH_ChromeDuet"; + String CHROME_DUET_TAB_SWITCHER_FEATURE = "IPH_ChromeDuetTabSwitcherButton"; String CHROME_HOME_EXPAND_FEATURE = "IPH_ChromeHomeExpand"; String CHROME_HOME_PULL_TO_REFRESH_FEATURE = "IPH_ChromeHomePullToRefresh"; String DATA_SAVER_PREVIEW_FEATURE = "IPH_DataSaverPreview"; @@ -122,4 +127,10 @@ public @interface FeatureConstants { * services" preferences. */ String IDENTITY_DISC_FEATURE = "IPH_IdentityDisc"; + + /** + * An IPH feature showing up the first time the user is presented with the quieter version of + * the permission prompt (for notifications). + */ + String QUIET_NOTIFICATION_PROMPTS_FEATURE = "IPH_QuietNotificationPrompts"; } diff --git a/chromium/components/feature_engagement/public/event_constants.cc b/chromium/components/feature_engagement/public/event_constants.cc index b00db8ed977..1e8973aceea 100644 --- a/chromium/components/feature_engagement/public/event_constants.cc +++ b/chromium/components/feature_engagement/public/event_constants.cc @@ -28,6 +28,9 @@ const char kGlobalMediaControlsOpened[] = "global_media_controls_opened"; const char kFocusModeOpened[] = "focus_mode_opened"; const char kFocusModeConditionsMet[] = "focus_mode_conditions_met"; +const char kWebUITabStripClosed[] = "webui_tab_strip_closed"; +const char kWebUITabStripOpened[] = "webui_tab_strip_opened"; + #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) const char kBookmarkAdded[] = "bookmark_added"; const char kBookmarkSessionTimeMet[] = "bookmark_session_time_met"; diff --git a/chromium/components/feature_engagement/public/event_constants.h b/chromium/components/feature_engagement/public/event_constants.h index a473aa0afa6..638a72e929d 100644 --- a/chromium/components/feature_engagement/public/event_constants.h +++ b/chromium/components/feature_engagement/public/event_constants.h @@ -45,6 +45,11 @@ extern const char kFocusModeOpened[]; // All conditions for show Focus Mode IPH were met. extern const char kFocusModeConditionsMet[]; +// The WebUI tab strip was closed by the user. +extern const char kWebUITabStripClosed[]; +// The WebUI tab strip was opened by the user. +extern const char kWebUITabStripOpened[]; + #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) // All the events declared below are the string names of deferred onboarding // events for the Bookmark feature. diff --git a/chromium/components/feature_engagement/public/feature_configurations.cc b/chromium/components/feature_engagement/public/feature_configurations.cc index abf8a27d634..8ba1faffc4c 100644 --- a/chromium/components/feature_engagement/public/feature_configurations.cc +++ b/chromium/components/feature_engagement/public/feature_configurations.cc @@ -27,6 +27,30 @@ base::Optional<FeatureConfig> GetClientSideFeatureConfig( Comparator(GREATER_THAN_OR_EQUAL, 10), 90, 360)); return config; } + if (kIPHDataSaverPreviewFeature.name == feature->name) { + base::Optional<FeatureConfig> config = FeatureConfig(); + config->valid = true; + config->availability = Comparator(ANY, 0); + config->session_rate = Comparator(EQUAL, 0); + config->trigger = EventConfig("data_saver_preview_iph_trigger", + Comparator(EQUAL, 0), 90, 360); + config->used = EventConfig("data_saver_preview_opened", + Comparator(LESS_THAN_OR_EQUAL, 1), 90, 360); + return config; + } + if (kIPHPreviewsOmniboxUIFeature.name == feature->name) { + base::Optional<FeatureConfig> config = FeatureConfig(); + config->valid = true; + config->availability = Comparator(ANY, 0); + config->session_rate = Comparator(EQUAL, 0); + config->trigger = EventConfig("previews_verbose_iph_triggered_2", + Comparator(LESS_THAN, 2), 90, 360); + config->used = EventConfig("previews_verbose_status_opened", + Comparator(EQUAL, 0), 90, 360); + config->event_configs.insert(EventConfig( + "preview_page_load", Comparator(GREATER_THAN_OR_EQUAL, 1), 90, 360)); + return config; + } if (kIPHDownloadHomeFeature.name == feature->name) { base::Optional<FeatureConfig> config = FeatureConfig(); config->valid = true; diff --git a/chromium/components/feature_engagement/public/feature_constants.cc b/chromium/components/feature_engagement/public/feature_constants.cc index d951d611a64..520aa289461 100644 --- a/chromium/components/feature_engagement/public/feature_constants.cc +++ b/chromium/components/feature_engagement/public/feature_constants.cc @@ -22,6 +22,8 @@ const base::Feature kIPHGlobalMediaControlsFeature{ "IPH_GlobalMediaControls", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHReopenTabFeature{"IPH_ReopenTab", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHWebUITabStripFeature{"IPH_WebUITabStrip", + base::FEATURE_DISABLED_BY_DEFAULT}; #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) const base::Feature kIPHBookmarkFeature{"IPH_Bookmark", @@ -40,15 +42,19 @@ const base::Feature kIPHDataSaverDetailFeature{ const base::Feature kIPHDataSaverMilestonePromoFeature{ "IPH_DataSaverMilestonePromo", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHDataSaverPreviewFeature{ - "IPH_DataSaverPreview", base::FEATURE_DISABLED_BY_DEFAULT}; + "IPH_DataSaverPreview", base::FEATURE_ENABLED_BY_DEFAULT}; const base::Feature kIPHDownloadHomeFeature{"IPH_DownloadHome", base::FEATURE_ENABLED_BY_DEFAULT}; const base::Feature kIPHDownloadPageFeature{"IPH_DownloadPage", base::FEATURE_ENABLED_BY_DEFAULT}; const base::Feature kIPHDownloadPageScreenshotFeature{ "IPH_DownloadPageScreenshot", base::FEATURE_DISABLED_BY_DEFAULT}; -const base::Feature kIPHChromeDuetFeature{"IPH_ChromeDuet", - base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHChromeDuetHomeButtonFeature{ + "IPH_ChromeDuetHomeButton", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHChromeDuetSearchFeature{ + "IPH_ChromeDuet", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHChromeDuetTabSwitcherFeature{ + "IPH_ChromeDuetTabSwitcherButton", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHChromeHomeExpandFeature{ "IPH_ChromeHomeExpand", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHChromeHomePullToRefreshFeature{ @@ -67,6 +73,8 @@ const base::Feature kIPHDownloadInfoBarDownloadContinuingFeature{ "IPH_DownloadInfoBarDownloadContinuing", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHDownloadInfoBarDownloadsAreFasterFeature{ "IPH_DownloadInfoBarDownloadsAreFaster", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHQuietNotificationPromptsFeature{ + "IPH_QuietNotificationPrompts", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHFeedCardMenuFeature{"IPH_FeedCardMenu", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHIdentityDiscFeature{"IPH_IdentityDisc", @@ -78,7 +86,7 @@ const base::Feature kIPHKeyboardAccessoryPasswordFillingFeature{ const base::Feature kIPHKeyboardAccessoryPaymentFillingFeature{ "IPH_KeyboardAccessoryPaymentFilling", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHPreviewsOmniboxUIFeature{ - "IPH_PreviewsOmniboxUI", base::FEATURE_DISABLED_BY_DEFAULT}; + "IPH_PreviewsOmniboxUI", base::FEATURE_ENABLED_BY_DEFAULT}; const base::Feature kIPHTabGroupsQuicklyComparePagesFeature{ "IPH_TabGroupsQuicklyComparePages", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHTabGroupsTapToSeeAnotherTabFeature{ diff --git a/chromium/components/feature_engagement/public/feature_constants.h b/chromium/components/feature_engagement/public/feature_constants.h index fba9baeb0ef..de4b4117da0 100644 --- a/chromium/components/feature_engagement/public/feature_constants.h +++ b/chromium/components/feature_engagement/public/feature_constants.h @@ -22,6 +22,7 @@ extern const base::Feature kIPHDummyFeature; extern const base::Feature kIPHFocusModeFeature; extern const base::Feature kIPHGlobalMediaControlsFeature; extern const base::Feature kIPHReopenTabFeature; +extern const base::Feature kIPHWebUITabStripFeature; #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) extern const base::Feature kIPHBookmarkFeature; @@ -41,7 +42,9 @@ extern const base::Feature kIPHDataSaverPreviewFeature; extern const base::Feature kIPHDownloadHomeFeature; extern const base::Feature kIPHDownloadPageFeature; extern const base::Feature kIPHDownloadPageScreenshotFeature; -extern const base::Feature kIPHChromeDuetFeature; +extern const base::Feature kIPHChromeDuetHomeButtonFeature; +extern const base::Feature kIPHChromeDuetSearchFeature; +extern const base::Feature kIPHChromeDuetTabSwitcherFeature; extern const base::Feature kIPHChromeHomeExpandFeature; extern const base::Feature kIPHChromeHomePullToRefreshFeature; extern const base::Feature kIPHContextualSearchWebSearchFeature; @@ -60,6 +63,7 @@ extern const base::Feature kIPHKeyboardAccessoryPasswordFillingFeature; extern const base::Feature kIPHKeyboardAccessoryPaymentFillingFeature; extern const base::Feature kIPHNewTabPageButtonFeature; extern const base::Feature kIPHPreviewsOmniboxUIFeature; +extern const base::Feature kIPHQuietNotificationPromptsFeature; extern const base::Feature kIPHTabGroupsQuicklyComparePagesFeature; extern const base::Feature kIPHTabGroupsTapToSeeAnotherTabFeature; extern const base::Feature kIPHTabGroupsYourTabsAreTogetherFeature; diff --git a/chromium/components/feature_engagement/public/feature_list.cc b/chromium/components/feature_engagement/public/feature_list.cc index 11aba764404..8367202f29d 100644 --- a/chromium/components/feature_engagement/public/feature_list.cc +++ b/chromium/components/feature_engagement/public/feature_list.cc @@ -23,7 +23,9 @@ const base::Feature* const kAllFeatures[] = { &kIPHDownloadHomeFeature, &kIPHDownloadPageFeature, &kIPHDownloadPageScreenshotFeature, - &kIPHChromeDuetFeature, + &kIPHChromeDuetHomeButtonFeature, + &kIPHChromeDuetSearchFeature, + &kIPHChromeDuetTabSwitcherFeature, &kIPHChromeHomeExpandFeature, &kIPHChromeHomePullToRefreshFeature, &kIPHContextualSearchWebSearchFeature, @@ -39,6 +41,7 @@ const base::Feature* const kAllFeatures[] = { &kIPHKeyboardAccessoryPasswordFillingFeature, &kIPHKeyboardAccessoryPaymentFillingFeature, &kIPHPreviewsOmniboxUIFeature, + &kIPHQuietNotificationPromptsFeature, &kIPHTabGroupsQuicklyComparePagesFeature, &kIPHTabGroupsTapToSeeAnotherTabFeature, &kIPHTabGroupsYourTabsAreTogetherFeature, @@ -59,6 +62,7 @@ const base::Feature* const kAllFeatures[] = { &kIPHFocusModeFeature, &kIPHGlobalMediaControlsFeature, &kIPHReopenTabFeature, + &kIPHWebUITabStripFeature, #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) &kIPHBookmarkFeature, &kIPHIncognitoWindowFeature, diff --git a/chromium/components/feature_engagement/public/feature_list.h b/chromium/components/feature_engagement/public/feature_list.h index fb6494ebc63..ed5fe83ac94 100644 --- a/chromium/components/feature_engagement/public/feature_list.h +++ b/chromium/components/feature_engagement/public/feature_list.h @@ -55,7 +55,11 @@ DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome"); DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage"); DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature, "IPH_DownloadPageScreenshot"); -DEFINE_VARIATION_PARAM(kIPHChromeDuetFeature, "IPH_ChromeDuet"); +DEFINE_VARIATION_PARAM(kIPHChromeDuetHomeButtonFeature, + "IPH_ChromeDuetHomeButton"); +DEFINE_VARIATION_PARAM(kIPHChromeDuetSearchFeature, "IPH_ChromeDuet"); +DEFINE_VARIATION_PARAM(kIPHChromeDuetTabSwitcherFeature, + "IPH_ChromeDuetTabSwitcherButton"); DEFINE_VARIATION_PARAM(kIPHChromeHomeExpandFeature, "IPH_ChromeHomeExpand"); DEFINE_VARIATION_PARAM(kIPHChromeHomePullToRefreshFeature, "IPH_ChromeHomePullToRefresh"); @@ -81,6 +85,8 @@ DEFINE_VARIATION_PARAM(kIPHKeyboardAccessoryPasswordFillingFeature, DEFINE_VARIATION_PARAM(kIPHKeyboardAccessoryPaymentFillingFeature, "IPH_KeyboardAccessoryPaymentFilling"); DEFINE_VARIATION_PARAM(kIPHPreviewsOmniboxUIFeature, "IPH_PreviewsOmniboxUI"); +DEFINE_VARIATION_PARAM(kIPHQuietNotificationPromptsFeature, + "IPH_QuietNotificationPrompts"); DEFINE_VARIATION_PARAM(kIPHTabGroupsQuicklyComparePagesFeature, "IPH_TabGroupsQuicklyComparePages"); DEFINE_VARIATION_PARAM(kIPHTabGroupsTapToSeeAnotherTabFeature, @@ -109,6 +115,7 @@ DEFINE_VARIATION_PARAM(kIPHBadgedTranslateManualTriggerFeature, DEFINE_VARIATION_PARAM(kIPHFocusModeFeature, "IPH_FocusMode"); DEFINE_VARIATION_PARAM(kIPHGlobalMediaControls, "IPH_GlobalMediaControls"); DEFINE_VARIATION_PARAM(kIPHReopenTabFeature, "IPH_ReopenTab"); +DEFINE_VARIATION_PARAM(kIPHWebUITabStripFeature, "IPH_WebUITabStrip"); #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) DEFINE_VARIATION_PARAM(kIPHBookmarkFeature, "IPH_Bookmark"); DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow"); @@ -131,7 +138,9 @@ constexpr flags_ui::FeatureEntry::FeatureVariation VARIATION_ENTRY(kIPHDownloadHomeFeature), VARIATION_ENTRY(kIPHDownloadPageFeature), VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature), - VARIATION_ENTRY(kIPHChromeDuetFeature), + VARIATION_ENTRY(kIPHChromeDuetHomeButtonFeature), + VARIATION_ENTRY(kIPHChromeDuetSearchFeature), + VARIATION_ENTRY(kIPHChromeDuetTabSwitcherFeature), VARIATION_ENTRY(kIPHChromeHomeExpandFeature), VARIATION_ENTRY(kIPHChromeHomePullToRefreshFeature), VARIATION_ENTRY(kIPHContextualSearchWebSearchFeature), @@ -147,6 +156,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation VARIATION_ENTRY(kIPHKeyboardAccessoryPasswordFillingFeature), VARIATION_ENTRY(kIPHKeyboardAccessoryPaymentFillingFeature), VARIATION_ENTRY(kIPHPreviewsOmniboxUIFeature), + VARIATION_ENTRY(kIPHQuietNotificationPromptsFeature), VARIATION_ENTRY(kIPHTabGroupsQuicklyComparePagesFeature), VARIATION_ENTRY(kIPHTabGroupsTapToSeeAnotherTabFeature), VARIATION_ENTRY(kIPHTabGroupsYourTabsAreTogetherFeature), @@ -165,6 +175,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation VARIATION_ENTRY(kIPHFocusModeFeature), VARIATION_ENTRY(kIPHGlobalMediaControls), VARIATION_ENTRY(kIPHReopenTabFeature), + VARIATION_ENTRY(kIPHWebUITabStripFeature), #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) VARIATION_ENTRY(kIPHBookmarkFeature), VARIATION_ENTRY(kIPHIncognitoWindowFeature), |