diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-09-03 13:32:17 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-10-01 14:31:55 +0200 |
commit | 21ba0c5d4bf8fba15dddd97cd693bad2358b77fd (patch) | |
tree | 91be119f694044dfc1ff9fdc054459e925de9df0 /chromium/components/consent_auditor | |
parent | 03c549e0392f92c02536d3f86d5e1d8dfa3435ac (diff) | |
download | qtwebengine-chromium-21ba0c5d4bf8fba15dddd97cd693bad2358b77fd.tar.gz |
BASELINE: Update Chromium to 92.0.4515.166
Change-Id: I42a050486714e9e54fc271f2a8939223a02ae364
Diffstat (limited to 'chromium/components/consent_auditor')
4 files changed, 19 insertions, 20 deletions
diff --git a/chromium/components/consent_auditor/OWNERS b/chromium/components/consent_auditor/OWNERS index 0e2c166181b..745d3ad1b91 100644 --- a/chromium/components/consent_auditor/OWNERS +++ b/chromium/components/consent_auditor/OWNERS @@ -1,4 +1,3 @@ dullweber@chromium.org markusheintz@chromium.org msramek@chromium.org -vitaliii@chromium.org diff --git a/chromium/components/consent_auditor/consent_auditor_impl_unittest.cc b/chromium/components/consent_auditor/consent_auditor_impl_unittest.cc index 566b920a518..b7e303a6c33 100644 --- a/chromium/components/consent_auditor/consent_auditor_impl_unittest.cc +++ b/chromium/components/consent_auditor/consent_auditor_impl_unittest.cc @@ -197,7 +197,7 @@ TEST_F(ConsentAuditorImplTest, LocalConsentPrefRepresentation) { EXPECT_EQ(kCurrentAppLocale, locale); // They are two separate records; the latter did not overwrite the former. - EXPECT_EQ(2u, consents->size()); + EXPECT_EQ(2u, consents->DictSize()); EXPECT_TRUE( consents->FindKeyOfType("feature1", base::Value::Type::DICTIONARY)); @@ -224,7 +224,7 @@ TEST_F(ConsentAuditorImplTest, LocalConsentPrefRepresentation) { EXPECT_EQ(kFeature2NewAppLocale, locale); // We still have two records. - EXPECT_EQ(2u, consents->size()); + EXPECT_EQ(2u, consents->DictSize()); } TEST_F(ConsentAuditorImplTest, RecordGaiaConsentAsUserConsent) { diff --git a/chromium/components/consent_auditor/consent_sync_bridge_impl.cc b/chromium/components/consent_auditor/consent_sync_bridge_impl.cc index 67652540d66..ca51b34a8fa 100644 --- a/chromium/components/consent_auditor/consent_sync_bridge_impl.cc +++ b/chromium/components/consent_auditor/consent_sync_bridge_impl.cc @@ -84,7 +84,7 @@ ConsentSyncBridgeImpl::CreateMetadataChangeList() { return WriteBatch::CreateMetadataChangeList(); } -base::Optional<ModelError> ConsentSyncBridgeImpl::MergeSyncData( +absl::optional<ModelError> ConsentSyncBridgeImpl::MergeSyncData( std::unique_ptr<MetadataChangeList> metadata_change_list, EntityChangeList entity_data) { DCHECK(entity_data.empty()); @@ -95,7 +95,7 @@ base::Optional<ModelError> ConsentSyncBridgeImpl::MergeSyncData( std::move(entity_data)); } -base::Optional<ModelError> ConsentSyncBridgeImpl::ApplySyncChanges( +absl::optional<ModelError> ConsentSyncBridgeImpl::ApplySyncChanges( std::unique_ptr<MetadataChangeList> metadata_change_list, EntityChangeList entity_changes) { std::unique_ptr<WriteBatch> batch = store_->CreateWriteBatch(); @@ -165,7 +165,7 @@ void ConsentSyncBridgeImpl::ReadAllDataAndResubmit() { } void ConsentSyncBridgeImpl::OnReadAllDataToResubmit( - const base::Optional<ModelError>& error, + const absl::optional<ModelError>& error, std::unique_ptr<RecordList> data_records) { if (change_processor()->TrackedAccountId().empty()) { // Meanwhile the sync has been disabled. We will try next time. @@ -249,7 +249,7 @@ void ConsentSyncBridgeImpl::ProcessQueuedEvents() { } void ConsentSyncBridgeImpl::OnStoreCreated( - const base::Optional<ModelError>& error, + const absl::optional<ModelError>& error, std::unique_ptr<ModelTypeStore> store) { if (error) { change_processor()->ReportError(*error); @@ -263,7 +263,7 @@ void ConsentSyncBridgeImpl::OnStoreCreated( } void ConsentSyncBridgeImpl::OnReadAllMetadata( - const base::Optional<ModelError>& error, + const absl::optional<ModelError>& error, std::unique_ptr<MetadataBatch> metadata_batch) { if (error) { change_processor()->ReportError(*error); @@ -280,7 +280,7 @@ void ConsentSyncBridgeImpl::OnReadAllMetadata( } } -void ConsentSyncBridgeImpl::OnCommit(const base::Optional<ModelError>& error) { +void ConsentSyncBridgeImpl::OnCommit(const absl::optional<ModelError>& error) { if (error) { change_processor()->ReportError(*error); } @@ -288,7 +288,7 @@ void ConsentSyncBridgeImpl::OnCommit(const base::Optional<ModelError>& error) { void ConsentSyncBridgeImpl::OnReadData( DataCallback callback, - const base::Optional<ModelError>& error, + const absl::optional<ModelError>& error, std::unique_ptr<RecordList> data_records, std::unique_ptr<IdList> missing_id_list) { OnReadAllData(std::move(callback), error, std::move(data_records)); @@ -296,7 +296,7 @@ void ConsentSyncBridgeImpl::OnReadData( void ConsentSyncBridgeImpl::OnReadAllData( DataCallback callback, - const base::Optional<ModelError>& error, + const absl::optional<ModelError>& error, std::unique_ptr<RecordList> data_records) { if (error) { change_processor()->ReportError(*error); diff --git a/chromium/components/consent_auditor/consent_sync_bridge_impl.h b/chromium/components/consent_auditor/consent_sync_bridge_impl.h index aa959b5657d..8e1f62ccfb3 100644 --- a/chromium/components/consent_auditor/consent_sync_bridge_impl.h +++ b/chromium/components/consent_auditor/consent_sync_bridge_impl.h @@ -13,11 +13,11 @@ #include "base/macros.h" #include "base/memory/weak_ptr.h" -#include "base/optional.h" #include "components/consent_auditor/consent_sync_bridge.h" #include "components/sync/model/model_type_change_processor.h" #include "components/sync/model/model_type_store.h" #include "components/sync/model/model_type_sync_bridge.h" +#include "third_party/abseil-cpp/absl/types/optional.h" namespace consent_auditor { @@ -32,10 +32,10 @@ class ConsentSyncBridgeImpl : public ConsentSyncBridge, // ModelTypeSyncBridge implementation. std::unique_ptr<syncer::MetadataChangeList> CreateMetadataChangeList() override; - base::Optional<syncer::ModelError> MergeSyncData( + absl::optional<syncer::ModelError> MergeSyncData( std::unique_ptr<syncer::MetadataChangeList> metadata_change_list, syncer::EntityChangeList entity_data) override; - base::Optional<syncer::ModelError> ApplySyncChanges( + absl::optional<syncer::ModelError> ApplySyncChanges( std::unique_ptr<syncer::MetadataChangeList> metadata_change_list, syncer::EntityChangeList entity_changes) override; void GetData(StorageKeyList storage_keys, DataCallback callback) override; @@ -61,19 +61,19 @@ class ConsentSyncBridgeImpl : public ConsentSyncBridge, // Record events in the deferred queue and clear the queue. void ProcessQueuedEvents(); - void OnStoreCreated(const base::Optional<syncer::ModelError>& error, + void OnStoreCreated(const absl::optional<syncer::ModelError>& error, std::unique_ptr<syncer::ModelTypeStore> store); - void OnReadAllMetadata(const base::Optional<syncer::ModelError>& error, + void OnReadAllMetadata(const absl::optional<syncer::ModelError>& error, std::unique_ptr<syncer::MetadataBatch> metadata_batch); - void OnCommit(const base::Optional<syncer::ModelError>& error); + void OnCommit(const absl::optional<syncer::ModelError>& error); void OnReadData( DataCallback callback, - const base::Optional<syncer::ModelError>& error, + const absl::optional<syncer::ModelError>& error, std::unique_ptr<syncer::ModelTypeStore::RecordList> data_records, std::unique_ptr<syncer::ModelTypeStore::IdList> missing_id_list); void OnReadAllData( DataCallback callback, - const base::Optional<syncer::ModelError>& error, + const absl::optional<syncer::ModelError>& error, std::unique_ptr<syncer::ModelTypeStore::RecordList> data_records); // Resubmit all the consents persisted in the store to sync consents, which @@ -81,7 +81,7 @@ class ConsentSyncBridgeImpl : public ConsentSyncBridge, // processor already knows about (i.e. with metadata), but it is allowed. void ReadAllDataAndResubmit(); void OnReadAllDataToResubmit( - const base::Optional<syncer::ModelError>& error, + const absl::optional<syncer::ModelError>& error, std::unique_ptr<syncer::ModelTypeStore::RecordList> data_records); // Persistent storage for in flight consents. Should remain quite small, as we |