diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-05-12 15:59:20 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-05-25 06:57:22 +0000 |
commit | f7eaed5286974984ba5f9e3189d8f49d03e99f81 (patch) | |
tree | caed19b2af2024f35449fb0b781d0a25e09d4f8f /chromium/components/cloud_devices | |
parent | 9729c4479fe23554eae6e6dd1f30ff488f470c84 (diff) | |
download | qtwebengine-chromium-f7eaed5286974984ba5f9e3189d8f49d03e99f81.tar.gz |
BASELINE: Update Chromium to 100.0.4896.167
Change-Id: I98cbeb5d7543d966ffe04d8cefded0c493a11333
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/cloud_devices')
4 files changed, 21 insertions, 18 deletions
diff --git a/chromium/components/cloud_devices/common/description_items_inl.h b/chromium/components/cloud_devices/common/description_items_inl.h index f8d7b6ceb2e..ba0ce562f6b 100644 --- a/chromium/components/cloud_devices/common/description_items_inl.h +++ b/chromium/components/cloud_devices/common/description_items_inl.h @@ -51,7 +51,7 @@ bool ListCapability<Option, Traits>::LoadFrom( description.GetItem(Traits::GetCapabilityPath(), base::Value::Type::LIST); if (!options_value) return false; - for (const base::Value& option_value : options_value->GetList()) { + for (const base::Value& option_value : options_value->GetListDeprecated()) { Option option; if (!option_value.is_dict() || !Traits::Load(option_value, &option)) return false; @@ -135,7 +135,7 @@ bool SelectionCapability<Option, Traits>::LoadFrom(const base::Value& dict) { dict.FindKeyOfType(json::kKeyOption, base::Value::Type::LIST); if (!options_value) return false; - for (const base::Value& option_value : options_value->GetList()) { + for (const base::Value& option_value : options_value->GetListDeprecated()) { Option option; if (!option_value.is_dict() || !Traits::Load(option_value, &option)) return false; diff --git a/chromium/components/cloud_devices/common/printer_description.cc b/chromium/components/cloud_devices/common/printer_description.cc index 9292612b528..9ec1d88cec8 100644 --- a/chromium/components/cloud_devices/common/printer_description.cc +++ b/chromium/components/cloud_devices/common/printer_description.cc @@ -21,6 +21,7 @@ #include "base/strings/string_piece.h" #include "base/strings/string_util.h" #include "base/values.h" +#include "build/build_config.h" #include "build/chromeos_buildflags.h" #include "components/cloud_devices/common/cloud_device_description_consts.h" #include "components/cloud_devices/common/description_items_inl.h" @@ -64,9 +65,9 @@ extern constexpr char kOptionRangeCapability[] = "range_cap"; extern constexpr char kOptionSelectCapability[] = "select_cap"; extern constexpr char kOptionTypedValueCapability[] = "typed_value_cap"; extern constexpr char kOptionVendorCapability[] = "vendor_capability"; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) extern constexpr char kOptionPin[] = "pin"; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) constexpr char kMarginBottom[] = "bottom_microns"; constexpr char kMarginLeft[] = "left_microns"; @@ -93,9 +94,9 @@ constexpr char kMinValue[] = "min"; constexpr char kMaxValue[] = "max"; constexpr char kDefaultValue[] = "default"; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) constexpr char kPinSupported[] = "supported"; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) constexpr char kTypeRangeVendorCapabilityFloat[] = "FLOAT"; constexpr char kTypeRangeVendorCapabilityInteger[] = "INTEGER"; @@ -1057,7 +1058,8 @@ class PwgRasterConfigTraits : public NoValueValidation, if (document_types_supported) { if (!document_types_supported->is_list()) return false; - for (const auto& type_value : document_types_supported->GetList()) { + for (const auto& type_value : + document_types_supported->GetListDeprecated()) { if (!type_value.is_string()) return false; @@ -1332,7 +1334,7 @@ class PageRangeTraits : public ItemsTraits<kOptionPageRange> { dict.FindKeyOfType(kPageRangeInterval, base::Value::Type::LIST); if (!list_value) return false; - for (const base::Value& interval : list_value->GetList()) { + for (const base::Value& interval : list_value->GetListDeprecated()) { int page_range_start = interval.FindIntKey(kPageRangeStart).value_or(1); int page_range_end = interval.FindIntKey(kPageRangeEnd).value_or(kMaxPageNumber); @@ -1441,7 +1443,7 @@ class ReverseTraits : public NoValueValidation, } }; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) class PinTraits : public NoValueValidation, public ItemsTraits<kOptionPin> { public: static bool Load(const base::Value& dict, bool* option) { @@ -1456,7 +1458,7 @@ class PinTraits : public NoValueValidation, public ItemsTraits<kOptionPin> { dict->SetKey(kPinSupported, base::Value(option)); } }; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) } // namespace printer @@ -1481,9 +1483,9 @@ template class ValueCapability<printer::Copies, template class EmptyCapability<printer::PageRangeTraits>; template class BooleanCapability<printer::CollateTraits>; template class BooleanCapability<printer::ReverseTraits>; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) template class ValueCapability<bool, printer::PinTraits>; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) template class TicketItem<printer::PwgRasterConfig, printer::PwgRasterConfigTraits>; diff --git a/chromium/components/cloud_devices/common/printer_description.h b/chromium/components/cloud_devices/common/printer_description.h index 9b8c73c2ac2..afe849d16bd 100644 --- a/chromium/components/cloud_devices/common/printer_description.h +++ b/chromium/components/cloud_devices/common/printer_description.h @@ -533,11 +533,11 @@ typedef ValueCapability<Copies, class CopiesCapabilityTraits> CopiesCapability; typedef EmptyCapability<class PageRangeTraits> PageRangeCapability; typedef BooleanCapability<class CollateTraits> CollateCapability; typedef BooleanCapability<class ReverseTraits> ReverseCapability; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) // This capability is not a part of standard CDD description. It's used for // providing PIN printing opportunity in Chrome OS native printing. typedef ValueCapability<bool, class PinTraits> PinCapability; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) typedef TicketItem<PwgRasterConfig, PwgRasterConfigTraits> PwgRasterConfigTicketItem; diff --git a/chromium/components/cloud_devices/common/printer_description_unittest.cc b/chromium/components/cloud_devices/common/printer_description_unittest.cc index 217f8cdbd2e..ccc6b30b10a 100644 --- a/chromium/components/cloud_devices/common/printer_description_unittest.cc +++ b/chromium/components/cloud_devices/common/printer_description_unittest.cc @@ -11,6 +11,7 @@ #include "base/json/json_writer.h" #include "base/strings/string_util.h" #include "base/values.h" +#include "build/build_config.h" #include "build/chromeos_buildflags.h" #include "testing/gtest/include/gtest/gtest.h" @@ -507,7 +508,7 @@ const char kSeveralInnerCapabilitiesVendorCapabilityCdd[] = R"( } })"; -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) const char kPinOnlyCdd[] = R"( { "version": "1.0", @@ -517,7 +518,7 @@ const char kPinOnlyCdd[] = R"( } } })"; -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) const char kCjt[] = R"( { @@ -1103,7 +1104,7 @@ TEST(PrinterDescriptionTest, CddSetVendorCapability) { NormalizeJson(description.ToString())); } -#if defined(OS_CHROMEOS) +#if BUILDFLAG(IS_CHROMEOS) TEST(PrinterDescriptionTest, CddGetPin) { { CloudDeviceDescription description; @@ -1129,7 +1130,7 @@ TEST(PrinterDescriptionTest, CddSetPin) { pin_capability.SaveTo(&description); EXPECT_EQ(NormalizeJson(kPinOnlyCdd), NormalizeJson(description.ToString())); } -#endif // defined(OS_CHROMEOS) +#endif // BUILDFLAG(IS_CHROMEOS) TEST(PrinterDescriptionTest, CddGetAll) { CloudDeviceDescription description; |