diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-03-12 09:13:00 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-03-16 09:58:26 +0000 |
commit | 03561cae90f1d99b5c54b1ef3be69f10e882b25e (patch) | |
tree | cc5f0958e823c044e7ae51cc0117fe51432abe5e /chromium/components/background_task_scheduler | |
parent | fa98118a45f7e169f8846086dc2c22c49a8ba310 (diff) | |
download | qtwebengine-chromium-03561cae90f1d99b5c54b1ef3be69f10e882b25e.tar.gz |
BASELINE: Update Chromium to 88.0.4324.208
Change-Id: I3ae87d23e4eff4b4a469685658740a213600c667
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/components/background_task_scheduler')
6 files changed, 10 insertions, 56 deletions
diff --git a/chromium/components/background_task_scheduler/BUILD.gn b/chromium/components/background_task_scheduler/BUILD.gn index a98456fa561..a24e667918e 100644 --- a/chromium/components/background_task_scheduler/BUILD.gn +++ b/chromium/components/background_task_scheduler/BUILD.gn @@ -132,6 +132,7 @@ if (is_android) { "//base:base_java_test_support", "//base:base_junit_test_support", "//components/background_task_scheduler:public_java", + "//third_party/android_deps:chromium_play_services_availability_shadows_java", "//third_party/android_deps:robolectric_all_java", "//third_party/junit", "//third_party/mockito:mockito_java", diff --git a/chromium/components/background_task_scheduler/internal/BUILD.gn b/chromium/components/background_task_scheduler/internal/BUILD.gn index 1ce3ec4bf86..3bbe8e393d3 100644 --- a/chromium/components/background_task_scheduler/internal/BUILD.gn +++ b/chromium/components/background_task_scheduler/internal/BUILD.gn @@ -36,6 +36,7 @@ if (is_android) { "//components/background_task_scheduler:public_java", "//content/public/android:content_java", "//third_party/android_deps:androidx_annotation_annotation_java", + "//third_party/android_deps:chromium_play_services_availability_java", "//third_party/android_deps:protobuf_lite_runtime_java", ] } diff --git a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerGcmNetworkManagerTest.java b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerGcmNetworkManagerTest.java index 43b014e6c73..823b8028d27 100644 --- a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerGcmNetworkManagerTest.java +++ b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerGcmNetworkManagerTest.java @@ -12,8 +12,6 @@ import static org.junit.Assert.assertTrue; import android.os.Bundle; -import com.google.android.gms.common.ConnectionResult; -import com.google.android.gms.common.GoogleApiAvailability; import com.google.android.gms.gcm.GcmNetworkManager; import com.google.android.gms.gcm.OneoffTask; import com.google.android.gms.gcm.PeriodicTask; @@ -25,8 +23,6 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.annotation.Config; import org.robolectric.shadow.api.Shadow; -import org.robolectric.shadows.gms.Shadows; -import org.robolectric.shadows.gms.common.ShadowGoogleApiAvailability; import org.chromium.base.ContextUtils; import org.chromium.base.test.BaseRobolectricTestRunner; @@ -35,13 +31,14 @@ import org.chromium.components.background_task_scheduler.BackgroundTask; import org.chromium.components.background_task_scheduler.TaskIds; import org.chromium.components.background_task_scheduler.TaskInfo; import org.chromium.components.background_task_scheduler.TaskParameters; +import org.chromium.gms.shadows.ShadowChromiumPlayServicesAvailability; import java.util.concurrent.TimeUnit; /** Unit tests for {@link BackgroundTaskSchedulerGcmNetworkManager}. */ @RunWith(BaseRobolectricTestRunner.class) @Config(manifest = Config.NONE, - shadows = {ShadowGcmNetworkManager.class, ShadowGoogleApiAvailability.class}) + shadows = {ShadowGcmNetworkManager.class, ShadowChromiumPlayServicesAvailability.class}) public class BackgroundTaskSchedulerGcmNetworkManagerTest { ShadowGcmNetworkManager mGcmNetworkManager; @@ -59,8 +56,7 @@ public class BackgroundTaskSchedulerGcmNetworkManagerTest { @Before public void setUp() { - Shadows.shadowOf(GoogleApiAvailability.getInstance()) - .setIsGooglePlayServicesAvailable(ConnectionResult.SUCCESS); + ShadowChromiumPlayServicesAvailability.setIsGooglePlayServicesAvailable(true); mGcmNetworkManager = (ShadowGcmNetworkManager) Shadow.extract( GcmNetworkManager.getInstance(ContextUtils.getApplicationContext())); BackgroundTaskSchedulerGcmNetworkManager.setClockForTesting(mClock); @@ -301,8 +297,7 @@ public class BackgroundTaskSchedulerGcmNetworkManagerTest { @Test @Feature("BackgroundTaskScheduler") public void testScheduleNoGooglePlayServices() { - Shadows.shadowOf(GoogleApiAvailability.getInstance()) - .setIsGooglePlayServicesAvailable(ConnectionResult.SERVICE_MISSING); + ShadowChromiumPlayServicesAvailability.setIsGooglePlayServicesAvailable(false); TaskInfo.TimingInfo timingInfo = TaskInfo.OneOffInfo.create().setWindowEndTimeMs(TIME_24_H_TO_MS).build(); @@ -332,8 +327,7 @@ public class BackgroundTaskSchedulerGcmNetworkManagerTest { @Feature("BackgroundTaskScheduler") public void testCancelNoGooglePlayServices() { // This simulates situation where Google Play Services is uninstalled. - Shadows.shadowOf(GoogleApiAvailability.getInstance()) - .setIsGooglePlayServicesAvailable(ConnectionResult.SERVICE_MISSING); + ShadowChromiumPlayServicesAvailability.setIsGooglePlayServicesAvailable(false); TaskInfo.TimingInfo timingInfo = TaskInfo.OneOffInfo.create().setWindowEndTimeMs(TIME_24_H_TO_MS).build(); diff --git a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerImplTest.java b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerImplTest.java index e0e19b33517..c29abef0187 100644 --- a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerImplTest.java +++ b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerImplTest.java @@ -15,8 +15,6 @@ import static org.mockito.Mockito.verify; import android.os.Build; -import com.google.android.gms.common.ConnectionResult; -import com.google.android.gms.common.GoogleApiAvailability; import com.google.android.gms.gcm.GcmNetworkManager; import org.junit.Before; @@ -27,8 +25,6 @@ import org.mockito.MockitoAnnotations; import org.robolectric.RuntimeEnvironment; import org.robolectric.annotation.Config; import org.robolectric.shadow.api.Shadow; -import org.robolectric.shadows.gms.Shadows; -import org.robolectric.shadows.gms.common.ShadowGoogleApiAvailability; import org.robolectric.util.ReflectionHelpers; import org.chromium.base.ContextUtils; @@ -37,13 +33,14 @@ import org.chromium.base.test.util.Feature; import org.chromium.components.background_task_scheduler.BackgroundTaskScheduler; import org.chromium.components.background_task_scheduler.TaskIds; import org.chromium.components.background_task_scheduler.TaskInfo; +import org.chromium.gms.shadows.ShadowChromiumPlayServicesAvailability; import java.util.concurrent.TimeUnit; /** Unit tests for {@link BackgroundTaskScheduler}. */ @RunWith(BaseRobolectricTestRunner.class) @Config(manifest = Config.NONE, - shadows = {ShadowGcmNetworkManager.class, ShadowGoogleApiAvailability.class}) + shadows = {ShadowGcmNetworkManager.class, ShadowChromiumPlayServicesAvailability.class}) public class BackgroundTaskSchedulerImplTest { @Mock private BackgroundTaskSchedulerDelegate mDelegate; @@ -66,8 +63,7 @@ public class BackgroundTaskSchedulerImplTest { TestBackgroundTask.reset(); // Initialize Google Play Services and GCM Network Manager for upgrade testing. - Shadows.shadowOf(GoogleApiAvailability.getInstance()) - .setIsGooglePlayServicesAvailable(ConnectionResult.SUCCESS); + ShadowChromiumPlayServicesAvailability.setIsGooglePlayServicesAvailable(true); mGcmNetworkManager = (ShadowGcmNetworkManager) Shadow.extract( GcmNetworkManager.getInstance(ContextUtils.getApplicationContext())); diff --git a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerPrefsTest.java b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerPrefsTest.java index ee6938a6be0..206f31bb696 100644 --- a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerPrefsTest.java +++ b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerPrefsTest.java @@ -8,10 +8,6 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -import static org.mockito.ArgumentMatchers.eq; -import static org.mockito.Mockito.doNothing; -import static org.mockito.Mockito.times; -import static org.mockito.Mockito.verify; import android.content.SharedPreferences; import android.os.Build; @@ -19,9 +15,6 @@ import android.os.Build; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.ArgumentMatchers; -import org.mockito.MockitoAnnotations; -import org.mockito.Spy; import org.robolectric.annotation.Config; import org.robolectric.util.ReflectionHelpers; @@ -42,9 +35,6 @@ import java.util.concurrent.TimeUnit; @RunWith(BaseRobolectricTestRunner.class) @Config(manifest = Config.NONE) public class BackgroundTaskSchedulerPrefsTest { - @Spy - private BackgroundTaskSchedulerUma mUmaSpy; - private TaskInfo mTask1; private TaskInfo mTask2; @@ -57,10 +47,6 @@ public class BackgroundTaskSchedulerPrefsTest { @Before public void setUp() { - MockitoAnnotations.initMocks(this); - BackgroundTaskSchedulerUma.setInstanceForTesting(mUmaSpy); - doNothing().when(mUmaSpy).assertNativeIsLoaded(); - TaskInfo.TimingInfo timingInfo1 = TaskInfo.OneOffInfo.create().setWindowEndTimeMs(TimeUnit.DAYS.toMillis(1)).build(); mTask1 = TaskInfo.createTask(TaskIds.TEST, timingInfo1).build(); @@ -213,13 +199,6 @@ public class BackgroundTaskSchedulerPrefsTest { editor.apply(); BackgroundTaskSchedulerPrefs.migrateStoredTasksToProto(); - verify(mUmaSpy, times(1)) - .cacheEvent(eq("Android.BackgroundTaskScheduler.MigrationToProto"), - ArgumentMatchers.eq(BackgroundTaskSchedulerUma.BACKGROUND_TASK_TEST)); - verify(mUmaSpy, times(1)) - .cacheEvent(eq("Android.BackgroundTaskScheduler.MigrationToProto"), - ArgumentMatchers.eq( - BackgroundTaskSchedulerUma.BACKGROUND_TASK_OFFLINE_PAGES)); Set<Integer> taskIds = BackgroundTaskSchedulerPrefs.getScheduledTaskIds(); assertTrue(taskIds.contains(mTask1.getTaskId())); @@ -230,12 +209,5 @@ public class BackgroundTaskSchedulerPrefsTest { .getClass()); BackgroundTaskSchedulerPrefs.migrateStoredTasksToProto(); - verify(mUmaSpy, times(1)) - .cacheEvent(eq("Android.BackgroundTaskScheduler.MigrationToProto"), - ArgumentMatchers.eq(BackgroundTaskSchedulerUma.BACKGROUND_TASK_TEST)); - verify(mUmaSpy, times(1)) - .cacheEvent(eq("Android.BackgroundTaskScheduler.MigrationToProto"), - ArgumentMatchers.eq( - BackgroundTaskSchedulerUma.BACKGROUND_TASK_OFFLINE_PAGES)); } } diff --git a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerUmaTest.java b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerUmaTest.java index cefc5d21a80..20d04de27c2 100644 --- a/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerUmaTest.java +++ b/chromium/components/background_task_scheduler/internal/android/junit/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerUmaTest.java @@ -308,16 +308,6 @@ public class BackgroundTaskSchedulerUmaTest { @Test @Feature({"BackgroundTaskScheduler"}) - public void testReportMigrationToProto() { - doNothing().when(mUmaSpy).cacheEvent(anyString(), anyInt()); - BackgroundTaskSchedulerUma.getInstance().reportMigrationToProto(TaskIds.TEST); - verify(mUmaSpy, times(1)) - .cacheEvent(eq("Android.BackgroundTaskScheduler.MigrationToProto"), - ArgumentMatchers.eq(BackgroundTaskSchedulerUma.BACKGROUND_TASK_TEST)); - } - - @Test - @Feature({"BackgroundTaskScheduler"}) public void testReportTaskStartedNativeFullBrowser() { doNothing().when(mUmaSpy).cacheEvent(anyString(), anyInt()); mExternalUma.reportTaskStartedNative(TaskIds.DOWNLOAD_SERVICE_JOB_ID, false); |