diff options
| author | Alexandru Croitor <alexandru.croitor@qt.io> | 2018-11-13 18:22:57 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-11-13 18:25:11 +0000 |
| commit | 91432e048e9bef479cc61f97d6ab4599121a1990 (patch) | |
| tree | ee57ef32ce2195216749fc680fb21d1c5d6c5a89 | |
| parent | c2aeb1c6d21cd952be6b2c1ed765e4c5f0b2d340 (diff) | |
| download | qtwebengine-chromium-91432e048e9bef479cc61f97d6ab4599121a1990.tar.gz | |
Fix assert in V8 mksnapshot when building on macOSv5.12.0-rc2v5.12.0-rc1v5.12.0
The "assert" keyword seemed to be a typescript construct from the ported
patch, and it caused a crash while building:
/usr/bin/python chromium/v8/tools/run.py
./mksnapshot --turbo_instruction_scheduling --embedded_src gen/v8/embedded.cc --embedded_variant Default --random-seed 314159265
--startup_src gen/v8/snapshot.cc
FAILED: gen/v8/embedded.cc gen/v8/snapshot.cc /usr/bin/python ../../../../../qt512_source/qtwebengine/src/3rdparty/chromium/v8/tools/run.py
./mksnapshot --turbo_instruction_scheduling --embedded_src gen/v8/embedded.cc --embedded_variant Default --random-seed 314159265
--startup_src gen/v8/snapshot.cc
# Fatal error in
# ../../../../../qt512_source/qtwebengine/src/3rdparty/chromium/v8/src/ast/ast-value-factory.h, # line 75 # Debug check failed: has_string_.
#
#FailureMessage Object: 0x7ffeef8da3b0
==== C stack trace ===============================
0 mksnapshot 0x0000000100ffb393 v8::base::debug::StackTrace::StackTrace() + 19
1 mksnapshot 0x0000000100ffec99 v8::platform::(anonymous namespace)::PrintStackTrace() + 41
2 mksnapshot 0x0000000100ff5465 V8_Fatal(char const*, int, char const*, ...) + 325
3 mksnapshot 0x0000000100ff4fd5 v8::base::(anonymous namespace)::DefaultDcheckHandler(char const*, int, char const*) + 21
4 mksnapshot 0x0000000100364b05 v8::internal::AstRawString::string() const + 85
Remove the line for now.
Amends c2aeb1c6d21cd952be6b2c1ed765e4c5f0b2d340.
Change-Id: I0c89f71df00734a15f33159d2a11e7403c89bfcf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| -rw-r--r-- | chromium/v8/src/js/array.js | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chromium/v8/src/js/array.js b/chromium/v8/src/js/array.js index f5617919a86..35db963d183 100644 --- a/chromium/v8/src/js/array.js +++ b/chromium/v8/src/js/array.js @@ -793,7 +793,6 @@ function InnerArraySort(array, length, comparefn) { // array and move the undefineds after that. Holes are removed. // This happens for Array as well as non-Array objects. var num_non_undefined = %PrepareElementsForSort(array, length); - assert(num_non_undefined <= length); QuickSort(array, 0, num_non_undefined); |