diff options
author | Danil Somsikov <dsv@chromium.org> | 2023-01-20 17:12:52 +0100 |
---|---|---|
committer | Michael BrĂ¼ning <michael.bruning@qt.io> | 2023-04-04 11:26:22 +0000 |
commit | d4dae0cad196bcb864975f30198bd0b6d32b3778 (patch) | |
tree | 42629f37e1694e58a4ecf6c952f2f1492f2e4fb6 | |
parent | bfc3d37f27958e5ce7dbb5b5a95d338cf7334986 (diff) | |
download | qtwebengine-chromium-d4dae0cad196bcb864975f30198bd0b6d32b3778.tar.gz |
[Backport] Security bug 1337747
Cherry-pick of patch originally reviewed on
https://chromium-review.googlesource.com/c/v8/v8/+/4184203:
Fix error dispatch in the v8 inspector session.
Bug: chromium:1337747
Change-Id: I920f3c6370ac9f9bc351eff34e46b1e8d520fe3e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4184203
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85449}
Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/469847
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r-- | chromium/v8/src/inspector/v8-inspector-session-impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chromium/v8/src/inspector/v8-inspector-session-impl.cc b/chromium/v8/src/inspector/v8-inspector-session-impl.cc index 8db491bf68a..72bc16ac269 100644 --- a/chromium/v8/src/inspector/v8-inspector-session-impl.cc +++ b/chromium/v8/src/inspector/v8-inspector-session-impl.cc @@ -364,7 +364,7 @@ void V8InspectorSessionImpl::dispatchProtocolMessage(StringView message) { } v8_crdtp::Dispatchable dispatchable(cbor); if (!dispatchable.ok()) { - if (dispatchable.HasCallId()) { + if (!dispatchable.HasCallId()) { m_channel->sendNotification(serializeForFrontend( v8_crdtp::CreateErrorNotification(dispatchable.DispatchError()))); } else { |