diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2019-10-17 08:44:34 +0000 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2019-10-17 08:44:43 +0000 |
commit | 18d4c6e8250324d084d89b17ad80721bb46ddbd9 (patch) | |
tree | 89b5b85551c4a2a380a5b274f5e838c696a86c54 | |
parent | a42666a17663f7fdad5be9640527b60d6018cea5 (diff) | |
download | qtwebengine-chromium-18d4c6e8250324d084d89b17ad80721bb46ddbd9.tar.gz |
Revert "[Backport] CVE-2019-13668"
This reverts commit 8635cf233cdf15409fcce7a66f0bc4670d07cd5f.
Reason for revert: Missing dependency
Change-Id: If4221d3738851f48e0176b6ab6b3ed9ea6562a9f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
-rw-r--r-- | chromium/v8/src/builtins/builtins-console.cc | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/chromium/v8/src/builtins/builtins-console.cc b/chromium/v8/src/builtins/builtins-console.cc index a7a213b4b27..6b7db301d68 100644 --- a/chromium/v8/src/builtins/builtins-console.cc +++ b/chromium/v8/src/builtins/builtins-console.cc @@ -46,22 +46,6 @@ void ConsoleCall( CHECK(!isolate->has_scheduled_exception()); if (!isolate->console_delegate()) return; HandleScope scope(isolate); - - // Access check. The current context has to match the context of all - // arguments, otherwise the inspector might leak objects across contexts. - Handle<Context> context = handle(isolate->context(), isolate); - for (int i = 0; i < args.length(); ++i) { - Handle<Object> argument = args.at<Object>(i); - if (!argument->IsJSObject()) continue; - - Handle<JSObject> argument_obj = Handle<JSObject>::cast(argument); - if (argument->IsAccessCheckNeeded(isolate) && - !isolate->MayAccess(context, argument_obj)) { - isolate->ReportFailedAccessCheck(argument_obj); - return; - } - } - debug::ConsoleCallArguments wrapper(args); Handle<Object> context_id_obj = JSObject::GetDataProperty( args.target(), isolate->factory()->console_context_id_symbol()); |