summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2018-01-22 13:14:41 +0100
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2018-01-22 14:00:38 +0000
commit86153a8b45ea0f889278c09d82964f0634d9bfd8 (patch)
tree069d0045b2e0437a095877c4ad6b1a613f3f312f
parent252832be510aa0862608db51970caaa50db68cce (diff)
downloadqtwebengine-chromium-86153a8b45ea0f889278c09d82964f0634d9bfd8.tar.gz
Make optimize_for_size an arg again
Otherwise we can not configure it. Change-Id: If2900e9f142c945c921df46be21e7eb14ee2d1cb Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r--chromium/build/config/compiler/compiler.gni24
1 files changed, 13 insertions, 11 deletions
diff --git a/chromium/build/config/compiler/compiler.gni b/chromium/build/config/compiler/compiler.gni
index ad40fd9cd05..801da763dbf 100644
--- a/chromium/build/config/compiler/compiler.gni
+++ b/chromium/build/config/compiler/compiler.gni
@@ -72,19 +72,21 @@ declare_args() {
assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO")
-# Exclude unwind tables for official builds as unwinding can be done from stack
-# dumps produced by Crashpad at a later time "offline" in the crash server.
-# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
-# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
-# to unwind at runtime.
-exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
+declare_args() {
+ # Exclude unwind tables for official builds as unwinding can be done from stack
+ # dumps produced by Crashpad at a later time "offline" in the crash server.
+ # For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
+ # which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
+ # to unwind at runtime.
+ exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug)
-# If true, optimize for size. Does not affect windows builds.
-# Linux & Mac favor speed over size.
-# TODO(brettw) it's weird that Mac and desktop Linux are different. We should
-# explore favoring size over speed in this case as well.
-optimize_for_size = is_android || is_ios
+ # If true, optimize for size. Does not affect windows builds.
+ # Linux & Mac favor speed over size.
+ # TODO(brettw) it's weird that Mac and desktop Linux are different. We should
+ # explore favoring size over speed in this case as well.
+ optimize_for_size = is_android || is_ios
+}
# Determine whether to enable or disable frame pointers, based on the platform
# and build arguments.