diff options
author | Michael BrĂ¼ning <michael.bruning@qt.io> | 2019-12-02 09:46:14 +0100 |
---|---|---|
committer | Michael BrĂ¼ning <michael.bruning@qt.io> | 2019-12-02 12:45:30 +0000 |
commit | 826925df7041dea79b98e270f3244d61ec61d9d0 (patch) | |
tree | 1b83187d21f1c22bd4d8b7be17933e36c767bd55 | |
parent | d5618f4b2ceaa8f4f21fae3f7944b4e1c16cf5d0 (diff) | |
download | qtwebengine-chromium-826925df7041dea79b98e270f3244d61ec61d9d0.tar.gz |
[Backport] Fix for CVE-2019-5808
Manual backport from scoped_refptr to WTF::RefPtr
Make ElementResolveContext hold a ref to the root element's ComputedStyle
Bug: 947029
Change-Id: I94fc947269bdeb868df6439c70bf9dbc8f24ab4b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
-rw-r--r-- | chromium/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chromium/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h b/chromium/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h index a28c1147c27..34f383a86c0 100644 --- a/chromium/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h +++ b/chromium/third_party/WebKit/Source/core/css/resolver/ElementResolveContext.h @@ -45,7 +45,7 @@ class CORE_EXPORT ElementResolveContext { Element* element() const { return m_element; } const ContainerNode* parentNode() const { return m_parentNode; } - const ComputedStyle* rootElementStyle() const { return m_rootElementStyle; } + const ComputedStyle* rootElementStyle() const { return m_rootElementStyle.get(); } const ComputedStyle* parentStyle() const { return parentNode() ? parentNode()->computedStyle() : nullptr; } @@ -57,7 +57,7 @@ class CORE_EXPORT ElementResolveContext { private: Member<Element> m_element; Member<ContainerNode> m_parentNode; - const ComputedStyle* m_rootElementStyle; + RefPtr<const ComputedStyle> m_rootElementStyle; EInsideLink m_elementLinkState; bool m_distributedToInsertionPoint; }; |