diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-11-09 11:33:05 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-11-15 10:21:12 +0000 |
commit | e104b98b5c9821f60cf5df2ec83f9ec5933e5a35 (patch) | |
tree | eee7156bbb6a6f861ffa886c75e321a6f41aab91 | |
parent | 75e14056f718a90dbccf65671c1af1a4b3c8ff1a (diff) | |
download | qtwebengine-chromium-e104b98b5c9821f60cf5df2ec83f9ec5933e5a35.tar.gz |
FIXUP: C++20 initializations
Change-Id: I39279fad02aeb01f9e5d3f34b4dfc7bba28713b7
Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/442398
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
55 files changed, 229 insertions, 220 deletions
diff --git a/chromium/base/power_monitor/battery_level_provider_win.cc b/chromium/base/power_monitor/battery_level_provider_win.cc index 00f04e837de..9c3895334f1 100644 --- a/chromium/base/power_monitor/battery_level_provider_win.cc +++ b/chromium/base/power_monitor/battery_level_provider_win.cc @@ -227,11 +227,11 @@ BatteryLevelProviderWin::GetBatteryStateImpl() { } battery_details_list.push_back(BatteryDetails( - {.is_external_power_connected = + {/*.is_external_power_connected =*/ !!(battery_status->PowerState & BATTERY_POWER_ON_LINE), - .current_capacity = battery_status->Capacity, - .full_charged_capacity = battery_information->FullChargedCapacity, - .charge_unit = + /*.current_capacity =*/ battery_status->Capacity, + /*.full_charged_capacity =*/ battery_information->FullChargedCapacity, +// .charge_unit = ((battery_information->Capabilities & BATTERY_CAPACITY_RELATIVE) ? BatteryLevelUnit::kRelative : BatteryLevelUnit::kMWh)})); diff --git a/chromium/base/threading/platform_thread_win.cc b/chromium/base/threading/platform_thread_win.cc index 960d0100e18..959e494246e 100644 --- a/chromium/base/threading/platform_thread_win.cc +++ b/chromium/base/threading/platform_thread_win.cc @@ -472,10 +472,10 @@ void SetCurrentThreadQualityOfService(ThreadType thread_type) { } THREAD_POWER_THROTTLING_STATE thread_power_throttling_state{ - .Version = THREAD_POWER_THROTTLING_CURRENT_VERSION, - .ControlMask = + /*.Version =*/ THREAD_POWER_THROTTLING_CURRENT_VERSION, +// .ControlMask = desire_ecoqos ? THREAD_POWER_THROTTLING_EXECUTION_SPEED : 0ul, - .StateMask = +// .StateMask = desire_ecoqos ? THREAD_POWER_THROTTLING_EXECUTION_SPEED : 0ul, }; [[maybe_unused]] const BOOL success = set_thread_information_fn( diff --git a/chromium/components/autofill/content/renderer/autofill_agent.cc b/chromium/components/autofill/content/renderer/autofill_agent.cc index 0a7f150cd5b..8fcef7e1910 100644 --- a/chromium/components/autofill/content/renderer/autofill_agent.cc +++ b/chromium/components/autofill/content/renderer/autofill_agent.cc @@ -449,7 +449,9 @@ void AutofillAgent::OnTextFieldDidChange(const WebInputElement& element) { return; } - ShowSuggestions(element, {.requires_caret_at_end = true}); + ShowSuggestionsOptions options; + options.requires_caret_at_end = true; + ShowSuggestions(element, options); FormData form; FormFieldData field; @@ -469,17 +471,20 @@ void AutofillAgent::TextFieldDidReceiveKeyDown(const WebInputElement& element, if (event.windows_key_code == ui::VKEY_DOWN || event.windows_key_code == ui::VKEY_UP) { - ShowSuggestions(element, - {.autofill_on_empty_values = true, - .requires_caret_at_end = true, - .autoselect_first_suggestion = - ShouldAutoselectFirstSuggestionOnArrowDown()}); + ShowSuggestionsOptions options; + options.autofill_on_empty_values = true; + options.requires_caret_at_end = true; + options.autoselect_first_suggestion = + ShouldAutoselectFirstSuggestionOnArrowDown(); + ShowSuggestions(element, options); } } void AutofillAgent::OpenTextDataListChooser(const WebInputElement& element) { DCHECK(IsOwnedByFrame(element, render_frame())); - ShowSuggestions(element, {.autofill_on_empty_values = true}); + ShowSuggestionsOptions options; + options.autofill_on_empty_values = true; + ShowSuggestions(element, options); } // Notifies the AutofillDriver about changes in the <datalist> options in @@ -1136,16 +1141,17 @@ void AutofillAgent::FormControlElementClicked( password_autofill_agent_->TryToShowTouchToFill(element); #endif - ShowSuggestions( - element, {.autofill_on_empty_values = true, + ShowSuggestionsOptions options; + options.autofill_on_empty_values = true; // Even if the user has not edited an input element, it may // still contain a value: A default value filled by the website. // In that case, we don't want to elide suggestions that don't // have a common prefix with the default value. - .show_full_suggestion_list = - element.IsAutofilled() || !element.UserHasEditedTheField(), - .touch_to_fill_eligible = TouchToFillEligible(true)}); + options.show_full_suggestion_list = + element.IsAutofilled() || !element.UserHasEditedTheField(); + options.touch_to_fill_eligible = TouchToFillEligible(true); + ShowSuggestions(element, std::move(options)); SendPotentiallySubmittedFormToBrowser(); } diff --git a/chromium/components/cdm/renderer/widevine_key_system_properties.cc b/chromium/components/cdm/renderer/widevine_key_system_properties.cc index 22e426ece92..b03b117504b 100644 --- a/chromium/components/cdm/renderer/widevine_key_system_properties.cc +++ b/chromium/components/cdm/renderer/widevine_key_system_properties.cc @@ -222,7 +222,7 @@ EmeConfig::Rule WidevineKeySystemProperties::GetRobustnessConfigRule( EmeConfig tmp = {}; tmp.identifier = EmeConfigRuleState::kRequired; tmp.persistence = EmeConfigRuleState::kRequired; - tmp.hw_secure_codecs = EmeConfigRuleState::kRequired}; + tmp.hw_secure_codecs = EmeConfigRuleState::kRequired; return tmp; } else { return media::EmeConfig::UnsupportedRule(); diff --git a/chromium/components/site_isolation/site_isolation_policy.cc b/chromium/components/site_isolation/site_isolation_policy.cc index 2825c37c13a..42ec98093f2 100644 --- a/chromium/components/site_isolation/site_isolation_policy.cc +++ b/chromium/components/site_isolation/site_isolation_policy.cc @@ -95,9 +95,9 @@ bool ShouldDisableSiteIsolationDueToMemorySlow( IsolationDisableDecisions MakeBothDecisions() { IsolationDisableDecisions result{ - .should_disable_strict = ShouldDisableSiteIsolationDueToMemorySlow( + /*.should_disable_strict =*/ ShouldDisableSiteIsolationDueToMemorySlow( content::SiteIsolationMode::kStrictSiteIsolation), - .should_disable_partial = ShouldDisableSiteIsolationDueToMemorySlow( + /*.should_disable_partial =*/ ShouldDisableSiteIsolationDueToMemorySlow( content::SiteIsolationMode::kPartialSiteIsolation)}; return result; } diff --git a/chromium/content/app/content_main_runner_impl.cc b/chromium/content/app/content_main_runner_impl.cc index 0369988d1ae..0bd3a3a26e7 100644 --- a/chromium/content/app/content_main_runner_impl.cc +++ b/chromium/content/app/content_main_runner_impl.cc @@ -1091,7 +1091,7 @@ int ContentMainRunnerImpl::RunBrowser(MainFunctionParams main_params, if (!mojo_ipc_support_) { const ContentMainDelegate::InvokedInBrowserProcess invoked_in_browser{ - .is_running_test = !main_params.ui_task.is_null()}; + /*.is_running_test =*/ !main_params.ui_task.is_null()}; if (delegate_->ShouldCreateFeatureList(invoked_in_browser)) { // This is intentionally leaked since it needs to live for the duration // of the process and there's no benefit in cleaning it up at exit. diff --git a/chromium/content/browser/aggregation_service/aggregation_service_impl.cc b/chromium/content/browser/aggregation_service/aggregation_service_impl.cc index 19d5f77990e..c4079d23584 100644 --- a/chromium/content/browser/aggregation_service/aggregation_service_impl.cc +++ b/chromium/content/browser/aggregation_service/aggregation_service_impl.cc @@ -179,8 +179,8 @@ void AggregationServiceImpl::OnReportAssemblyComplete( scheduler_->NotifyInProgressRequestFailed(request_id); NotifyReportHandled( AggregationServiceStorage::RequestAndId{ - .request = std::move(report_request), - .id = request_id, + /*.request =*/ std::move(report_request), + /*.id =*/ request_id, }, /*report=*/absl::nullopt, AggregationServiceObserver::ReportStatus::kFailedToAssemble); @@ -199,8 +199,8 @@ void AggregationServiceImpl::OnReportAssemblyComplete( // `base::Unretained` is safe as the sender is owned by `this`. base::Unretained(this), std::move(done), AggregationServiceStorage::RequestAndId{ - .request = std::move(report_request), - .id = request_id, + /*.request =*/ std::move(report_request), + /*.id =*/ request_id, }, std::move(*report))); } @@ -308,4 +308,4 @@ void AggregationServiceImpl::NotifyRequestStorageModified() { } } -} // namespace content
\ No newline at end of file +} // namespace content diff --git a/chromium/content/browser/aggregation_service/aggregation_service_storage_sql.cc b/chromium/content/browser/aggregation_service/aggregation_service_storage_sql.cc index a3c9a8d2bba..2b0ec24c167 100644 --- a/chromium/content/browser/aggregation_service/aggregation_service_storage_sql.cc +++ b/chromium/content/browser/aggregation_service/aggregation_service_storage_sql.cc @@ -568,8 +568,8 @@ AggregationServiceStorageSql::GetRequestsReportingOnOrBefore( return {}; result.push_back(AggregationServiceStorage::RequestAndId{ - .request = std::move(parsed_request.value()), - .id = AggregationServiceStorage::RequestId( + /*.request =*/ std::move(parsed_request.value()), + /*.id =*/ AggregationServiceStorage::RequestId( get_requests_statement.ColumnInt64(0))}); } @@ -604,8 +604,8 @@ AggregationServiceStorageSql::GetRequests( if (!parsed_request) continue; result.push_back(AggregationServiceStorage::RequestAndId{ - .request = std::move(*parsed_request), - .id = id, + /*.request =*/ std::move(*parsed_request), + /*.id =*/ id, }); } return result; diff --git a/chromium/content/browser/attribution_reporting/attribution_data_host_manager_impl.cc b/chromium/content/browser/attribution_reporting/attribution_data_host_manager_impl.cc index 38b100c079c..3428c60f7e8 100644 --- a/chromium/content/browser/attribution_reporting/attribution_data_host_manager_impl.cc +++ b/chromium/content/browser/attribution_reporting/attribution_data_host_manager_impl.cc @@ -272,8 +272,9 @@ void AttributionDataHostManagerImpl::NotifyNavigationRedirectRegistation( auto [it, inserted] = redirect_registrations_.try_emplace( attribution_src_token, NavigationRedirectSourceRegistrations{ - .source_origin = source_origin, - .register_time = base::TimeTicks::Now()}); + /*.source_origin =*/ source_origin, + 0, {}, {}, + /*.register_time =*/ base::TimeTicks::Now()}); // Redirect data may not be registered if the navigation is already finished. DCHECK(it->second.destination.opaque()); @@ -309,10 +310,11 @@ void AttributionDataHostManagerImpl::NotifyNavigationForDataHost( if (it != navigation_data_host_map_.end()) { receivers_.Add( this, std::move(it->second.data_host), - FrozenContext{.context_origin = source_origin, - .source_type = AttributionSourceType::kNavigation, - .destination = net::SchemefulSite(destination_origin), - .register_time = it->second.register_time}); + FrozenContext{/*.context_origin =*/ source_origin, + /*.source_type =*/ AttributionSourceType::kNavigation, + /*.destination =*/ net::SchemefulSite(destination_origin), + RegistrationType::kNone, 0, + /*.register_time =*/ it->second.register_time}); navigation_data_host_map_.erase(it); RecordNavigationDataHostStatus(NavigationDataHostStatus::kProcessed); diff --git a/chromium/content/browser/preloading/prefetch/prefetch_canary_checker.h b/chromium/content/browser/preloading/prefetch/prefetch_canary_checker.h index b72958c96a0..439ad772531 100644 --- a/chromium/content/browser/preloading/prefetch/prefetch_canary_checker.h +++ b/chromium/content/browser/preloading/prefetch/prefetch_canary_checker.h @@ -68,14 +68,14 @@ class CONTENT_EXPORT PrefetchCanaryChecker { // Backoff policy to use to compute how long we should wait between the end // of last retry and start of next retry. net::BackoffEntry::Policy backoff_policy = { - .num_errors_to_ignore = 0, - .initial_delay_ms = 100, - .multiply_factor = 2, - .jitter_factor = 0.2, + /*.num_errors_to_ignore =*/ 0, + /*.initial_delay_ms =*/ 100, + /*.multiply_factor =*/ 2, + /*.jitter_factor =*/ 0.2, // No maximum backoff. - .maximum_backoff_ms = -1, - .entry_lifetime_ms = -1, - .always_use_initial_delay = false, + /*.maximum_backoff_ms =*/ -1, + /*.entry_lifetime_ms =*/ -1, + /*.always_use_initial_delay =*/ false, }; }; diff --git a/chromium/content/browser/preloading/speculation_rules/speculation_host_impl.cc b/chromium/content/browser/preloading/speculation_rules/speculation_host_impl.cc index 691f7a842f9..dc4c671fcf9 100644 --- a/chromium/content/browser/preloading/speculation_rules/speculation_host_impl.cc +++ b/chromium/content/browser/preloading/speculation_rules/speculation_host_impl.cc @@ -287,9 +287,9 @@ void SpeculationHostImpl::ProcessCandidatesForPrerender( rfhi.GetPageUkmSourceId(), ui::PAGE_TRANSITION_LINK, /*url_match_predicate=*/absl::nullopt), *web_contents, /*preloading_attempt=*/preloading_attempt); - started_prerenders_.insert(end, {.url = it->url, - .referrer = referrer, - .prerender_host_id = prerender_host_id}); + started_prerenders_.insert(end, {/*.url =*/ it->url, + /*.referrer =*/ referrer, + /*.prerender_host_id =*/ prerender_host_id}); } } diff --git a/chromium/content/browser/private_aggregation/private_aggregation_host.cc b/chromium/content/browser/private_aggregation/private_aggregation_host.cc index 6f573e1d208..db49ffdd846 100644 --- a/chromium/content/browser/private_aggregation/private_aggregation_host.cc +++ b/chromium/content/browser/private_aggregation/private_aggregation_host.cc @@ -72,9 +72,9 @@ bool PrivateAggregationHost::BindNewReceiver( } receiver_set_.Add( this, std::move(pending_receiver), - ReceiverContext{.worklet_origin = std::move(worklet_origin), - .top_frame_origin = std::move(top_frame_origin), - .api_for_budgeting = api_for_budgeting}); + ReceiverContext{/*.worklet_origin =*/ std::move(worklet_origin), + /*.top_frame_origin =*/ std::move(top_frame_origin), + /*.api_for_budgeting =*/ api_for_budgeting}); return true; } diff --git a/chromium/content/browser/renderer_host/media/media_stream_dispatcher_host.cc b/chromium/content/browser/renderer_host/media/media_stream_dispatcher_host.cc index b8612f5ecb9..bcdf9915e28 100644 --- a/chromium/content/browser/renderer_host/media/media_stream_dispatcher_host.cc +++ b/chromium/content/browser/renderer_host/media/media_stream_dispatcher_host.cc @@ -355,13 +355,13 @@ MediaStreamDispatcherHost::GenerateStreamsChecksOnUIThread( // TODO(crbug.com/1342071): Add tests for |request_all_screens| being true. if (request_all_screens && !CheckRequestAllScreensAllowed(render_process_id, render_frame_id)) { - return {.request_allowed = false, - .salt_and_origin = MediaDeviceSaltAndOrigin()}; + return {/*.request_allowed =*/ false, + /*.salt_and_origin =*/ MediaDeviceSaltAndOrigin()}; } return { - .request_allowed = true, - .salt_and_origin = std::move(generate_salt_and_origin_callback).Run()}; + /*.request_allowed =*/ true, + /*.salt_and_origin =*/ std::move(generate_salt_and_origin_callback).Run()}; } const mojo::Remote<blink::mojom::MediaStreamDeviceObserver>& diff --git a/chromium/content/renderer/v8_value_converter_impl.cc b/chromium/content/renderer/v8_value_converter_impl.cc index c7352cab0c3..af521545069 100644 --- a/chromium/content/renderer/v8_value_converter_impl.cc +++ b/chromium/content/renderer/v8_value_converter_impl.cc @@ -280,9 +280,9 @@ v8::Local<v8::Value> V8ValueConverterImpl::ToV8ValueImpl( } }; - return value.Visit(Visitor{.converter = this, - .isolate = isolate, - .creation_context = creation_context}); + return value.Visit(Visitor{/*.converter =*/ this, + /*.isolate =*/ isolate, + /*.creation_context =*/ creation_context}); } v8::Local<v8::Value> V8ValueConverterImpl::ToV8Array( diff --git a/chromium/media/formats/hls/media_playlist.cc b/chromium/media/formats/hls/media_playlist.cc index fc70d892466..3c6d36fddf6 100644 --- a/chromium/media/formats/hls/media_playlist.cc +++ b/chromium/media/formats/hls/media_playlist.cc @@ -424,7 +424,7 @@ ParseStatus::Or<MediaPlaylist> MediaPlaylist::Parse( absl::optional<PartialSegmentInfo> partial_segment_info; if (part_inf_tag.has_value()) { partial_segment_info = MediaPlaylist::PartialSegmentInfo{ - .target_duration = part_inf_tag->target_duration}; + /*.target_duration =*/ part_inf_tag->target_duration}; // Since the combination of partial segments should be equivalent to their // parent segment, the partial segment target duration should not exceed the @@ -519,22 +519,22 @@ ParseStatus::Or<MediaPlaylist> MediaPlaylist::Parse( } return MediaPlaylist( - CtorArgs{.uri = std::move(uri), - .version = version, - .independent_segments = independent_segments, - .target_duration = target_duration, - .partial_segment_info = std::move(partial_segment_info), - .segments = std::move(segments), - .total_duration = total_duration, - .playlist_type = playlist_type, - .end_list = end_list_tag.has_value(), - .i_frames_only = i_frames_only_tag.has_value(), - .has_media_sequence_tag = media_sequence_tag.has_value(), - .can_skip_dateranges = can_skip_dateranges, - .can_block_reload = can_block_reload, - .skip_boundary = skip_boundary, - .hold_back_distance = hold_back_distance, - .part_hold_back_distance = part_hold_back_distance}); + CtorArgs{/*.uri =*/ std::move(uri), + /*.version =*/ version, + /*.independent_segments =*/ independent_segments, + /*.target_duration =*/ target_duration, + /*.partial_segment_info =*/ std::move(partial_segment_info), + /*.segments =*/ std::move(segments), + /*.total_duration =*/ total_duration, + /*.playlist_type =*/ playlist_type, + /*.end_list =*/ end_list_tag.has_value(), + /*.i_frames_only =*/ i_frames_only_tag.has_value(), + /*.has_media_sequence_tag =*/ media_sequence_tag.has_value(), + /*.can_skip_dateranges =*/ can_skip_dateranges, + /*.can_block_reload =*/ can_block_reload, + /*.skip_boundary =*/ skip_boundary, + /*.hold_back_distance =*/ hold_back_distance, + /*.part_hold_back_distance =*/ part_hold_back_distance}); } MediaPlaylist::MediaPlaylist(CtorArgs args) diff --git a/chromium/media/formats/hls/playlist.cc b/chromium/media/formats/hls/playlist.cc index eb652e6b835..f3dd1b2f0c8 100644 --- a/chromium/media/formats/hls/playlist.cc +++ b/chromium/media/formats/hls/playlist.cc @@ -93,12 +93,12 @@ ParseStatus::Or<Playlist::Identification> Playlist::IdentifyPlaylist( return Identification{ // If the playlist did not contain a version tag, version is implicitly // `kDefaultVersion`. - .version = version_tag ? version_tag->version : kDefaultVersion, + /*.version =*/ version_tag ? version_tag->version : kDefaultVersion, // Media playlists must contain the EXT-X-TARGETDURATION tag, so if we // never encountered a media playlist tag it must be an (empty) // multivariant playlist. - .kind = +// .kind = playlist_kind ? playlist_kind.value() : Kind::kMultivariantPlaylist, }; } diff --git a/chromium/media/formats/hls/source_string.cc b/chromium/media/formats/hls/source_string.cc index ad9db86f436..b2ee34006d2 100644 --- a/chromium/media/formats/hls/source_string.cc +++ b/chromium/media/formats/hls/source_string.cc @@ -53,7 +53,7 @@ ResolvedSourceString ResolvedSourceString::CreateForTesting( base::StringPiece str) { return ResolvedSourceString::CreateForTesting( line, column, str, - ResolvedSourceStringState{.contains_substitutions = false}); + ResolvedSourceStringState{/*.contains_substitutions =*/ false}); } // static @@ -99,7 +99,7 @@ template <> ResolvedSourceString SourceString::SkipVariableSubstitution() const { return ResolvedSourceString( Line(), Column(), Str(), - ResolvedSourceStringState{.contains_substitutions = false}); + ResolvedSourceStringState{/*.contains_substitutions =*/ false}); } template <typename ResolutionState> diff --git a/chromium/media/formats/hls/tags.cc b/chromium/media/formats/hls/tags.cc index 186a881e3a5..0e2e7b8b0f3 100644 --- a/chromium/media/formats/hls/tags.cc +++ b/chromium/media/formats/hls/tags.cc @@ -695,19 +695,19 @@ ParseStatus::Or<XMediaTag> XMediaTag::Parse( } return XMediaTag(XMediaTag::CtorArgs{ - .type = type, - .uri = uri, - .instream_id = instream_id, - .group_id = group_id.value(), - .language = language, - .associated_language = assoc_language, - .name = name.value(), - .stable_rendition_id = std::move(stable_rendition_id), - .is_default = is_default, - .autoselect = autoselect, - .forced = forced, - .characteristics = std::move(characteristics), - .channels = std::move(channels), + /*.type =*/ type, + /*.uri =*/ uri, + /*.instream_id =*/ instream_id, + /*.group_id =*/ group_id.value(), + /*.language =*/ language, + /*.associated_language =*/ assoc_language, + /*.name =*/ name.value(), + /*.stable_rendition_id =*/ std::move(stable_rendition_id), + /*.is_default = */is_default, + /*.autoselect =*/ autoselect, + /*.forced =*/ forced, + /*.characteristics =*/ std::move(characteristics), + /*.channels =*/ std::move(channels), }); } @@ -859,7 +859,7 @@ ParseStatus::Or<InfTag> InfTag::Parse(TagItem tag) { return ParseStatusCode::kValueOverflowsTimeDelta; } - return InfTag{.duration = duration, .title = title_str}; + return InfTag{/*.duration =*/ duration, /*.title =*/ title_str}; } // static @@ -881,7 +881,7 @@ ParseStatus::Or<XByteRangeTag> XByteRangeTag::Parse(TagItem tag) { .AddCause(std::move(range).error()); } - return XByteRangeTag{.range = std::move(range).value()}; + return XByteRangeTag{/*.range =*/ std::move(range).value()}; } // static @@ -958,7 +958,7 @@ ParseStatus::Or<XMapTag> XMapTag::Parse( byte_range = std::move(result).value(); } - return XMapTag{.uri = uri.value(), .byte_range = byte_range}; + return XMapTag{/*.uri =*/ uri.value(), /*.byte_range =*/ byte_range}; } // static @@ -1049,11 +1049,11 @@ ParseStatus::Or<XPartTag> XPartTag::Parse( } } - return XPartTag{.uri = uri.value(), - .duration = duration, - .byte_range = byte_range, - .independent = independent, - .gap = gap}; + return XPartTag{/*.uri =*/ uri.value(), + /*.duration =*/ duration, + /*.byte_range =*/ byte_range, + /*.independent =*/ independent, + /*.gap =*/ gap}; } // static @@ -1094,7 +1094,7 @@ ParseStatus::Or<XPartInfTag> XPartInfTag::Parse(TagItem tag) { return ParseStatusCode::kMalformedTag; } - return XPartInfTag{.target_duration = part_target}; + return XPartInfTag{/*.target_duration =*/ part_target}; } // static @@ -1107,10 +1107,10 @@ ParseStatus::Or<XPlaylistTypeTag> XPlaylistTypeTag::Parse(TagItem tag) { } if (tag.GetContent()->Str() == "EVENT") { - return XPlaylistTypeTag{.type = PlaylistType::kEvent}; + return XPlaylistTypeTag{/*.type =*/ PlaylistType::kEvent}; } if (tag.GetContent()->Str() == "VOD") { - return XPlaylistTypeTag{.type = PlaylistType::kVOD}; + return XPlaylistTypeTag{/*.type =*/ PlaylistType::kVOD}; } return ParseStatusCode::kUnknownPlaylistType; @@ -1215,11 +1215,11 @@ ParseStatus::Or<XServerControlTag> XServerControlTag::Parse(TagItem tag) { } return XServerControlTag{ - .skip_boundary = can_skip_until, - .can_skip_dateranges = can_skip_dateranges, - .hold_back = hold_back, - .part_hold_back = part_hold_back, - .can_block_reload = can_block_reload, + /*.skip_boundary =*/ can_skip_until, + /*.can_skip_dateranges =*/ can_skip_dateranges, + /*.hold_back =*/ hold_back, + /*.part_hold_back =*/ part_hold_back, + /*.can_block_reload =*/ can_block_reload, }; } @@ -1242,7 +1242,7 @@ ParseStatus::Or<XTargetDurationTag> XTargetDurationTag::Parse(TagItem tag) { return ParseStatusCode::kValueOverflowsTimeDelta; } - return XTargetDurationTag{.duration = duration}; + return XTargetDurationTag{/*.duration =*/ duration}; } } // namespace media::hls diff --git a/chromium/media/formats/hls/types.cc b/chromium/media/formats/hls/types.cc index bbcad207f55..ca4590b6efb 100644 --- a/chromium/media/formats/hls/types.cc +++ b/chromium/media/formats/hls/types.cc @@ -190,8 +190,8 @@ ParseStatus::Or<DecimalResolution> DecimalResolution::Parse( } } - return DecimalResolution{.width = std::move(width).value(), - .height = std::move(height).value()}; + return DecimalResolution{/*.width =*/ std::move(width).value(), + /*.height =*/ std::move(height).value()}; } // static @@ -220,8 +220,8 @@ ParseStatus::Or<ByteRangeExpression> ByteRangeExpression::Parse( offset = std::move(offset_result).value(); } - return ByteRangeExpression{.length = std::move(length).value(), - .offset = offset}; + return ByteRangeExpression{/*.length =*/ std::move(length).value(), + /*.offset =*/ offset}; } // static diff --git a/chromium/media/formats/hls/variable_dictionary.cc b/chromium/media/formats/hls/variable_dictionary.cc index a24000de886..1c36f99b7b3 100644 --- a/chromium/media/formats/hls/variable_dictionary.cc +++ b/chromium/media/formats/hls/variable_dictionary.cc @@ -99,7 +99,7 @@ ParseStatus::Or<ResolvedSourceString> VariableDictionary::Resolve( if (!next_var.tail) { return ResolvedSourceString::Create( {}, input.Line(), input.Column(), input.Str(), - ResolvedSourceStringState{.contains_substitutions = false}); + ResolvedSourceStringState{/*.contains_substitutions =*/ false}); } // If there was a variable reference, but it consisted of the entire input @@ -113,7 +113,7 @@ ParseStatus::Or<ResolvedSourceString> VariableDictionary::Resolve( return ResolvedSourceString::Create( {}, input.Line(), input.Column(), *value, - ResolvedSourceStringState{.contains_substitutions = true}); + ResolvedSourceStringState{/*.contains_substitutions =*/ true}); } auto& string_buf = buffer.strings_.emplace_back(); @@ -139,7 +139,7 @@ ParseStatus::Or<ResolvedSourceString> VariableDictionary::Resolve( return ResolvedSourceString::Create( {}, input.Line(), input.Column(), string_buf, - ResolvedSourceStringState{.contains_substitutions = true}); + ResolvedSourceStringState{/*.contains_substitutions =*/ true}); } } // namespace media::hls diff --git a/chromium/mojo/core/ipcz_api.cc b/chromium/mojo/core/ipcz_api.cc index e52fe0aee58..433dff455b4 100644 --- a/chromium/mojo/core/ipcz_api.cc +++ b/chromium/mojo/core/ipcz_api.cc @@ -22,8 +22,8 @@ class IpczAPIInitializer { }; IpczHandle g_node = IPCZ_INVALID_HANDLE; -IpczNodeOptions g_options = {.is_broker = false, - .use_local_shared_memory_allocation = false}; +IpczNodeOptions g_options = {/*.is_broker =*/ false, + /*.use_local_shared_memory_allocation =*/ false}; } // namespace diff --git a/chromium/mojo/core/ipcz_driver/mojo_trap.cc b/chromium/mojo/core/ipcz_driver/mojo_trap.cc index f8e1e394f5d..a094af63917 100644 --- a/chromium/mojo/core/ipcz_driver/mojo_trap.cc +++ b/chromium/mojo/core/ipcz_driver/mojo_trap.cc @@ -119,7 +119,7 @@ struct MojoTrap::Trigger : public base::RefCountedThreadSafe<Trigger> { const MojoHandle handle; const MojoHandleSignals signals; const uintptr_t trigger_context; - IpczTrapConditions conditions = {.size = sizeof(conditions), .flags = 0}; + IpczTrapConditions conditions = {/*.size =*/ sizeof(conditions), /*.flags =*/ 0}; // Access is effectively guarded by the owning MojoTrap's `lock_`. bool armed = false; @@ -174,8 +174,8 @@ MojoResult MojoTrap::AddTrigger(MojoHandle handle, // added here. trigger->AddRef(); IpczTrapConditions removal_conditions = { - .size = sizeof(removal_conditions), - .flags = IPCZ_TRAP_REMOVED, + /*.size =*/ sizeof(removal_conditions), + /*.flags =*/ IPCZ_TRAP_REMOVED, }; IpczResult result = GetIpczAPI().Trap( handle, &removal_conditions, &TrapRemovalEventHandler, @@ -197,7 +197,7 @@ MojoResult MojoTrap::AddTrigger(MojoHandle handle, armed_ = false; } - MojoTrapEvent event = {.struct_size = sizeof(event)}; + MojoTrapEvent event = {/*.struct_size =*/ sizeof(event)}; TranslateIpczToMojoEvent(signals, trigger_context, flags, status, &event); event.flags = MOJO_TRAP_EVENT_FLAG_WITHIN_API_CALL; handler_(&event); @@ -358,7 +358,7 @@ void MojoTrap::HandleEvent(const IpczTrapEvent& event) { armed_ = false; } - MojoTrapEvent mojo_event = {.struct_size = sizeof(mojo_event)}; + MojoTrapEvent mojo_event = {/*.struct_size =*/ sizeof(mojo_event)}; TranslateIpczToMojoEvent(trigger.signals, trigger.trigger_context, event.condition_flags, *event.status, &mojo_event); mojo_event.flags |= MOJO_TRAP_EVENT_FLAG_WITHIN_API_CALL; @@ -413,11 +413,11 @@ IpczResult MojoTrap::ArmTrigger(Trigger& trigger, void MojoTrap::NotifyTriggerRemoved(Trigger& trigger) { MojoTrapEvent mojo_event = { - .struct_size = sizeof(mojo_event), - .flags = MOJO_TRAP_EVENT_FLAG_WITHIN_API_CALL, - .trigger_context = trigger.trigger_context, - .result = MOJO_RESULT_CANCELLED, - .signals_state = {.satisfied_signals = 0, .satisfiable_signals = 0}, + /*.struct_size =*/ sizeof(mojo_event), + /*.flags =*/ MOJO_TRAP_EVENT_FLAG_WITHIN_API_CALL, + /*.trigger_context =*/ trigger.trigger_context, + /*.result =*/ MOJO_RESULT_CANCELLED, + /*.signals_state =*/ {/*.satisfied_signals =*/ 0, /*.satisfiable_signals =*/ 0}, }; handler_(&mojo_event); } diff --git a/chromium/mojo/public/cpp/platform/named_platform_channel.cc b/chromium/mojo/public/cpp/platform/named_platform_channel.cc index 7ce2d363c9b..c2595cb5ddf 100644 --- a/chromium/mojo/public/cpp/platform/named_platform_channel.cc +++ b/chromium/mojo/public/cpp/platform/named_platform_channel.cc @@ -46,7 +46,7 @@ void NamedPlatformChannel::PassServerNameOnCommandLine( PlatformChannelEndpoint NamedPlatformChannel::ConnectToServer( const ServerName& server_name) { DCHECK(!server_name.empty()); - Options options = {.server_name = server_name}; + Options options = {/*.server_name =*/ server_name}; return CreateClientEndpoint(options); } diff --git a/chromium/pdf/pdf_view_web_plugin.cc b/chromium/pdf/pdf_view_web_plugin.cc index b2d16648a86..7d047bfec6b 100644 --- a/chromium/pdf/pdf_view_web_plugin.cc +++ b/chromium/pdf/pdf_view_web_plugin.cc @@ -1911,7 +1911,7 @@ void PdfViewWebPlugin::HandleLoadPreviewPageMessage( int src_page_index = ExtractPrintPreviewPageIndex(url); DCHECK_GE(src_page_index, 0); - preview_pages_info_.push({.url = url, .dest_page_index = dest_page_index}); + preview_pages_info_.push({/*.url =*/ url, /*.dest_page_index =*/ dest_page_index}); LoadAvailablePreviewPage(); } diff --git a/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_deserializer_for_modules.cc b/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_deserializer_for_modules.cc index 18a201fd13c..cff45c6e458 100644 --- a/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_deserializer_for_modules.cc +++ b/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_deserializer_for_modules.cc @@ -558,15 +558,15 @@ MediaStreamTrack* V8ScriptValueDeserializerForModules::ReadMediaStreamTrack() { return MediaStreamTrack::FromTransferredState( GetScriptState(), MediaStreamTrack::TransferredValues{ - .session_id = session_id, - .transfer_id = transfer_id, - .kind = kind, - .id = id, - .label = label, - .enabled = static_cast<bool>(enabled), - .muted = static_cast<bool>(muted), - .content_hint = DeserializeContentHint(contentHint), - .ready_state = DeserializeReadyState(readyState)}); + /*.session_id =*/ session_id, + /*.transfer_id =*/ transfer_id, + /*.kind =*/ kind, + /*.id =*/ id, + /*.label =*/ label, + /*.enabled =*/ static_cast<bool>(enabled), + /*.muted =*/ static_cast<bool>(muted), + /*.content_hint =*/ DeserializeContentHint(contentHint), + /*.ready_state =*/ DeserializeReadyState(readyState)}); } CropTarget* V8ScriptValueDeserializerForModules::ReadCropTarget() { diff --git a/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc b/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc index ae533715829..4a0c6eb6782 100644 --- a/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc +++ b/chromium/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc @@ -684,8 +684,8 @@ bool V8ScriptValueSerializerForModules::WriteMediaSourceHandle( DCHECK(media_source_attachment_provider); attachments.push_back(MediaSourceHandleAttachment::HandleInternals{ - .attachment_provider = std::move(media_source_attachment_provider), - .internal_blob_url = handle->GetInternalBlobURL()}); + /*.attachment_provider =*/ std::move(media_source_attachment_provider), + /*.internal_blob_url =*/ handle->GetInternalBlobURL()}); handle->mark_serialized(); const uint32_t index = static_cast<uint32_t>(attachments.size() - 1); diff --git a/chromium/third_party/blink/renderer/core/animation/animatable.cc b/chromium/third_party/blink/renderer/core/animation/animatable.cc index 7a92c7888fc..89174d58598 100644 --- a/chromium/third_party/blink/renderer/core/animation/animatable.cc +++ b/chromium/third_party/blink/renderer/core/animation/animatable.cc @@ -139,7 +139,7 @@ HeapVector<Member<Animation>> Animatable::getAnimations( GetAnimationsOptions* options) { bool use_subtree = options && options->subtree(); return GetAnimationsInternal( - GetAnimationsOptionsResolved{.use_subtree = use_subtree}); + GetAnimationsOptionsResolved{/*.use_subtree =*/ use_subtree}); } HeapVector<Member<Animation>> Animatable::GetAnimationsInternal( diff --git a/chromium/third_party/blink/renderer/core/dom/element.cc b/chromium/third_party/blink/renderer/core/dom/element.cc index ba0889735c8..89df7dee38f 100644 --- a/chromium/third_party/blink/renderer/core/dom/element.cc +++ b/chromium/third_party/blink/renderer/core/dom/element.cc @@ -2742,7 +2742,7 @@ void Element::HidePopUpInternal(HidePopupFocusBehavior focus_behavior, HeapVector<Member<Animation>> previous_animations; if (!force_hide) { previous_animations = GetAnimationsInternal( - GetAnimationsOptionsResolved{.use_subtree = true}); + GetAnimationsOptionsResolved{/*.use_subtree =*/ true}); } GetPopupData()->setInvoker(nullptr); @@ -2778,7 +2778,7 @@ void Element::HidePopUpInternal(HidePopupFocusBehavior focus_behavior, // can start. HeapHashSet<Member<EventTarget>> animations; for (const auto& animation : GetAnimationsInternal( - GetAnimationsOptionsResolved{.use_subtree = true})) { + GetAnimationsOptionsResolved{/*.use_subtree =*/ true})) { animations.insert(animation); } animations.RemoveAll(previous_animations); diff --git a/chromium/third_party/blink/renderer/core/frame/attribution_src_loader.cc b/chromium/third_party/blink/renderer/core/frame/attribution_src_loader.cc index 36cc4e14610..1ff87747d23 100644 --- a/chromium/third_party/blink/renderer/core/frame/attribution_src_loader.cc +++ b/chromium/third_party/blink/renderer/core/frame/attribution_src_loader.cc @@ -257,7 +257,7 @@ absl::optional<Impression> AttributionSrcLoader::RegisterNavigation( return absl::nullopt; DCHECK(client->attribution_src_token()); - return blink::Impression{.attribution_src_token = + return blink::Impression{/*.attribution_src_token =*/ *client->attribution_src_token()}; } diff --git a/chromium/third_party/blink/renderer/core/html/forms/html_form_control_element.cc b/chromium/third_party/blink/renderer/core/html/forms/html_form_control_element.cc index bf6416ebf55..8aa42c94f73 100644 --- a/chromium/third_party/blink/renderer/core/html/forms/html_form_control_element.cc +++ b/chromium/third_party/blink/renderer/core/html/forms/html_form_control_element.cc @@ -332,9 +332,9 @@ bool HTMLFormControlElement::IsSuccessfulSubmitButton() const { // values match, the behavior is to toggle. HTMLFormControlElement::PopupTargetElement HTMLFormControlElement::popupTargetElement() const { - const PopupTargetElement no_element{.element = nullptr, - .action = PopupTriggerAction::kNone, - .attribute_name = g_null_name}; + const PopupTargetElement no_element{/*.element =*/ nullptr, + /*.action =*/ PopupTriggerAction::kNone, + /*.attribute_name =*/ g_null_name}; if (!RuntimeEnabledFeatures::HTMLPopupAttributeEnabled( GetDocument().GetExecutionContext()) || !IsInTreeScope() || @@ -367,9 +367,9 @@ HTMLFormControlElement::popupTargetElement() const { Element* popup_element = GetTreeScope().getElementById(idref); if (!popup_element || !popup_element->HasValidPopupAttribute()) return no_element; - return PopupTargetElement{.element = popup_element, - .action = action, - .attribute_name = attribute_name}; + return PopupTargetElement{/*.element =*/ popup_element, + /*.action =*/ action, + /*.attribute_name =*/ attribute_name}; } void HTMLFormControlElement::DefaultEventHandler(Event& event) { diff --git a/chromium/third_party/blink/renderer/core/html/parser/background_html_scanner.cc b/chromium/third_party/blink/renderer/core/html/parser/background_html_scanner.cc index e03a3582a67..3aed71ae044 100644 --- a/chromium/third_party/blink/renderer/core/html/parser/background_html_scanner.cc +++ b/chromium/third_party/blink/renderer/core/html/parser/background_html_scanner.cc @@ -167,12 +167,12 @@ BackgroundHTMLScanner::ScriptTokenScanner::Create( return std::make_unique<ScriptTokenScanner>( parser, - OptimizationParams{.task_runner = GetCompileTaskRunner(), - .min_size = GetMinimumScriptSize(), - .enabled = precompile_scripts}, - OptimizationParams{.task_runner = GetTokenizeTaskRunner(), - .min_size = GetMinimumCSSSize(), - .enabled = pretokenize_css}); + OptimizationParams{/*.task_runner =*/ GetCompileTaskRunner(), + /*.min_size =*/ GetMinimumScriptSize(), + /*.enabled =*/ precompile_scripts}, + OptimizationParams{/*.task_runner =*/ GetTokenizeTaskRunner(), + /*.min_size =*/ GetMinimumCSSSize(), + /*.enabled =*/ pretokenize_css}); } BackgroundHTMLScanner::ScriptTokenScanner::ScriptTokenScanner( diff --git a/chromium/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc b/chromium/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc index 51d44a02f07..c56e3b15068 100644 --- a/chromium/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc +++ b/chromium/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc @@ -977,9 +977,9 @@ void TokenPreloadScanner::ScanCommon( token.GetAttributeItem(html_names::kContentAttr); if (content_attribute) { meta_ch_values.push_back( - MetaCHValue{.value = content_attribute->GetValue(), - .type = network::MetaCHType::HttpEquivAcceptCH, - .is_doc_preloader = + MetaCHValue{/*.value =*/ content_attribute->GetValue(), + /*.type =*/ network::MetaCHType::HttpEquivAcceptCH, +// .is_doc_preloader = scanner_type_ == ScannerType::kMainDocument}); } } else if (EqualIgnoringASCIICase(equiv_attribute_value, @@ -990,9 +990,9 @@ void TokenPreloadScanner::ScanCommon( token.GetAttributeItem(html_names::kContentAttr); if (content_attribute) { meta_ch_values.push_back( - MetaCHValue{.value = content_attribute->GetValue(), - .type = network::MetaCHType::HttpEquivDelegateCH, - .is_doc_preloader = + MetaCHValue{/*.value =*/ content_attribute->GetValue(), + /*.type =*/ network::MetaCHType::HttpEquivDelegateCH, +// .is_doc_preloader = scanner_type_ == ScannerType::kMainDocument}); } } diff --git a/chromium/third_party/blink/renderer/modules/mediastream/transferred_media_stream_track.cc b/chromium/third_party/blink/renderer/modules/mediastream/transferred_media_stream_track.cc index 44e842e97d7..255656f6e71 100644 --- a/chromium/third_party/blink/renderer/modules/mediastream/transferred_media_stream_track.cc +++ b/chromium/third_party/blink/renderer/modules/mediastream/transferred_media_stream_track.cc @@ -54,7 +54,7 @@ TransferredMediaStreamTrack::TransferredMediaStreamTrack( const TransferredValues& data) : transferred_component_( MakeGarbageCollected<TransferredMediaStreamComponent>( - TransferredMediaStreamComponent::TransferredValues{.id = + TransferredMediaStreamComponent::TransferredValues{/*.id =*/ data.id})), execution_context_(execution_context), data_(data) {} diff --git a/chromium/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc b/chromium/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc index a1c86e14be9..1d6bc3836fd 100644 --- a/chromium/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc +++ b/chromium/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc @@ -358,7 +358,7 @@ scoped_refptr<const CalculationExpressionAnchorQueryNode> CalculationExpressionAnchorQueryNode::CreateAnchor(const AtomicString& name, AnchorValue side, const Length& fallback) { - AnchorQueryValue value = {.anchor_side = side}; + AnchorQueryValue value = {/*.anchor_side =*/ side}; return base::MakeRefCounted<CalculationExpressionAnchorQueryNode>( AnchorQueryType::kAnchor, name, value, /* percentage */ 0, fallback); } @@ -369,7 +369,7 @@ CalculationExpressionAnchorQueryNode::CreateAnchorPercentage( const AtomicString& name, float percentage, const Length& fallback) { - AnchorQueryValue value = {.anchor_side = AnchorValue::kPercentage}; + AnchorQueryValue value = {/*.anchor_side =*/ AnchorValue::kPercentage}; return base::MakeRefCounted<CalculationExpressionAnchorQueryNode>( AnchorQueryType::kAnchor, name, value, percentage, fallback); } @@ -379,7 +379,8 @@ scoped_refptr<const CalculationExpressionAnchorQueryNode> CalculationExpressionAnchorQueryNode::CreateAnchorSize(const AtomicString& name, AnchorSizeValue size, const Length& fallback) { - AnchorQueryValue value = {.anchor_size = size}; + AnchorQueryValue value = {}; + value.anchor_size = size; return base::MakeRefCounted<CalculationExpressionAnchorQueryNode>( AnchorQueryType::kAnchorSize, name, value, /* percentage */ 0, fallback); } diff --git a/chromium/third_party/ipcz/src/ipcz/block_allocator.cc b/chromium/third_party/ipcz/src/ipcz/block_allocator.cc index 8b0cdb518d4..42a31e33fff 100644 --- a/chromium/third_party/ipcz/src/ipcz/block_allocator.cc +++ b/chromium/third_party/ipcz/src/ipcz/block_allocator.cc @@ -198,7 +198,7 @@ bool BlockAllocator::TryUpdateFrontHeader(BlockHeader& last_known_header, // called within a tight retry loop. return block_header_at(kFrontBlockIndex) .compare_exchange_weak( - last_known_header, {.version = new_version, .next = relative_next}, + last_known_header, {/*.version =*/ new_version, /*.next =*/ relative_next}, std::memory_order_release, std::memory_order_relaxed); } @@ -210,7 +210,7 @@ BlockAllocator::FreeBlock::FreeBlock(int16_t index, AtomicBlockHeader& header) void BlockAllocator::FreeBlock::SetNextFreeBlock(int16_t next_free_block) { const int16_t relative_next = ForBaseIndex(index_).GetRelativeFromAbsoluteIndex(next_free_block); - header_.store({.version = 0, .next = relative_next}, + header_.store({/*.version =*/ 0, /*.next =*/ relative_next}, std::memory_order_release); } diff --git a/chromium/third_party/ipcz/src/ipcz/driver_memory.cc b/chromium/third_party/ipcz/src/ipcz/driver_memory.cc index bc28fcdc6c6..fe4e18155a2 100644 --- a/chromium/third_party/ipcz/src/ipcz/driver_memory.cc +++ b/chromium/third_party/ipcz/src/ipcz/driver_memory.cc @@ -18,7 +18,7 @@ DriverMemory::DriverMemory() = default; DriverMemory::DriverMemory(DriverObject memory) : memory_(std::move(memory)) { if (memory_.is_valid()) { - IpczSharedMemoryInfo info = {.size = sizeof(info)}; + IpczSharedMemoryInfo info = {/*.size =*/ sizeof(info)}; IpczResult result = memory_.driver()->GetSharedMemoryInfo( memory_.handle(), IPCZ_NO_FLAGS, nullptr, &info); ABSL_ASSERT(result == IPCZ_RESULT_OK); diff --git a/chromium/third_party/ipcz/src/ipcz/message.cc b/chromium/third_party/ipcz/src/ipcz/message.cc index 1b686ed649f..c0462a599e6 100644 --- a/chromium/third_party/ipcz/src/ipcz/message.cc +++ b/chromium/third_party/ipcz/src/ipcz/message.cc @@ -172,8 +172,8 @@ uint32_t Message::AppendDriverObject(DriverObject object) { internal::DriverObjectArrayData Message::AppendDriverObjects( absl::Span<DriverObject> objects) { const internal::DriverObjectArrayData data = { - .first_object_index = checked_cast<uint32_t>(driver_objects_.size()), - .num_objects = checked_cast<uint32_t>(objects.size()), + /*.first_object_index =*/ checked_cast<uint32_t>(driver_objects_.size()), + /*.num_objects =*/ checked_cast<uint32_t>(objects.size()), }; driver_objects_.reserve(driver_objects_.size() + objects.size()); for (auto& object : objects) { diff --git a/chromium/third_party/ipcz/src/ipcz/remote_router_link.cc b/chromium/third_party/ipcz/src/ipcz/remote_router_link.cc index ac468619666..da56ccb592b 100644 --- a/chromium/third_party/ipcz/src/ipcz/remote_router_link.cc +++ b/chromium/third_party/ipcz/src/ipcz/remote_router_link.cc @@ -287,7 +287,7 @@ RouterLinkState::QueueState RemoteRouterLink::GetPeerQueueState() { if (auto* state = GetLinkState()) { return state->GetQueueState(side_.opposite()); } - return {.num_parcels = 0, .num_bytes = 0}; + return {/*.num_parcels =*/ 0, /*.num_bytes =*/ 0}; } bool RemoteRouterLink::UpdateInboundQueueState(size_t num_parcels, diff --git a/chromium/third_party/ipcz/src/ipcz/router.cc b/chromium/third_party/ipcz/src/ipcz/router.cc index eae86db2c20..6b0b6b77c00 100644 --- a/chromium/third_party/ipcz/src/ipcz/router.cc +++ b/chromium/third_party/ipcz/src/ipcz/router.cc @@ -58,7 +58,7 @@ void CollectParcelsToFlush(ParcelQueue& queue, return; } - ParcelToFlush& parcel = parcels.emplace_back(ParcelToFlush{.link = link}); + ParcelToFlush& parcel = parcels.emplace_back(ParcelToFlush{/*.link =*/ link}); const bool popped = queue.Pop(parcel.parcel); ABSL_ASSERT(popped); } diff --git a/chromium/third_party/ipcz/src/ipcz/router_link_state.cc b/chromium/third_party/ipcz/src/ipcz/router_link_state.cc index 70e842dc0c8..1c580c5d9b7 100644 --- a/chromium/third_party/ipcz/src/ipcz/router_link_state.cc +++ b/chromium/third_party/ipcz/src/ipcz/router_link_state.cc @@ -128,9 +128,9 @@ bool RouterLinkState::ResetWaitingBit(LinkSide side) { RouterLinkState::QueueState RouterLinkState::GetQueueState( LinkSide side) const { return { - .num_parcels = SelectBySide(side, num_parcels_on_a, num_parcels_on_b) + /*.num_parcels =*/ SelectBySide(side, num_parcels_on_a, num_parcels_on_b) .load(std::memory_order_relaxed), - .num_bytes = SelectBySide(side, num_bytes_on_a, num_bytes_on_b) + /*.num_bytes =*/ SelectBySide(side, num_bytes_on_a, num_bytes_on_b) .load(std::memory_order_relaxed), }; } diff --git a/chromium/third_party/ipcz/src/ipcz/trap_event_dispatcher.cc b/chromium/third_party/ipcz/src/ipcz/trap_event_dispatcher.cc index d47aaa5caae..e5757d8f5a5 100644 --- a/chromium/third_party/ipcz/src/ipcz/trap_event_dispatcher.cc +++ b/chromium/third_party/ipcz/src/ipcz/trap_event_dispatcher.cc @@ -22,10 +22,10 @@ void TrapEventDispatcher::DeferEvent(IpczTrapEventHandler handler, void TrapEventDispatcher::DispatchAll() { for (const Event& event : events_) { const IpczTrapEvent trap_event = { - .size = sizeof(trap_event), - .context = event.context, - .condition_flags = event.flags, - .status = &event.status, + /*.size =*/ sizeof(trap_event), + /*.context =*/ event.context, + /*.condition_flags =*/ event.flags, + /*.status =*/ &event.status, }; event.handler(&trap_event); } diff --git a/chromium/third_party/ipcz/src/ipcz/trap_set.h b/chromium/third_party/ipcz/src/ipcz/trap_set.h index 671f0cd7ca9..c44ccc4ffed 100644 --- a/chromium/third_party/ipcz/src/ipcz/trap_set.h +++ b/chromium/third_party/ipcz/src/ipcz/trap_set.h @@ -93,7 +93,7 @@ class TrapSet { using TrapList = absl::InlinedVector<Trap, 4>; TrapList traps_; size_t num_traps_monitoring_remote_state_ = 0; - IpczPortalStatus last_known_status_ = {.size = sizeof(last_known_status_)}; + IpczPortalStatus last_known_status_ = {/*.size =*/ sizeof(last_known_status_)}; }; } // namespace ipcz diff --git a/chromium/third_party/webrtc/api/video/frame_buffer.cc b/chromium/third_party/webrtc/api/video/frame_buffer.cc index 4cdf2212a60..b97bc42c10f 100644 --- a/chromium/third_party/webrtc/api/video/frame_buffer.cc +++ b/chromium/third_party/webrtc/api/video/frame_buffer.cc @@ -262,9 +262,9 @@ void FrameBuffer::FindNextAndLastDecodableTemporalUnit() { if (next_decodable_temporal_unit_) { decodable_temporal_units_info_ = { - .next_rtp_timestamp = +// .next_rtp_timestamp = GetTimestamp(next_decodable_temporal_unit_->first_frame), - .last_rtp_timestamp = last_decodable_temporal_unit_timestamp}; + /*.last_rtp_timestamp =*/ last_decodable_temporal_unit_timestamp}; } } diff --git a/chromium/third_party/webrtc/api/video_codecs/video_encoder_factory_template.h b/chromium/third_party/webrtc/api/video_codecs/video_encoder_factory_template.h index 643096dbbba..a21f5bf41c9 100644 --- a/chromium/third_party/webrtc/api/video_codecs/video_encoder_factory_template.h +++ b/chromium/third_party/webrtc/api/video_codecs/video_encoder_factory_template.h @@ -119,14 +119,14 @@ class VideoEncoderFactoryTemplate : public VideoEncoderFactory { const SdpVideoFormat& format, const absl::optional<std::string>& scalability_mode) const { if (IsFormatInList(format, V::SupportedFormats())) { - return {.is_supported = IsScalabilityModeSupported<V>(scalability_mode)}; + return {/*.is_supported =*/ IsScalabilityModeSupported<V>(scalability_mode)}; } if constexpr (sizeof...(Vs) > 0) { return QueryCodecSupportInternal<Vs...>(format, scalability_mode); } - return {.is_supported = false}; + return {/*.is_supported =*/ false}; } }; diff --git a/chromium/third_party/webrtc/media/engine/internal_encoder_factory.cc b/chromium/third_party/webrtc/media/engine/internal_encoder_factory.cc index 4243f52481a..5c29d6c816a 100644 --- a/chromium/third_party/webrtc/media/engine/internal_encoder_factory.cc +++ b/chromium/third_party/webrtc/media/engine/internal_encoder_factory.cc @@ -84,7 +84,7 @@ VideoEncoderFactory::CodecSupport InternalEncoderFactory::QueryCodecSupport( auto original_format = MatchOriginalFormat(format); return original_format ? Factory().QueryCodecSupport(*original_format, scalability_mode) - : VideoEncoderFactory::CodecSupport{.is_supported = false}; + : VideoEncoderFactory::CodecSupport{/*.is_supported =*/ false}; } } // namespace webrtc diff --git a/chromium/third_party/webrtc/modules/pacing/pacing_controller.cc b/chromium/third_party/webrtc/modules/pacing/pacing_controller.cc index cdd908c9f89..c55639b13b4 100644 --- a/chromium/third_party/webrtc/modules/pacing/pacing_controller.cc +++ b/chromium/third_party/webrtc/modules/pacing/pacing_controller.cc @@ -112,11 +112,11 @@ PacingController::PacingController(Clock* clock, PacingController::~PacingController() = default; void PacingController::CreateProbeCluster(DataRate bitrate, int cluster_id) { - prober_.CreateProbeCluster({.at_time = CurrentTime(), - .target_data_rate = bitrate, - .target_duration = TimeDelta::Millis(15), - .target_probe_count = 5, - .id = cluster_id}); + prober_.CreateProbeCluster({/*.at_time =*/ CurrentTime(), + /*.target_data_rate =*/ bitrate, + /*.target_duration =*/ TimeDelta::Millis(15), + /*.target_probe_count =*/ 5, + /*.id =*/ cluster_id}); } void PacingController::CreateProbeClusters( diff --git a/chromium/third_party/webrtc/modules/pacing/prioritized_packet_queue.cc b/chromium/third_party/webrtc/modules/pacing/prioritized_packet_queue.cc index 83ec77da288..8951d8c7a58 100644 --- a/chromium/third_party/webrtc/modules/pacing/prioritized_packet_queue.cc +++ b/chromium/third_party/webrtc/modules/pacing/prioritized_packet_queue.cc @@ -118,9 +118,9 @@ void PrioritizedPacketQueue::Push(Timestamp enqueue_time, int prio_level = GetPriorityForType(packet_type); RTC_DCHECK_GE(prio_level, 0); RTC_DCHECK_LT(prio_level, kNumPriorityLevels); - QueuedPacket queued_packed = {.packet = std::move(packet), - .enqueue_time = enqueue_time, - .enqueue_time_iterator = enqueue_time_iterator}; + QueuedPacket queued_packed = {/*.packet =*/ std::move(packet), + /*.enqueue_time =*/ enqueue_time, + /*.enqueue_time_iterator =*/ enqueue_time_iterator}; // In order to figure out how much time a packet has spent in the queue // while not in a paused state, we subtract the total amount of time the // queue has been paused so far, and when the packet is popped we subtract diff --git a/chromium/third_party/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc b/chromium/third_party/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc index b83720d1a8f..1179f2e3b8b 100644 --- a/chromium/third_party/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc +++ b/chromium/third_party/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc @@ -86,9 +86,9 @@ void RemoteEstimatorProxy::IncomingPacket(int64_t arrival_time_ms, RTC_LOG(LS_WARNING) << "Arrival time out of bounds: " << arrival_time_ms; return; } - Packet packet = {.arrival_time = Timestamp::Millis(arrival_time_ms), - .size = DataSize::Bytes(header.headerLength + payload_size), - .ssrc = header.ssrc}; + Packet packet = {/*.arrival_time =*/ Timestamp::Millis(arrival_time_ms), + /*.size =*/ DataSize::Bytes(header.headerLength + payload_size), + /*.ssrc =*/ header.ssrc}; if (header.extension.hasTransportSequenceNumber) { packet.transport_sequence_number = header.extension.transportSequenceNumber; } diff --git a/chromium/third_party/webrtc/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc b/chromium/third_party/webrtc/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc index 86815bdb544..fd399042416 100644 --- a/chromium/third_party/webrtc/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc +++ b/chromium/third_party/webrtc/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc @@ -1562,9 +1562,9 @@ void LibvpxVp9Encoder::UpdateReferenceBuffers(const vpx_codec_cx_pkt& pkt, vpx_svc_layer_id_t layer_id = {0}; libvpx_->codec_control(encoder_, VP9E_GET_SVC_LAYER_ID, &layer_id); - RefFrameBuffer frame_buf = {.pic_num = pic_num, - .spatial_layer_id = layer_id.spatial_layer_id, - .temporal_layer_id = layer_id.temporal_layer_id}; + RefFrameBuffer frame_buf = {/*.pic_num =*/ pic_num, + /*.spatial_layer_id =*/ layer_id.spatial_layer_id, + /*.temporal_layer_id =*/ layer_id.temporal_layer_id}; if (is_svc_) { vpx_svc_ref_frame_config_t enc_layer_conf = {{0}}; diff --git a/chromium/third_party/webrtc/modules/video_coding/timing/timing.cc b/chromium/third_party/webrtc/modules/video_coding/timing/timing.cc index 2c83f1f6712..b2e392b5111 100644 --- a/chromium/third_party/webrtc/modules/video_coding/timing/timing.cc +++ b/chromium/third_party/webrtc/modules/video_coding/timing/timing.cc @@ -253,8 +253,8 @@ TimeDelta VCMTiming::TargetDelayInternal() const { VideoFrame::RenderParameters VCMTiming::RenderParameters() const { MutexLock lock(&mutex_); - return {.use_low_latency_rendering = UseLowLatencyRendering(), - .max_composition_delay_in_frames = max_composition_delay_in_frames_}; + return {/*.use_low_latency_rendering =*/ UseLowLatencyRendering(), + /*.max_composition_delay_in_frames =*/ max_composition_delay_in_frames_}; } bool VCMTiming::UseLowLatencyRendering() const { diff --git a/chromium/third_party/webrtc/net/dcsctp/tx/rr_send_queue.cc b/chromium/third_party/webrtc/net/dcsctp/tx/rr_send_queue.cc index b1812f0f8a3..c6c1aed5eba 100644 --- a/chromium/third_party/webrtc/net/dcsctp/tx/rr_send_queue.cc +++ b/chromium/third_party/webrtc/net/dcsctp/tx/rr_send_queue.cc @@ -358,15 +358,15 @@ void RRSendQueue::Add(TimeMs now, // message's lifetime, as the message is alive during its entire lifetime // (which may be zero). MessageAttributes attributes = { - .unordered = send_options.unordered, - .max_retransmissions = + /*.unordered =*/ send_options.unordered, +// .max_retransmissions = send_options.max_retransmissions.has_value() ? MaxRetransmits(send_options.max_retransmissions.value()) : MaxRetransmits::NoLimit(), - .expires_at = send_options.lifetime.has_value() + /*.expires_at =*/ send_options.lifetime.has_value() ? now + *send_options.lifetime + DurationMs(1) : TimeMs::InfiniteFuture(), - .lifecycle_id = send_options.lifecycle_id, + /*.lifecycle_id =*/ send_options.lifecycle_id, }; GetOrCreateStreamInfo(message.stream_id()) .Add(std::move(message), std::move(attributes)); diff --git a/chromium/third_party/webrtc/p2p/base/basic_ice_controller.cc b/chromium/third_party/webrtc/p2p/base/basic_ice_controller.cc index 55f187cb9af..8c541adab1c 100644 --- a/chromium/third_party/webrtc/p2p/base/basic_ice_controller.cc +++ b/chromium/third_party/webrtc/p2p/base/basic_ice_controller.cc @@ -464,8 +464,8 @@ BasicIceController::HandleInitialSelectDampening( } RTC_LOG(LS_INFO) << "delay initial selection up to " << min_delay << "ms"; - return {.connection = absl::nullopt, - .recheck_event = IceRecheckEvent( + return {/*.connection =*/ absl::nullopt, + /*.recheck_event =*/ IceRecheckEvent( IceSwitchReason::ICE_CONTROLLER_RECHECK, min_delay)}; } diff --git a/chromium/third_party/webrtc/p2p/base/p2p_transport_channel.cc b/chromium/third_party/webrtc/p2p/base/p2p_transport_channel.cc index 213cfbde77a..dbb1df76b7d 100644 --- a/chromium/third_party/webrtc/p2p/base/p2p_transport_channel.cc +++ b/chromium/third_party/webrtc/p2p/base/p2p_transport_channel.cc @@ -1834,16 +1834,16 @@ rtc::NetworkRoute P2PTransportChannel::ConfigureNetworkRoute( const Connection* conn) { RTC_DCHECK_RUN_ON(network_thread_); return { - .connected = ReadyToSend(conn), - .local = CreateRouteEndpointFromCandidate( + /*.connected =*/ ReadyToSend(conn), + /*.local =*/ CreateRouteEndpointFromCandidate( /* local= */ true, conn->local_candidate(), /* uses_turn= */ conn->port()->Type() == RELAY_PORT_TYPE), - .remote = CreateRouteEndpointFromCandidate( + /*.remote =*/ CreateRouteEndpointFromCandidate( /* local= */ false, conn->remote_candidate(), /* uses_turn= */ conn->remote_candidate().type() == RELAY_PORT_TYPE), - .last_sent_packet_id = last_sent_packet_id_, - .packet_overhead = + /*.last_sent_packet_id =*/ last_sent_packet_id_, +// .packet_overhead = conn->local_candidate().address().ipaddr().overhead() + GetProtocolOverhead(conn->local_candidate().protocol())}; } diff --git a/chromium/third_party/webrtc/video/video_receive_stream2.cc b/chromium/third_party/webrtc/video/video_receive_stream2.cc index 97a8a54a5d3..deeca376221 100644 --- a/chromium/third_party/webrtc/video/video_receive_stream2.cc +++ b/chromium/third_party/webrtc/video/video_receive_stream2.cc @@ -912,9 +912,9 @@ VideoReceiveStream2::HandleEncodedFrameOnDecodeQueue( } return DecodeFrameResult{ - .force_request_key_frame = force_request_key_frame, - .decoded_frame_picture_id = std::move(decoded_frame_picture_id), - .keyframe_required = keyframe_required, + /*.force_request_key_frame =*/ force_request_key_frame, + /*.decoded_frame_picture_id =*/ std::move(decoded_frame_picture_id), + /*.keyframe_required =*/ keyframe_required, }; } diff --git a/chromium/third_party/webrtc/video/video_stream_buffer_controller.cc b/chromium/third_party/webrtc/video/video_stream_buffer_controller.cc index 037754d404c..edf375eb11f 100644 --- a/chromium/third_party/webrtc/video/video_stream_buffer_controller.cc +++ b/chromium/third_party/webrtc/video/video_stream_buffer_controller.cc @@ -157,8 +157,8 @@ VideoStreamBufferController::VideoStreamBufferController( clock_, worker_queue, VideoReceiveStreamTimeoutTracker::Timeouts{ - .max_wait_for_keyframe = max_wait_for_keyframe, - .max_wait_for_frame = max_wait_for_frame}, + /*.max_wait_for_keyframe =*/ max_wait_for_keyframe, + /*.max_wait_for_frame =*/ max_wait_for_frame}, absl::bind_front(&VideoStreamBufferController::OnTimeout, this)), zero_playout_delay_max_decode_queue_size_( "max_decode_queue_size", @@ -223,8 +223,8 @@ void VideoStreamBufferController::UpdateRtt(int64_t max_rtt_ms) { void VideoStreamBufferController::SetMaxWaits(TimeDelta max_wait_for_keyframe, TimeDelta max_wait_for_frame) { RTC_DCHECK_RUN_ON(&worker_sequence_checker_); - timeout_tracker_.SetTimeouts({.max_wait_for_keyframe = max_wait_for_keyframe, - .max_wait_for_frame = max_wait_for_frame}); + timeout_tracker_.SetTimeouts({/*.max_wait_for_keyframe =*/ max_wait_for_keyframe, + /*.max_wait_for_frame =*/ max_wait_for_frame}); } void VideoStreamBufferController::StartNextDecode(bool keyframe_required) { |