diff options
author | Danil Somsikov <dsv@chromium.org> | 2023-01-20 17:12:52 +0100 |
---|---|---|
committer | Michael BrĂ¼ning <michael.bruning@qt.io> | 2023-03-24 10:08:56 +0000 |
commit | 09fea2f30573c1df22c1360e02392e157fb08fd4 (patch) | |
tree | 9b886f3828fee5c4b83632150427ce9961f5980d | |
parent | eaf39f93b6b9ab77c2ddf17e8278a0ee47ad7ad1 (diff) | |
download | qtwebengine-chromium-09fea2f30573c1df22c1360e02392e157fb08fd4.tar.gz |
[Backport] Security bug 1337747
Cherry-pick of patch originally reviewed on
https://chromium-review.googlesource.com/c/v8/v8/+/4184203:
Fix error dispatch in the v8 inspector session.
Bug: chromium:1337747
Change-Id: I920f3c6370ac9f9bc351eff34e46b1e8d520fe3e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4184203
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85449}
Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/468617
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r-- | chromium/v8/src/inspector/v8-inspector-session-impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chromium/v8/src/inspector/v8-inspector-session-impl.cc b/chromium/v8/src/inspector/v8-inspector-session-impl.cc index e6e50d597ba..fc42b70314a 100644 --- a/chromium/v8/src/inspector/v8-inspector-session-impl.cc +++ b/chromium/v8/src/inspector/v8-inspector-session-impl.cc @@ -383,7 +383,7 @@ void V8InspectorSessionImpl::dispatchProtocolMessage(StringView message) { } v8_crdtp::Dispatchable dispatchable(cbor); if (!dispatchable.ok()) { - if (dispatchable.HasCallId()) { + if (!dispatchable.HasCallId()) { m_channel->sendNotification(serializeForFrontend( v8_crdtp::CreateErrorNotification(dispatchable.DispatchError()))); } else { |