Fix warning about ambiguous else (inside the foreach macro)

 messagemodel.cpp:435:12: error: suggest explicit braces to avoid ambiguous ‘else’ [-Werror=dangling-else]

Might as well change to range-for.

Change-Id: Id061f35c088044b69a15fffd15818f8a10e64064
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/linguist/linguist/messagemodel.cpp b/src/linguist/linguist/messagemodel.cpp
index bb9bd947a..1033940e7 100644
--- a/src/linguist/linguist/messagemodel.cpp
+++ b/src/linguist/linguist/messagemodel.cpp
@@ -432,9 +432,11 @@ void DataModel::updateStatistics()
 
     for (DataModelIterator it(this); it.isValid(); ++it) {
         const MessageItem *mi = it.current();
-        if (mi->isFinished())
-            foreach (const QString &trnsl, mi->translations())
+        if (mi->isFinished()) {
+            const QStringList translations = mi->translations();
+            for (const QString &trnsl : translations)
                 doCharCounting(trnsl, trW, trC, trCS);
+        }
     }
 
     emit statsChanged(m_srcWords, m_srcChars, m_srcCharsSpc, trW, trC, trCS);