diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2017-10-18 11:47:27 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2017-10-25 09:26:56 +0000 |
| commit | d05880e92fbc54618265877c00618f1394d29d47 (patch) | |
| tree | 6df1e56f21297295f32c379a556e4fe9a6ac4d66 | |
| parent | f4a389c5141ae82bb1924215e6406fb8fc35fb7f (diff) | |
| download | qttools-d05880e92fbc54618265877c00618f1394d29d47.tar.gz | |
Qt Designer: Fix clazy-container-anti-pattern
Change-Id: I72581f2788fe3e8d81e50248929127408f639c9c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
| -rw-r--r-- | src/assistant/assistant/preferencesdialog.cpp | 2 | ||||
| -rw-r--r-- | src/designer/src/lib/shared/connectionedit.cpp | 8 |
2 files changed, 4 insertions, 6 deletions
diff --git a/src/assistant/assistant/preferencesdialog.cpp b/src/assistant/assistant/preferencesdialog.cpp index 963b61596..4652d0187 100644 --- a/src/assistant/assistant/preferencesdialog.cpp +++ b/src/assistant/assistant/preferencesdialog.cpp @@ -251,7 +251,7 @@ void PreferencesDialog::updateFilterPage() for (const QString &a : helpEngine.filterAttributes()) new QTreeWidgetItem(m_ui.attributeWidget, QStringList() << a); - if (!m_filterMap.keys().isEmpty()) + if (!m_filterMap.isEmpty()) m_ui.filterWidget->setCurrentRow(0); } diff --git a/src/designer/src/lib/shared/connectionedit.cpp b/src/designer/src/lib/shared/connectionedit.cpp index 8f3b12ab2..219774113 100644 --- a/src/designer/src/lib/shared/connectionedit.cpp +++ b/src/designer/src/lib/shared/connectionedit.cpp @@ -1194,12 +1194,10 @@ void ConnectionEdit::mouseDoubleClickEvent(QMouseEvent *e) case Dragging: break; case Editing: - if (!m_widget_under_mouse.isNull()) { + if (!m_widget_under_mouse.isNull()) emit widgetActivated(m_widget_under_mouse); - } else if (m_sel_con_set.size() == 1) { - Connection *con = m_sel_con_set.keys().first(); - modifyConnection(con); - } + else if (m_sel_con_set.size() == 1) + modifyConnection(m_sel_con_set.constBegin().key()); break; } |