diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2019-09-09 15:22:34 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2019-09-16 09:23:09 +0200 |
commit | 450b55b3993bd600efaff17ff6ee3e4be73f3575 (patch) | |
tree | 7d2d35e6da5fdbb4805d8f8a899e2502d92055d9 | |
parent | 01d70a3150191445b043873db2a19474983a411e (diff) | |
download | qttools-450b55b3993bd600efaff17ff6ee3e4be73f3575.tar.gz |
Qt Designer: Refactor generateNewFormXML() helper
Undo the overzealous QStringLiteral() use introduced in the early days
of Qt 5. Strip the newlines and use raw strings for clarity.
Task-number: QTBUG-78138
Change-Id: I07ae3180d075e52bae9e1ea594e404f171aa87e7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
-rw-r--r-- | src/designer/src/lib/shared/widgetdatabase.cpp | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/src/designer/src/lib/shared/widgetdatabase.cpp b/src/designer/src/lib/shared/widgetdatabase.cpp index 1a9297e73..2aceaa6a1 100644 --- a/src/designer/src/lib/shared/widgetdatabase.cpp +++ b/src/designer/src/lib/shared/widgetdatabase.cpp @@ -601,22 +601,20 @@ static QString xmlFromWidgetBox(const QDesignerFormEditorInterface *core, const // Generate default standard ui new form xml based on the class passed on as similarClassName. static QString generateNewFormXML(const QString &className, const QString &similarClassName, const QString &name) { - QString rc; { - QTextStream str(&rc); - str << QStringLiteral("<ui version=\"4.0\" >\n<class>") << name << QStringLiteral("</class>\n") - << QStringLiteral("<widget class=\"") << className << QStringLiteral("\" name=\"") << name << QStringLiteral("\" >\n") - << QStringLiteral("<property name=\"geometry\" >\n<rect><x>0</x><y>0</y><width>") - << NewFormWidth << QStringLiteral("</width><height>") << NewFormHeight << QStringLiteral("</height></rect>\n</property>\n"); - str << QStringLiteral("<property name=\"windowTitle\" >\n<string>") << name << QStringLiteral("</string>\n</property>\n"); - - if (similarClassName == QStringLiteral("QMainWindow")) { - str << QStringLiteral("<widget class=\"QWidget\" name=\"centralwidget\" />\n"); - } else { - if (similarClassName == QStringLiteral("QWizard")) - str << QStringLiteral("<widget class=\"QWizardPage\" name=\"wizardPage1\" /><widget class=\"QWizardPage\" name=\"wizardPage2\" />\n"); - } - str << QStringLiteral("</widget>\n</ui>\n"); + QString rc; + QTextStream str(&rc); + str << R"(<ui version="4.0"><class>)" << name << "</class>" + << R"(<widget class=")" << className << R"(" name=")" << name << R"(">)" + << R"(<property name="geometry" ><rect><x>0</x><y>0</y><width>)" + << NewFormWidth << "</width><height>" << NewFormHeight << "</height></rect></property>" + << R"(<property name="windowTitle"><string>)" << name << "</string></property>\n"; + + if (similarClassName == QLatin1String("QMainWindow")) { + str << R"(<widget class="QWidget" name="centralwidget"/>)"; + } else if (similarClassName == QLatin1String("QWizard")) { + str << R"(<widget class="QWizardPage" name="wizardPage1"/><widget class="QWizardPage" name="wizardPage2"/>)"; } + str << "</widget></ui>\n"; return rc; } |