diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2016-09-06 17:44:08 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2016-09-09 17:22:45 +0000 |
| commit | 78bc427395116bfaf3d99134f42aec5310020f8e (patch) | |
| tree | cd14d5c3354210a8b61cf3f7183a461c458f3512 /tests | |
| parent | 1ffd91a8a0c7ddb901b3c91f0f5e475811994e59 (diff) | |
| download | qtsvg-78bc427395116bfaf3d99134f42aec5310020f8e.tar.gz | |
Fix UB (signed overflow) in QSvgIconEnginePrivate::pmcKey()
Found by UBsan:
qsvgiconengine.cpp:64:84: runtime error: left shift of 537133056 by 4 places cannot be represented in type 'int'
Fix by casting to qint64 at the start of the shift-or chain.
The total cumulative shift is by 28 places, so 64 bits should
be enough to not overflow anymore.
Change-Id: Ia37bc98c5af67a4de10fb9807addd369110f36d2
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions