diff options
| author | Joerg Bornemann <joerg.bornemann@qt.io> | 2021-07-06 18:24:11 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-07-06 20:02:57 +0000 |
| commit | 3bb9dc32df973faeb2bd2c44c4c9883e0da493ba (patch) | |
| tree | bbf07f20ca9c9e0a5f77de892752738d953911c7 | |
| parent | 546e6846eb641aa943aaca6ce0e650222c455482 (diff) | |
| download | qtsvg-3bb9dc32df973faeb2bd2c44c4c9883e0da493ba.tar.gz | |
CMake: Don't give plugins PUBLIC usage requirements
The pro2cmake.py conversion script faithfully reproduced the .pro files
for the plugins, which specified the libraries as public. But in CMake,
the implications of this are that public usage requirements should then
be propagated to consumers. We don't expect any consumers, since a
plugin is created as a MODULE library in CMake, so for Windows we don't
even have an import library to link with. The only exception to this is
for static builds where plugins are created as STATIC libraries
instead, but only in certain controlled situations do we then link to
plugins. Even then, usage requirements are not expected to propagate to
the consumers, so these relationships should always be specified as
private.
Task-number: QTBUG-90819
Change-Id: Ifa2d76d6bff7b29d746455aa070a77cbd06879f0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
(cherry picked from commit 80dd9dffbc7c7fa2c20954fcd23084f65120b83a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/plugins/iconengines/svgiconengine/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | src/plugins/imageformats/svg/CMakeLists.txt | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/iconengines/svgiconengine/CMakeLists.txt b/src/plugins/iconengines/svgiconengine/CMakeLists.txt index 9371b6e..9c69df5 100644 --- a/src/plugins/iconengines/svgiconengine/CMakeLists.txt +++ b/src/plugins/iconengines/svgiconengine/CMakeLists.txt @@ -10,7 +10,7 @@ qt_internal_add_plugin(QSvgIconPlugin SOURCES main.cpp qsvgiconengine.cpp qsvgiconengine.h - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::CorePrivate Qt::Gui diff --git a/src/plugins/imageformats/svg/CMakeLists.txt b/src/plugins/imageformats/svg/CMakeLists.txt index cec6f77..3c5979f 100644 --- a/src/plugins/imageformats/svg/CMakeLists.txt +++ b/src/plugins/imageformats/svg/CMakeLists.txt @@ -10,7 +10,7 @@ qt_internal_add_plugin(QSvgPlugin SOURCES main.cpp qsvgiohandler.cpp qsvgiohandler.h - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::Gui Qt::Svg |