summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2016-04-30 10:25:27 +0300
committerDenis Shienkov <denis.shienkov@gmail.com>2016-05-13 11:27:08 +0000
commit2ac9c0c0e6210f73884bbe2bcb3d8269519003a8 (patch)
treee6f9334060f66448d9dff69c723eab6871ff3485 /tests
parenta11fa1dfd529948da961d3d292926a15f9b7005b (diff)
downloadqtserialport-2ac9c0c0e6210f73884bbe2bcb3d8269519003a8.tar.gz
Replace 'Q_FOREACH' with the range-based 'for'
Change-Id: I057267982ac946ce1ec863a79120cd21cd563c4b Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com> Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/auto/qserialport/tst_qserialport.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/auto/qserialport/tst_qserialport.cpp b/tests/auto/qserialport/tst_qserialport.cpp
index f100d35..b9d41b8 100644
--- a/tests/auto/qserialport/tst_qserialport.cpp
+++ b/tests/auto/qserialport/tst_qserialport.cpp
@@ -265,7 +265,7 @@ void tst_QSerialPort::openExisting()
QFETCH(bool, openResult);
QFETCH(QSerialPort::SerialPortError, errorCode);
- foreach (const QString &serialPortName, m_availablePortNames) {
+ for (const QString &serialPortName : qAsConst(m_availablePortNames)) {
QSerialPort serialPort(serialPortName);
QSignalSpy errorSpy(&serialPort, static_cast<void (QSerialPort::*)(QSerialPort::SerialPortError)>(&QSerialPort::error));
QVERIFY(errorSpy.isValid());
@@ -1055,9 +1055,9 @@ void tst_QSerialPort::controlBreak()
QVERIFY2(!timeout(), "Timed out when waiting for the read of break state.");
QVERIFY(receiverPort.bytesAvailable() > 0);
- foreach (const char c, receiverPort.readAll()) {
- QCOMPARE(c, char(0));
- }
+ const QByteArray actual = receiverPort.readAll();
+ const QByteArray expected(actual.size(), '\0');
+ QCOMPARE(actual, expected);
QVERIFY(senderPort.setBreakEnabled(false));
QCOMPARE(senderPort.isBreakEnabled(), false);