Fix QSPI::isNull()

The method QSPI::isNull() should return false when QSPI is empty.

Tested on Winsows 8 and Linux with on-board, virtual and USB serial
ports using Qt5 and then Qt4.

Task-number: QTBUG-41262
Change-Id: Ic9e0afc5549311283aef7ec2ed841f5e418b7edf
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>

3 files changed, 126 insertions, 1 deletions

diff --git a/tests/auto/auto.pro b/tests/auto/auto.pro
index 14963a2..5e317d7 100644
--- a/tests/auto/auto.pro
+++ b/tests/auto/auto.pro
@@ -1,2 +1,2 @@
 TEMPLATE = subdirs
-SUBDIRS += qserialport cmake
+SUBDIRS += qserialport qserialportinfo cmake
diff --git a/tests/auto/qserialportinfo/qserialportinfo.pro b/tests/auto/qserialportinfo/qserialportinfo.pro
new file mode 100644
index 0000000..b3e49bd
--- /dev/null
+++ b/tests/auto/qserialportinfo/qserialportinfo.pro
@@ -0,0 +1,11 @@
+QT = core testlib
+TARGET = tst_qserialportinfo
+#CONFIG += testcase
+
+greaterThan(QT_MAJOR_VERSION, 4) {
+    QT += serialport
+} else {
+    include($$QTSERIALPORT_PROJECT_ROOT/src/serialport/qt4support/serialport.prf)
+}
+
+SOURCES = tst_qserialportinfo.cpp
diff --git a/tests/auto/qserialportinfo/tst_qserialportinfo.cpp b/tests/auto/qserialportinfo/tst_qserialportinfo.cpp
new file mode 100644
index 0000000..afbcf0b
--- /dev/null
+++ b/tests/auto/qserialportinfo/tst_qserialportinfo.cpp
@@ -0,0 +1,114 @@
+/****************************************************************************
+**
+** Copyright (C) 2014 Denis Shienkov <denis.shienkov@gmail.com>
+** Contact: http://www.qt-project.org/legal
+**
+** This file is part of the QtSerialPort module of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia.  For licensing terms and
+** conditions see http://qt.digia.com/licensing.  For further information
+** use the contact form at http://qt.digia.com/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPL included in the
+** packaging of this file.  Please review the following information to
+** ensure the GNU Lesser General Public License version 2.1 requirements
+** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights.  These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3.0 as published by the Free Software
+** Foundation and appearing in the file LICENSE.GPL included in the
+** packaging of this file.  Please review the following information to
+** ensure the GNU General Public License version 3.0 requirements will be
+** met: http://www.gnu.org/copyleft/gpl.html.
+**
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+
+#include <QtTest/QtTest>
+#include <QtSerialPort/QSerialPort>
+#include <QtSerialPort/QSerialPortInfo>
+
+class tst_QSerialPortInfo : public QObject
+{
+    Q_OBJECT
+public:
+    explicit tst_QSerialPortInfo();
+
+private slots:
+    void initTestCase();
+
+    void constructors();
+    void assignment();
+
+private:
+    QString m_senderPortName;
+    QString m_receiverPortName;
+    QStringList m_availablePortNames;
+};
+
+tst_QSerialPortInfo::tst_QSerialPortInfo()
+{
+}
+
+void tst_QSerialPortInfo::initTestCase()
+{
+    m_senderPortName = QString::fromLocal8Bit(qgetenv("QTEST_SERIALPORT_SENDER"));
+    m_receiverPortName = QString::fromLocal8Bit(qgetenv("QTEST_SERIALPORT_RECEIVER"));
+    if (m_senderPortName.isEmpty() || m_receiverPortName.isEmpty()) {
+#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
+        QSKIP("Test doesn't work because the names of serial ports aren't found in env.");
+#else
+        QSKIP("Test doesn't work because the names of serial ports aren't set found env.", SkipAll);
+#endif
+    } else {
+        m_availablePortNames << m_senderPortName << m_receiverPortName;
+    }
+}
+
+void tst_QSerialPortInfo::constructors()
+{
+    QSerialPortInfo empty;
+    QVERIFY(empty.isNull());
+    QSerialPortInfo empty2(QLatin1String("ABCD"));
+    QVERIFY(empty2.isNull());
+    QSerialPortInfo empty3(empty);
+    QVERIFY(empty3.isNull());
+
+    QSerialPortInfo exist(m_senderPortName);
+    QVERIFY(!exist.isNull());
+    QSerialPortInfo exist2(exist);
+    QVERIFY(!exist2.isNull());
+}
+
+void tst_QSerialPortInfo::assignment()
+{
+    QSerialPortInfo empty;
+    QVERIFY(empty.isNull());
+    QSerialPortInfo empty2;
+    empty2 = empty;
+    QVERIFY(empty2.isNull());
+
+    QSerialPortInfo exist(m_senderPortName);
+    QVERIFY(!exist.isNull());
+    QSerialPortInfo exist2;
+    exist2 = exist;
+    QVERIFY(!exist2.isNull());
+}
+
+QTEST_MAIN(tst_QSerialPortInfo)
+#include "tst_qserialportinfo.moc"