summaryrefslogtreecommitdiff
path: root/src/serialport/qserialport_win.cpp
diff options
context:
space:
mode:
authorLaszlo Papp <lpapp@kde.org>2013-11-24 18:32:42 +0000
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-11-25 08:39:25 +0100
commit1a6ec9148a782c06ee84961c16a57411dc8bcbee (patch)
treeee93eb21cf8802561f1748a4f3b904f32965c611 /src/serialport/qserialport_win.cpp
parent671c23c662e7f7eeaac796517448d12fb019d853 (diff)
downloadqtserialport-1a6ec9148a782c06ee84961c16a57411dc8bcbee.tar.gz
Simplify the standard baudrate getter by dropping the foreach
1f1ca7490fa6e2231f396e564dacbbd8d0e10b29 rewrote this part of the code, but the needless logic has not be dropped respectively. It was necessary before the rewrite since the raw qint32* type had to be converted to QList<qint32>, but since we have a more Qt'ish data storage up front, we do not need to iterate through the list since it is ready-made for us. Change-Id: Iab5d4b0d48de3fc27fb41a4694f044bd58e760c4 Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com> Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Diffstat (limited to 'src/serialport/qserialport_win.cpp')
-rw-r--r--src/serialport/qserialport_win.cpp9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp
index 80cba34..42d8fbf 100644
--- a/src/serialport/qserialport_win.cpp
+++ b/src/serialport/qserialport_win.cpp
@@ -1155,14 +1155,7 @@ qint32 QSerialPortPrivate::settingFromBaudRate(qint32 baudRate)
QList<qint32> QSerialPortPrivate::standardBaudRates()
{
- QList<qint32> ret;
- const QList<qint32> baudRatePairs = standardBaudRatePairList();
-
- foreach (qint32 baudRatePair, baudRatePairs) {
- ret.append(baudRatePair);
- }
-
- return ret;
+ return standardBaudRatePairList();
}
void QSerialPortPrivate::setError(QSerialPort::SerialPortError serialPortError, const QString &errorString)