diff options
| author | Denis Shienkov <denis.shienkov@gmail.com> | 2014-12-05 12:57:48 +0300 |
|---|---|---|
| committer | Denis Shienkov <denis.shienkov@gmail.com> | 2014-12-05 11:22:26 +0100 |
| commit | 160efdbbf51c38ac973b0e36b98b72e2439f51e6 (patch) | |
| tree | 15dfc04a499e297e138363d9c77d83e3c371977e /src/serialport/qserialport_p.h | |
| parent | 4484e56bbdd832c0ea8478034287ee183496a7bf (diff) | |
| download | qtserialport-160efdbbf51c38ac973b0e36b98b72e2439f51e6.tar.gz | |
Do not use internal pre-cached RTS and DTR variables
Some devices do not support these signals, and returns an errors when attempt
to query it. But the QSP::open() always requests a status of these lines.
In this case the QSP::open() will return true, but also will setup an error
code (for example, QSP::UnsupportedOperationError for socat's devices in
Linux). That is unexpected behavior for the user.
It is reasonable do not query a state of these signals when opening.
Also we do not need to use of appropriate internal variables, and we can
remove it.
Change-Id: I277110014c20c1f2c3fdaed20c4582d1356897b9
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Diffstat (limited to 'src/serialport/qserialport_p.h')
| -rw-r--r-- | src/serialport/qserialport_p.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/serialport/qserialport_p.h b/src/serialport/qserialport_p.h index 6f39260..578d8a9 100644 --- a/src/serialport/qserialport_p.h +++ b/src/serialport/qserialport_p.h @@ -75,8 +75,6 @@ public: QSerialPort::StopBits stopBits; QSerialPort::FlowControl flowControl; QSerialPort::DataErrorPolicy policy; - bool dataTerminalReady; - bool requestToSend; bool settingsRestoredOnClose; QSerialPort * const q_ptr; }; |