summaryrefslogtreecommitdiff
path: root/src/serialport/qserialport_p.h
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2014-11-16 22:52:12 +0300
committerDenis Shienkov <denis.shienkov@gmail.com>2014-11-17 12:04:05 +0100
commit0585be1fe38474e07d72f920e63c23d0252b00fe (patch)
treeadfecc0708735fba217763d7e90b147df6ae695a /src/serialport/qserialport_p.h
parent2c171c043ce3c4ca40c8dd91971192efe3c0465e (diff)
downloadqtserialport-0585be1fe38474e07d72f920e63c23d0252b00fe.tar.gz
Use internal read buffer of QIODevice
It is reasonable to use the internal read buffer of QIODevice instead of additional QRingBuffer which currently are used. It will allow to reduce an overhead when copying data as now there is not an excess chain with QRingBuffer. Besides, the majority of I/O classes from QtCore (except QProcess) also use the internal QIODevice buffer which are optimized for this purpoze. Tested on Windows 8 and Linux with the virtual com0com and on-board serial ports. Change-Id: I6c3d4b84593940ccfef8c15c9fbef16bddcd002f Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Diffstat (limited to 'src/serialport/qserialport_p.h')
-rw-r--r--src/serialport/qserialport_p.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/serialport/qserialport_p.h b/src/serialport/qserialport_p.h
index 4dcf634..43a4f20 100644
--- a/src/serialport/qserialport_p.h
+++ b/src/serialport/qserialport_p.h
@@ -162,7 +162,6 @@ public:
static QList<qint32> standardBaudRates();
qint64 readBufferMaxSize;
- QRingBuffer readBuffer;
QRingBuffer writeBuffer;
QSerialPort::SerialPortError error;
QString systemLocation;