summaryrefslogtreecommitdiff
path: root/src/serialport/qserialport.cpp
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2016-06-30 19:27:25 +0300
committerDenis Shienkov <denis.shienkov@gmail.com>2016-07-07 17:12:54 +0000
commit5ddbb6b87266d0f8d7dffc03c86c2e80b3735d2c (patch)
treeb1765f3ca80875dbeb0899340ef2ad571dded79e /src/serialport/qserialport.cpp
parenta713565d119c39bd31ec25926ded881d1f0b78b7 (diff)
downloadqtserialport-5ddbb6b87266d0f8d7dffc03c86c2e80b3735d2c.tar.gz
Minimize number of system calls at opening
Currently, the method QSP::open() several times calls the system functions to get/set of DCB/termios structures for each parameter. It is not rational and should be minimized as possible, in ideally to once executed. Change-Id: If1f308176a82f3c8896fc648bf656f089e099f3f Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com> Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Diffstat (limited to 'src/serialport/qserialport.cpp')
-rw-r--r--src/serialport/qserialport.cpp9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/serialport/qserialport.cpp b/src/serialport/qserialport.cpp
index 45f56c8..d4e9a4f 100644
--- a/src/serialport/qserialport.cpp
+++ b/src/serialport/qserialport.cpp
@@ -568,15 +568,6 @@ bool QSerialPort::open(OpenMode mode)
if (!d->open(mode))
return false;
- if (!d->setBaudRate()
- || !d->setDataBits(d->dataBits)
- || !d->setParity(d->parity)
- || !d->setStopBits(d->stopBits)
- || !d->setFlowControl(d->flowControl)) {
- d->close();
- return false;
- }
-
QIODevice::open(mode);
return true;
}