diff options
author | Denis Shienkov <denis.shienkov@gmail.com> | 2017-09-27 19:25:01 +0300 |
---|---|---|
committer | Denis Shienkov <denis.shienkov@gmail.com> | 2017-10-05 06:44:37 +0000 |
commit | da09f8f01d13ff467f0a628b6348aa9300160875 (patch) | |
tree | 9220bd9f22b8581acc2e29ed25b7601ed932419e /examples/serialport/cwriterasync/main.cpp | |
parent | 7f51ee09e7986ccf689b611166a3b083ec52a718 (diff) | |
download | qtserialport-da09f8f01d13ff467f0a628b6348aa9300160875.tar.gz |
Revamp the Console Asynchronous Writer Example
* Use the 'const' keywords more.
* Split very long lines.
* Remove QT_USE_NAMESPACE macro.
* Update includes to common style.
* Use more member class initializations.
* Remove empy dtor.
Task-number: QTBUG-60652
Change-Id: Ia9b108ad9fd65d55dd88e2d6c1e3ee36830abb6e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'examples/serialport/cwriterasync/main.cpp')
-rw-r--r-- | examples/serialport/cwriterasync/main.cpp | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/examples/serialport/cwriterasync/main.cpp b/examples/serialport/cwriterasync/main.cpp index 4ffb44b..4d65e0a 100644 --- a/examples/serialport/cwriterasync/main.cpp +++ b/examples/serialport/cwriterasync/main.cpp @@ -50,33 +50,32 @@ #include "serialportwriter.h" -#include <QtSerialPort/QSerialPort> - -#include <QTextStream> #include <QCoreApplication> #include <QFile> +#include <QSerialPort> #include <QStringList> - -QT_USE_NAMESPACE +#include <QTextStream> int main(int argc, char *argv[]) { QCoreApplication coreApplication(argc, argv); - int argumentCount = QCoreApplication::arguments().size(); - QStringList argumentList = QCoreApplication::arguments(); + const int argumentCount = QCoreApplication::arguments().size(); + const QStringList argumentList = QCoreApplication::arguments(); QTextStream standardOutput(stdout); if (argumentCount == 1) { - standardOutput << QObject::tr("Usage: %1 <serialportname> [baudrate]").arg(argumentList.first()) << endl; + standardOutput << QObject::tr("Usage: %1 <serialportname> [baudrate]") + .arg(argumentList.first()) << endl; return 1; } QSerialPort serialPort; - QString serialPortName = argumentList.at(1); + const QString serialPortName = argumentList.at(1); serialPort.setPortName(serialPortName); - int serialPortBaudRate = (argumentCount > 2) ? argumentList.at(2).toInt() : QSerialPort::Baud9600; + const int serialPortBaudRate = (argumentCount > 2) + ? argumentList.at(2).toInt() : QSerialPort::Baud9600; serialPort.setBaudRate(serialPortBaudRate); serialPort.open(QIODevice::WriteOnly); @@ -87,11 +86,14 @@ int main(int argc, char *argv[]) return 1; } - QByteArray writeData(dataFile.readAll()); + const QByteArray writeData(dataFile.readAll()); dataFile.close(); if (writeData.isEmpty()) { - standardOutput << QObject::tr("Either no data was currently available on the standard input for reading, or an error occurred for port %1, error: %2").arg(serialPortName).arg(serialPort.errorString()) << endl; + standardOutput << QObject::tr("Either no data was currently available on " + "the standard input for reading, " + "or an error occurred for port %1, error: %2") + .arg(serialPortName).arg(serialPort.errorString()) << endl; return 1; } |