summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2015-06-30 17:43:46 +0300
committerDenis Shienkov <denis.shienkov@gmail.com>2015-07-02 08:33:00 +0000
commite2cbf244cbf58211a5d9808a285f878e92d21291 (patch)
treed6817a51ea0fb2c8001d1147cda6411c4c627c27
parent3f9fabb7dafa9bc0c8965d476152491b70ee04a7 (diff)
downloadqtserialport-e2cbf244cbf58211a5d9808a285f878e92d21291.tar.gz
Get rid of QSPP::bytesToWrite()
It is not worth to spread the platform-specifics over multiple files, as the difference are actually tiny and much better expressed with an ifdef. (cherry-picked from ad8b9773a2f996e988d7b0c4dd439a3e21ca8c09) Change-Id: I5279e05d52ce5243ad3d0655c6353e1fb18891a1 Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
-rw-r--r--src/serialport/qserialport.cpp8
-rw-r--r--src/serialport/qserialport_unix.cpp5
-rw-r--r--src/serialport/qserialport_unix_p.h1
-rw-r--r--src/serialport/qserialport_win.cpp5
-rw-r--r--src/serialport/qserialport_win_p.h1
-rw-r--r--src/serialport/qserialport_wince.cpp5
-rw-r--r--src/serialport/qserialport_wince_p.h1
7 files changed, 7 insertions, 19 deletions
diff --git a/src/serialport/qserialport.cpp b/src/serialport/qserialport.cpp
index 3362fef..0c31cf4 100644
--- a/src/serialport/qserialport.cpp
+++ b/src/serialport/qserialport.cpp
@@ -1210,7 +1210,13 @@ qint64 QSerialPort::bytesAvailable() const
qint64 QSerialPort::bytesToWrite() const
{
Q_D(const QSerialPort);
- return d->bytesToWrite() + QIODevice::bytesToWrite();
+ qint64 bytes = QIODevice::bytesToWrite();
+#ifdef Q_OS_WIN32
+ bytes += d->actualBytesToWrite;
+#else
+ bytes += d->writeBuffer.size();
+#endif
+ return bytes;
}
/*!
diff --git a/src/serialport/qserialport_unix.cpp b/src/serialport/qserialport_unix.cpp
index bf61875..c5a71ae 100644
--- a/src/serialport/qserialport_unix.cpp
+++ b/src/serialport/qserialport_unix.cpp
@@ -855,11 +855,6 @@ inline bool QSerialPortPrivate::initialize(QIODevice::OpenMode mode)
return true;
}
-qint64 QSerialPortPrivate::bytesToWrite() const
-{
- return writeBuffer.size();
-}
-
qint64 QSerialPortPrivate::writeData(const char *data, qint64 maxSize)
{
::memcpy(writeBuffer.reserve(maxSize), data, maxSize);
diff --git a/src/serialport/qserialport_unix_p.h b/src/serialport/qserialport_unix_p.h
index 852564d..0aee078 100644
--- a/src/serialport/qserialport_unix_p.h
+++ b/src/serialport/qserialport_unix_p.h
@@ -137,7 +137,6 @@ public:
bool startAsyncWrite();
bool completeAsyncWrite();
- qint64 bytesToWrite() const;
qint64 writeData(const char *data, qint64 maxSize);
static qint32 baudRateFromSetting(qint32 setting);
diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp
index 5dc95ee..d189ba3 100644
--- a/src/serialport/qserialport_win.cpp
+++ b/src/serialport/qserialport_win.cpp
@@ -670,11 +670,6 @@ void QSerialPortPrivate::emitReadyRead()
emit q->readyRead();
}
-qint64 QSerialPortPrivate::bytesToWrite() const
-{
- return actualBytesToWrite;
-}
-
qint64 QSerialPortPrivate::writeData(const char *data, qint64 maxSize)
{
Q_Q(QSerialPort);
diff --git a/src/serialport/qserialport_win_p.h b/src/serialport/qserialport_win_p.h
index 826e786..5a0817a 100644
--- a/src/serialport/qserialport_win_p.h
+++ b/src/serialport/qserialport_win_p.h
@@ -118,7 +118,6 @@ public:
bool setReadNotificationEnabled(bool enable);
bool setWriteNotificationEnabled(bool enable);
- qint64 bytesToWrite() const;
qint64 writeData(const char *data, qint64 maxSize);
static qint32 baudRateFromSetting(qint32 setting);
diff --git a/src/serialport/qserialport_wince.cpp b/src/serialport/qserialport_wince.cpp
index 33f0755..72e1652 100644
--- a/src/serialport/qserialport_wince.cpp
+++ b/src/serialport/qserialport_wince.cpp
@@ -580,11 +580,6 @@ bool QSerialPortPrivate::notifyWrite()
return true;
}
-qint64 QSerialPortPrivate::bytesToWrite() const
-{
- return writeBuffer.size();
-}
-
qint64 QSerialPortPrivate::writeData(const char *data, qint64 maxSize)
{
::memcpy(writeBuffer.reserve(maxSize), data, maxSize);
diff --git a/src/serialport/qserialport_wince_p.h b/src/serialport/qserialport_wince_p.h
index 08302f6..0a4b800 100644
--- a/src/serialport/qserialport_wince_p.h
+++ b/src/serialport/qserialport_wince_p.h
@@ -104,7 +104,6 @@ public:
bool notifyRead();
bool notifyWrite();
- qint64 bytesToWrite() const;
qint64 writeData(const char *data, qint64 maxSize);
static qint32 baudRateFromSetting(qint32 setting);