diff options
| author | Denis Shienkov <denis.shienkov@gmail.com> | 2013-08-21 22:59:15 +0400 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-08-26 09:20:43 +0200 |
| commit | fea1f6030287b5499ed6d4922695e1f3b4ebc00a (patch) | |
| tree | aa4261330587d0b4e1fb097d58e5e2ab6f981718 | |
| parent | 7ecd8db87105948a9e8978d2464c9157f81bb1c7 (diff) | |
| download | qtserialport-fea1f6030287b5499ed6d4922695e1f3b4ebc00a.tar.gz | |
Unix: Deleting a duplicating call of a non-blocking mode on descriptor
The call fcntl(fd, F_SETFL, FNDELAY) is superfluous because a flag FNDELAY
duplicates by functionality an existing flag O_NONBLOCK in open() function.
See more info, e.g.: http://linux.die.net/man/2/open
Tested on Gnu/Linux distro's with Qt4 and Qt5.
Change-Id: I01be72e78a9493af8077245cbf6a88e8c9d164ee
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
| -rw-r--r-- | src/serialport/qserialport_unix.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/serialport/qserialport_unix.cpp b/src/serialport/qserialport_unix.cpp index 93d01a6..448701b 100644 --- a/src/serialport/qserialport_unix.cpp +++ b/src/serialport/qserialport_unix.cpp @@ -171,8 +171,6 @@ bool QSerialPortPrivate::open(QIODevice::OpenMode mode) return false; } - ::fcntl(descriptor, F_SETFL, FNDELAY); - QTtyLocker::lock(ptr); if (!QTtyLocker::isLocked(ptr, &byCurrPid)) { q->setError(QSerialPort::PermissionError); |