Use early return on error in the open method

It was done like that for consistency with QFile, probably, but it is not a good
style in Qt overall.

Change-Id: I5233a7f0f03cab947b061520fe2ec64585632920
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/src/serialport/qserialport.cpp b/src/serialport/qserialport.cpp
index 3f14662..cfb30bc 100644
--- a/src/serialport/qserialport.cpp
+++ b/src/serialport/qserialport.cpp
@@ -525,15 +525,15 @@ bool QSerialPort::open(OpenMode mode)
     }
 
     clearError();
-    if (d->open(mode)) {
-        QIODevice::open(mode);
+    if (!d->open(mode))
+        return false;
 
-        d->dataTerminalReady = isDataTerminalReady();
-        d->requestToSend = isRequestToSend();
+    QIODevice::open(mode);
 
-        return true;
-    }
-    return false;
+    d->dataTerminalReady = isDataTerminalReady();
+    d->requestToSend = isRequestToSend();
+
+    return true;
 }
 
 /*!