Create notifier only in end of successful initialization

... otherwise, this notifier's instance will be active even
if the serial port is not open.

Change-Id: Ieebb894a048f3ed89ac5d1c259e21bc790f5d387
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp
index 95edf2d..a69f975 100644
--- a/src/serialport/qserialport_win.cpp
+++ b/src/serialport/qserialport_win.cpp
@@ -694,15 +694,15 @@ inline bool QSerialPortPrivate::initialize(QIODevice::OpenMode mode)
         return false;
     }
 
+    if ((eventMask & EV_RXCHAR) && !startAsyncCommunication())
+        return false;
+
     notifier = new QWinOverlappedIoNotifier(q);
     QObjectPrivate::connect(notifier, &QWinOverlappedIoNotifier::notified,
                this, &QSerialPortPrivate::_q_notified);
     notifier->setHandle(handle);
     notifier->setEnabled(true);
 
-    if ((eventMask & EV_RXCHAR) && !startAsyncCommunication())
-        return false;
-
     return true;
 }