summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/script/api/qscriptengine_p.h4
-rw-r--r--src/script/bridge/qscriptqobject.cpp1
-rw-r--r--tests/auto/qscriptextqobject/tst_qscriptextqobject.cpp18
3 files changed, 23 insertions, 0 deletions
diff --git a/src/script/api/qscriptengine_p.h b/src/script/api/qscriptengine_p.h
index 526fb1d..df52ee8 100644
--- a/src/script/api/qscriptengine_p.h
+++ b/src/script/api/qscriptengine_p.h
@@ -50,6 +50,7 @@
#include "bridge/qscriptobject_p.h"
#include "bridge/qscriptqobject_p.h"
#include "bridge/qscriptvariant_p.h"
+#include "bridge/qscriptactivationobject_p.h"
#include "DateConstructor.h"
#include "DateInstance.h"
@@ -1070,6 +1071,9 @@ inline QObject *QScriptEnginePrivate::toQObject(JSC::ExecState *exec, JSC::JSVal
if (QMetaType::typeFlags(type) & QMetaType::PointerToQObject)
return *reinterpret_cast<QObject* const *>(var.constData());
}
+ } else if (isObject(value) && value.inherits(&QScript::QScriptActivationObject::info)) {
+ QScript::QScriptActivationObject *proxy = static_cast<QScript::QScriptActivationObject *>(JSC::asObject(value));
+ return toQObject(exec, proxy->delegate());
}
#endif
return 0;
diff --git a/src/script/bridge/qscriptqobject.cpp b/src/script/bridge/qscriptqobject.cpp
index cc4817a..962479f 100644
--- a/src/script/bridge/qscriptqobject.cpp
+++ b/src/script/bridge/qscriptqobject.cpp
@@ -32,6 +32,7 @@
#include "../api/qscriptable_p.h"
#include "../api/qscriptcontext_p.h"
#include "qscriptfunction_p.h"
+#include "qscriptactivationobject_p.h"
#include "Error.h"
#include "PrototypeFunction.h"
diff --git a/tests/auto/qscriptextqobject/tst_qscriptextqobject.cpp b/tests/auto/qscriptextqobject/tst_qscriptextqobject.cpp
index 3c97aef..d4c4caf 100644
--- a/tests/auto/qscriptextqobject/tst_qscriptextqobject.cpp
+++ b/tests/auto/qscriptextqobject/tst_qscriptextqobject.cpp
@@ -584,6 +584,7 @@ private slots:
void nestedArrayAsSlotArgument();
void nestedObjectAsSlotArgument_data();
void nestedObjectAsSlotArgument();
+ void propertyAccessThroughActivationObject();
private:
QScriptEngine *m_engine;
@@ -3654,5 +3655,22 @@ void tst_QScriptExtQObject::nestedObjectAsSlotArgument()
}
}
+// QTBUG-21760
+void tst_QScriptExtQObject::propertyAccessThroughActivationObject()
+{
+ QScriptContext *ctx = m_engine->pushContext();
+ ctx->setActivationObject(m_engine->newQObject(m_myObject));
+
+ QVERIFY(m_engine->evaluate("intProperty").isNumber());
+ QVERIFY(m_engine->evaluate("mySlot()").isUndefined());
+ QVERIFY(m_engine->evaluate("mySlotWithStringArg('test')").isUndefined());
+
+ QVERIFY(m_engine->evaluate("dynamicProperty").isError());
+ m_myObject->setProperty("dynamicProperty", 123);
+ QCOMPARE(m_engine->evaluate("dynamicProperty").toInt32(), 123);
+
+ m_engine->popContext();
+}
+
QTEST_MAIN(tst_QScriptExtQObject)
#include "tst_qscriptextqobject.moc"