| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The layout was being destroyed before the text, which meant that the
removeItemChangeListener() call never got hit. To ensure that the
listener is always removed, loop through each child in QQuickLayout's
destructor.
Task-number: QTBUG-51927
Change-Id: I4235579501bd1790e9483a8741915e55f1b1b803
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
Prevent extra value changed signal to be fired in case when Slider with
minimum > 0 and value > minimum are set.
Change-Id: I86824c403a7c0296f782d2eec7ed30acfc13b304
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Property binding for row property in styleData causes an update which
tries to read new value for the index property, but index is changed
afterwards which causes old value to be read. This may lead to crashes
and other unwanted behavior.
Depth changes are now delivered to update item depths in visible
items and model index changes though role instead of looking for a row
change.
Task-number: QTBUG-47523
Change-Id: I540cd06a25281f18e4628f4b030cf969dc8e0a7f
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If scroll indicator is at the beginning and data prepended to
contentItem, scroll indicator should change position to previous content
beginning.
This is especially important with so-called "infinite scrolling", when
scrolling goes upwards and new content added at the top of the view.
Task-number: QTBUG-50795
Change-Id: I250d6535b1146a54c6a70062b659cc49ed43709f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
| |
Change-Id: I1c4c467eb549ea0be40cb1706647f933a963ada5
Task-number: QTBUG-54558
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
|
|
|
|
|
|
|
| |
Use the pre-defined macro.
Change-Id: I52e362672ff719202d3e40e4245baac2af29f624
Task-number: QTBUG-53208
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-53123
Change-Id: If7b33d46828808d869a7e325a908a8a353c35f57
Reviewed-by: Liang Qi <liang.qi@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been consistently blocking the qt5 integration, and nobody is
able to reproduce the crash locally or when running tests manually in
the CI. We don't even know where exactly it crashes, but this change
skips the test that we assume to be problematic.
Change-Id: Ia5665a542890b90a296d5d068c14e78fc9c3c625
Task-nubmer: QTBUG-53123
Reviewed-by: Liang Qi <liang.qi@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
Let QML TestCase be implicitly shown together with the internal test
window. The visibility binding to windowShown is unnecessary, and might
cause extra visibility state changes, which in turn may cause other
issues further down the chain.
Change-Id: I59654c4035185ddcbc1e2c4c231f9a6d76d12383
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I232cf933b20e53ea7403a993edfe00c5eda5a0b1
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
...and let it destruct together with the control.
tst_extras::Tests_Common::test_resize(PieMenu) is constantly crashing
in the Win 10 CI. This is a random shot attempting to solve the crash.
We're not able to reproduce the issue locally or even when running the
test manually on the CI.
Change-Id: Iee717cdcf4b05273c05833856a9b5fd18443ca82
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
| |
A width of 60 is too small on Windows, and was causing warnings.
Change-Id: Iae4f643fcc9c30a561720b653151cad7ba6d0f20
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
| |
The minimumValueAngle and maximumValueAngle variables it mentions are
private.
Change-Id: Ib95c96aeb218c8624857c212429f6c4e4e77ece2
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Dialog use implicitly positioned items as content. This makes
impossible to use item, that can be properly resized with change of
dialog window size and has proper default size (set implicit width and
height).
This change made it use implicit size if there is one item or fallback
to previous algorithm, that use childrenRect for explicitly sized and
positioned items, so it won't break behavior of the existing
applications.
[ChangeLog][Dialog] Proper resize and default size for content
Task-number: QTBUG-49058
Change-Id: I7fa4da7d5fd39d47f60ba9f43c88f78e75739b0a
Initial-patch-by: Nikita Krupenko <krnekit@gmail.com>
Reviewed-by: Nikita Krupenko <krnekit@gmail.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Because of bug QTBUG-47523 we need to skip this test until it is
fixed properly.
Remove the 'skip' after the bug is fixed.
Task-number: QTBUG-47523
Change-Id: I4ba514ac7cc38026ced16f8e12bea6e8ac329818
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Subjects each *.png file that matched grep -law "sRGB" to:
pngcrush -ow -brute -rem allb -reduce
(Some needed -force but did get smaller.)
Change-Id: I56774d04c4a0397ae183cd70d8edd7f9f0cfcb22
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
|
|
|
|
|
|
|
| |
This should test QTBUG-41951
Change-Id: I262f3e7ca1573dcfb149f3ae942e17817d2e1caf
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
Show both QQuickView/createWindowContainer and QQuickWidget.
Make it work with shadow-builds by passing the full path of the source via
define.
Task-number: QTBUG-49097
Change-Id: Idbad3a28ae4f803fea57e94c5750224fa5aa1e1e
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Id898b5e3d5182ee6dcb09758298d4cb0fed3bea8
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
This avoids clashes between Qt Quick Controls and Qt Labs Controls.
Change-Id: Ia1d367c271a3c80259d4f59be891c211ec061e01
Task-number: QTBUG-49794
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
The mouse event that dismissed a popup window should
not dispatched to the visual item. Otherwise the
menu open again.
Task-number: QTBUG-44532
Change-Id: Id8aca1634e4f1795e546230953bff49518589714
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a popup is brought up by a press event for a menu
inside the menubar it should not handle the relative
next release event if it falls outside the popup.
Before forwarding the release event we first check if a
previous press event was seen, if not we simply discard
the event.
Task-number: QTBUG-47295
Task-number: QTBUG-45117
Change-Id: I632fab0a3abfdfc9872f85f99f9d7f50d41526cc
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I662eea96b72043d06fe94707e77a9ead5a951e3d
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-49359
Task-number: QTBUG-49360
Change-Id: I96ec6d46de189ec396ef26c0d059c65360da4ec0
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-49353
Change-Id: I285f058f7df9cceb9d9c52bd822cd3ad772627fc
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were relying on model.get() to somehow reevaluate after we'd updated
properties of model items, which somehow worked until
4876ea6a18ccdfd72014582aa5d50ab9f6b6ec9e.
The correct approach is to do the same thing as we do for
styleData.index: rely on the model properties that are exposed to the
delegate, which do get updated.
Change-Id: I529ab7dcc142187fc185b11658dc5e1496b6d6db
Task-number: QTBUG-48839
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previoulsy we manually positioned the table header over the table
contents, which required some manual tweakings. Since 5.4, ListView
support overlay headers that we can use them to clean our code in
BasicTableView.
There is, however, a small issue on Mac where the vertical scrollbar
(specially in non-transient mode) is displayed below the table header.
Since the header can't span beyond the ListView boundaries, we need
to account for the vertical scrollbar width in the ListView's content
width.
This patch also updates the Desktop style to set the transientScrollBars
property and some small tweaks to the Base style.
Change-Id: I4433d0703328f23eadb0ae4563fbef5bba0168db
Task-number: QTBUG-34344
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|\
| |
| |
| | |
Change-Id: I7177ee6f1dc74d7f0d2ac9a3aedcc8d7a00cee41
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ComboBox checks selected text like a boolean value. This check is
unnecessary and prevents from item with empty text could be selected.
[ChangeLog][ComboBox] ComboBox is now able to select
items with empty text.
Task-number: QTBUG-42127
Change-Id: Ifaa0598d17c85cee099c88f4e03092137ba17c70
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Floating point doesn't quite reliably satisfy certain standard
identities of arithmetic ...
Task-number: QTBUG-42358
Change-Id: I7417feedbfc1fd6f59510e0ee6d07d98ff7ddc46
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Extending the Tumblers setCurrentIndexAt method with timeinterval, which
is set to the animation so while it changes it can move slower then
default.
Task-number: QTBUG-48680
Change-Id: Ic8e76c604bad928ae7b11cfbea76c11d5d295f80
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add qtgraphicaleffects as a dependency to sync.profile.
Change-Id: I8f0d0be2f05aeb193ecdd296d7eeedb6cc90fac5
Task-number: QTBUG-46393
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Ie26c941c33fdd8baab49dc13b84d02e2b83af5e1
|
| |
| |
| |
| |
| |
| |
| |
| | |
By default, it’s not possible to tab into certain controls.
Change-Id: Ia0941e5016926f65ab58a7391d6271d15b0c5248
Task-number: QTBUG-46393
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a menu popup gets closed it usually needs to be destroyed right away
since we don't recycle its contents. There is an exception, however, and
it's when he user triggers a menu item.
In this case, we need to proceed in three steps. First, we hide the menu
popup, then we emit the triggered signal, and when that one returns, the
menu contents can be disposed. If we did all in a single step, we may end
up with a crash since we don't support deleting a QtQuick item while it's
running a signal handler. Delayed deletions don't work either in the case
when the triggered handler ends up running the event loop.
Task-number: QTBUG-45182
Task-number: QTBUG-47682
Task-number: QTBUG-48382
Change-Id: Ic39717e09f38df602f641250cd81cf4931863db6
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |\
| | |
| | |
| | | |
Change-Id: I6a887182dbed50c8028bd2dbed71e48d5226fac8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise users can trigger shortcuts even when buttons are disabled.
Change-Id: If97c6a3c3df574a4271c53cf7bcfd8fdb1a059d6
Task-number: QTBUG-48144
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This leads to serious memory/OpenGL context leaks on
Windows. No such thing has been noticed on Linux which
may hint to differences in the backend.
Task-number: QTBUG-47682
Change-Id: I274ed98db348ffe2c78707f2c92b812f272c2723
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Ie81aa6abe8a4acbd201e4938f0cb693a8b3aa567
|
| |
| |
| |
| |
| |
| |
| |
| | |
Also, print extra information when the test is about to fail
since it has proven to be a bit flaky lately.
Change-Id: I4042cb99eb2b3fcb3677de63cd425d0ade4bdc34
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I7041fbe141f9f95be3e6d5c6a9f0abf543877194
Task-number: QTBUG-44185
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| | |
QTBUG-44664 is fixed now.
Change-Id: I0645d4522f093057606b53228e99c1d20668f2d2
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|\ \
| |/
| |
| | |
Change-Id: Ifec0f56816809abb90a294b8462391cb7e54c87d
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
That parameter is actually delay, so a delay of 1 millisecond was being
passed.
These were found with:
git grep "mouseMove\(.*\, .*\, .*\, Qt.LeftButton\)"
Change-Id: I00172dcd457aa4aae12d98421bc95525235c9570
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the case a view is embedded in a QWidget, such widget may be
embedded anywhere in parent widgets. if it's not at a 0,0 position
compared to the toplevel widget, the position needs to be adjusted by
the relative position of the QQuickWindow in regards to the toplevel
one, in which in this case is given by transientParent()
Change-Id: Iafb7a42bdb641850fe77932d14bac9a715059b37
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Its purpose is the same as QAbstractItemView::rootIndex
and allows to display only the part of the model data that
is descendant of this index.
The filesystembrowser example has been updated to only show
files reachable from the user's home directory.
[ChangeLog][TreeView] Added rootIndex property
Change-Id: Ib8d9af4ce9d1f341ab509de3cc991773830ba9f4
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|\ \ |
|
| |\ \
| | |/
| | |
| | | |
Change-Id: I689c18ad192a38581d3058e2a555d6438a8d08e2
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As we keep track of the previous user-selected row,
it can happen that that row is no longer part of the
TreeModelAdaptor items if the user collapses it or
any of its ancestors (collapsing a node doesn't update
the current selection). This will result on the row
index pointing to the wrong entry in the model (or a
completely invalid one).
Instead, we now track the selection with QModelIndexes
making it more robust to branch expansion and collapse
in the view. We'll still need to account for model changes
which means that, in the future, we should invalidate
the previous user-selected item.
Change-Id: I54ba2582e65515eef95d5f8ad755a8c68568d7ad
Task-number: QTBUG-46891
Reviewed-by: Caroline Chao <caroline.chao@theqtcompany.com>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
The test may be too sensitive to style variations. Until we can
verify its validity on Ubuntu 10.04, it will remain skipped.
(Blacklisting support is missing for QML auto-tests.)
Change-Id: I534803870b28fdf5539a852bd13a7f8c50d5d5ca
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|