| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calendar was implemented in such a way that pressing on a date selects
that date, rather than releasing or clicking. With the current code,
this presents issues when the month changes as a result of the press.
For example, clicking on a date in an adjacent month will result in the
clicked() signal passing the date under the mouse in the new month,
instead of the originally pressed date.
This patches fixes the issue by storing the pressed date and using it
when emitting the released() and clicked() signals.
Task-number: QTBUG-54129
Change-Id: I0c16293033b77f6ae783b5365d198b4a516af90b
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/dialogs/qquickabstractfiledialog_p.h
tests/auto/controls/data/tst_combobox.qml
Change-Id: I62e54d0a2e89d987e05e8dfad6ae6aac1a32cc72
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was a bogus timer firing once after the test had been running 500 ms. The
timer was supposed to be used as a workaround on Mac, but since it had running
set to true, it was actually firing once on all platforms.
The timer was originally added in 6254af5. The test function ended up being
skipped on Mac, so the timer was actually pointless.
Task-number: QTBUG-64664
Reviewed-by: Liang Qi <liang.qi@qt.io>
(cherry picked from commit a749525164b771452599e67e277d2ea6b3866479)
Change-Id: Icebda05c872ba2de690e87bd0a9968670f203ce2
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-47243
Change-Id: I19d06df099a9da253059d2d0aa4a290b41a17ada
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The default handle size is based off the height of text on the system
that the test is run on. By making the size fixed, we remove the
possibility for small differences in compare results.
Task-number: QTBUG-65224
Change-Id: I14061a028360340c6b284fb450bf1252014dc9b2
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: If27d9c3cbc17765c4180651189c4b8d19b8409da
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I fixed a similar issue last year on the JavaScript side:
094ad30c94a72784449f43ef06d2172d644ab0fd
At this time the same thing has been happening in C++. See QTBUG-54559
and the patch for a detailed explanation of the issue. In short,
the problem with Calendar is that internally it uses QDate which does
not keep information about time, whereas in the JavaScript world date
is always combined with time. So, QDate(2017-10-15) is valid, but when
during QDate -> JS Date transformation we add time to it (which defaults
to midnight (00:00)), it becomes invalid in time zones where the Daylight
Saving Time -> Standard Time transition takes place at midnight.
To avoid switching the entire QQuickCalendarModel1
to using QDateTime, I modified its date(...) and dateAt(...) methods to
return QDateTime with the time part always set to 12:00.
That transformation required more changes in QQuickRangedDate1, because
Calendar::selectedDate internally is QQuickRangedDate1::selectedDate,
and I also had to fix "selected" property binding in the Base Calendar
Style as it did take into account the time part of the date, which
resulted in wrong behavior with my changes.
Task-number: QTBUG-64068
Change-Id: Ia2f7703ff4e5811ef79438c97739da1d8001a7f5
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The ScrollView is not a control widget, which should be included in the
focus chain when the user presses the Tab key; instead, it's a container
and as such it should not interfere with the navigation.
We also modify TableView, because it derives from ScrollView but we
want to keep its current behavior.
Task-number: QTBUG-64596
Change-Id: Ibd7833603d38171693b2f34c5859e9c4615b8ed4
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was a bogus timer firing once after the test had been running 500 ms. The
timer was supposed to be used as a workaround on Mac, but since it had running
set to true, it was actually firing once on all platforms.
The timer was originally added in 6254af5. The test function ended up being
skipped on Mac, so the timer was actually pointless.
Task-number: QTBUG-64664
Change-Id: I5b4803ba49db0ab7e1b4dd632a34d51af59bbf91
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Test was fixed by commit c84f7554894cef0cbeeba8a61f441286e190a797
in qtbase.
Task-number: QTBUG-64523
Change-Id: I86195fe049c61ceab43566d004c8f6e6bfcee041
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-64523
Change-Id: Icc369c1933a725321927f46255bb396800a0ac5d
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: Ia33462a31303ae79f7a6ef26dc6065a0afeef3e1
|
| |
| |
| |
| |
| | |
Change-Id: I03c222a72490959d55b3077a6282553a4bfcf7d2
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is exactly the same as the minimum change, when the maximum is
changed, the handle position needs to be re-evaluated.
Task-number: QTBUG-63354
Change-Id: I13a67451190a3bb7915afe8e89501097c1dd3301
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
[ChangeLog][FileDialog] Added defaultSuffix property
Task-number: QTBUG-39230
Change-Id: I7dc73c332ad62129d7158b6f6f5a614b8582ffbc
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The tests for boot2qt were disabled with commit
555750221ee3850ba70169a2b6854041b434c592. The tests can
be enabled since qtdeclarative now fallbacks to software
renderer if OpenGL is not supported.
Changes needed:
- Using grabImage does not work correctly on offscreen platform, so
tests relying on it are skipped
- Extra 1ms delay is needed between two mouse clicks to get rid of
test_activeFocusOnPress() flakiness on software quick renderer
Change-Id: Ie985110c171bc395bac0d63cd2fbb94207c63516
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|\ \
| |/
| |
| | |
Change-Id: I6fab4a2531f013291329f2277849f3ef251f0eda
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This seems to help get rid of the ApplicationWindows that would
otherwise stick around until the end of the controls tests.
Change-Id: I0f5cc81e07c727070c3f80654d46881c696eebe7
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: Ie6ad3e9490dcf85bd5deb4c6d7004a4aa8b81433
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Increase QtQuick import version to 2.6 to enable the properties of
underlying QML Text type to be usable in the QML Label type too.
Task-number: QTBUG-57895
Change-Id: I7a2b641a56c90ab91b4e6c973278d8943fa6903a
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using a mouse, you want a slider to react immediately to input,
not only if you move beyond a certain threshold. With the threshold it
is very hard to accurately position the slider. On touchscreens, the
threshold is necessary to allow for unrelated events, like flicking
views, to not interfere with the value.
Change-Id: I6cb8252338f20de559e062e738118593ffc1e099
Task-number: QTBUG-47081
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently boot2qt is tested with QEMU and some tests fail. Disabling
them for now to make it possible to enable qt5 tests for Coin.
Task-number: QTBUG-60266
Change-Id: Ifabc4c4b93beda1990fc4f4d6e254dcd704f93fc
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: Ib466b1c42e232d75a022588e99e9e204a8c7bad9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is useful to set a locale on a specific calendar, as opposed to
using the application-wide default.
plugins.qmltypes was also updated.
[ChangeLog][Calendar] Added locale property, which affects which day is
shown as the first day of the week, as well as date and day name
localization.
Task-number: QTBUG-60217
Change-Id: I113298a3f3b6dd407d26f3f55ed6973e73ab6a4c
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a property to disable the scroll wheel for the Slider.
This is useful if there is a scrollable list of sliders, because scrolling
would be interrupted as soon as the mouse gets above a slider
(whereby scrolling would change the slider value).
By setting this property to false, a user can easily scroll through the list.
[ChangeLog][Slider] add property to disable scroll wheel
Task-number: QTBUG-59271
Change-Id: I9306638ef98f8a0a5035709a67cc1ee40713441a
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f3a0c9680b264fc7f2f9e4ac3fe43d0c8321fbef.
It got fixed by qtdeclarative 2a15f6c5.
Task-number: QTBUG-58993
Change-Id: Ica846e5826bbf4ffc9f7d0e512816ab879a62ed9
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit cdd589d53c8f2f03c868cb618baf7f55956ebcb6.
It got fixed by qtdeclarative 2a15f6c5.
Task-number: QTBUG-49360
Change-Id: I0ad7f30c0bc442510a0918f0a61e64e966dd6676
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
This is failing sporadically on Windows 10. Replace wait(0) with a more
reliable tryCompare() check.
Task-number: QTBUG-58859
Change-Id: Ia2010afd17051334717e944d8c303f757c14a6b0
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-58993
Change-Id: I5149cf70f9b49902005469b44d561744a4ca8667
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
Didn't find correct BLACKLIST way yet.
Task-number: QTBUG-49360
Change-Id: I43ff4ccfd6f0b48088925a72ed8e8e6232607b78
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
They will be moved to qtdeclarative.
Task-number: QTBUG-58294
Change-Id: I2fcc2fa07db07c2a90a68e77656140e7cf8cdc2b
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
This ensures that the appropriate objects are destroyed at the end of
each test function, even if the test fails.
Task-number: QTBUG-56491
Change-Id: I9dc8c99ab447eb665533af4690e7271f64457009
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
|
|
|
|
|
|
|
| |
This ensures that the appropriate objects are destroyed at the end of
each test function, even if the test fails.
Task-number: QTBUG-53520
Change-Id: Ic5935b3f7e530b8b4d2261fc68161ce4116fb325
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|\
| |
| |
| | |
Change-Id: I67ccb5a6763045a0728d04e804f8a47c37b425f5
|
| |\
| | |
| | |
| | | |
Change-Id: Idef60aa2d7b55600cca618f0f622e8e18e77f3de
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-53520
Change-Id: I0a38467a873bac8104b2e1fba7f7018f236673e6
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The use case is testing the built package in Debian, when the files
are built locally, but not yet installed on the system.
Change-Id: Ibe06b33b2d6fb625d3bc65e9f54b6c1407c415c9
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/controls/controls.pro
Change-Id: I0150ca08d83f292a5c8587ec886e206124757df4
|
| |\ \
| | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/controls/Private/qquickrangemodel.cpp
src/controls/Private/qquickrangemodel_p.h
src/controls/Private/qquickrangemodel_p_p.h
src/layouts/qquicklayout.cpp
tests/auto/controls/data/tst_rangemodel.qml
Change-Id: I9c8f6326c6edf9ebb18dd538f76830e1b439ba8e
|
| | |\
| | | |
| | | |
| | | | |
Change-Id: I216e0df7ffff798827f4bea2c5cb8769eb37a053
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The layout was being destroyed before the text, which meant that the
removeItemChangeListener() call never got hit. To ensure that the
listener is always removed, loop through each child in QQuickLayout's
destructor.
Task-number: QTBUG-51927
Change-Id: I4235579501bd1790e9483a8741915e55f1b1b803
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
__handlePos (badly named; it should be, e.g. __handleValueForPos)
represents the value of the handle based on "fakeHandle"'s position. It
is the result of range.valueForPosition() being called. However, the
arguments to this function (fakeHandle.x and fakeHandle.y) don't always
change when the values of the slider change, which leads to the x
calculation for the handle delegate in SliderStyle having outdated
information, causing the related bug.
The fix for another bug already works around this issue by passing the
relevant properties as arguments (which are ignored) to the function
call. This is presumably done this way because it should be cheaper
than forcing the JavaScript engine to evaluate a more clearly written
expression where each related property is on its own line, for example.
property real __handlePos: {
range.positionAtMinimum, range.positionAtMaximum;
return range.valueForPosition(__horizontal ? fakeHandle.x : fakeHandle.y);
}
In the case of the related bug, minimumValue has been updated, but
__handlePos is still using the old value, causing the handle to be
positioned incorrectly. So, we continue this tradition and add another
property to the list of arguments.
Task-number: QTBUG-51765
Change-Id: I40882872e668a867a8f5e5768244e199618bd769
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
| | |/
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-55727
Change-Id: I6cbc1f020ead184fd8475f965f69db635ee2cc7b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Prevent extra value changed signal to be fired in case when Slider with
minimum > 0 and value > minimum are set.
Change-Id: I86824c403a7c0296f782d2eec7ed30acfc13b304
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Bug is fixed now in declarative.
Task-number: QTBUG-54394
Change-Id: I5fcc39125eca2bca3c597fc472b596dc317275e5
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|\ \ \
| |/ /
| | |
| | | |
Change-Id: I4f85412071d34b44f76870753e171e0beae2e7b9
|
| |\ \
| | |/
| | |
| | |
| | |
| | |
| | | |
Conflicts:
tests/auto/qquicktreemodeladaptor/tst_qquicktreemodeladaptor.cpp
Change-Id: I0b6018fdac65a5385136e4c3561fba1c52ecd32e
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Property binding for row property in styleData causes an update which
tries to read new value for the index property, but index is changed
afterwards which causes old value to be read. This may lead to crashes
and other unwanted behavior.
Depth changes are now delivered to update item depths in visible
items and model index changes though role instead of looking for a row
change.
Task-number: QTBUG-47523
Change-Id: I540cd06a25281f18e4628f4b030cf969dc8e0a7f
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If scroll indicator is at the beginning and data prepended to
contentItem, scroll indicator should change position to previous content
beginning.
This is especially important with so-called "infinite scrolling", when
scrolling goes upwards and new content added at the top of the view.
Task-number: QTBUG-50795
Change-Id: I250d6535b1146a54c6a70062b659cc49ed43709f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The issue was fixed by 651ecf9ae413478af622761e89347bb4e6243e0c in
qtdeclarative.
This reverts commit 817d6971ebf75d0b276a93e1ee15d4826ba76c30.
Task-number: QTBUG-55325
Change-Id: Ic9e730c65d613fcbb3c1b2a7ff86689c6f39ec12
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|