| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Change-Id: I16f4822905f5c1cff5b4f02144b54058e82cae6f
Reviewed-by: Marko Kangas <marko.kangas@theqtcompany.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
When a menu receive a Key_Right event and its subMenu popupwindow
is already visible, the event should be discarded. In this way
the event can forwarded up to the menubar for moving to the next root menu.
Change-Id: Ifeb402f66fdac9fcf3a541456b929d11d36ad00d
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was due to a couple of factors interacting:
1) the QQuickMenu::__popupVisible property is not in sync with the
popupWindow::visible property. In fact, the QQuickMenu::__popupVisible
becomes true before the PopupWindow::Show() method is called.
2) In the Menu.qml file, the menu content item is created through the user
of Loader, whose active property becomes true when the
QQuickMenu::__popupVisible property is true. So the result is that the
MenuContentItem is created before the QQuickPopupWindow is effectively
visible.
3) Given point (2), the MenuContentItem requests focus on creation (since
it has focus: true). However, given (1), the QQuickPopupWindow is
neither visible nor active.
This patch addresses this problem by forcing activeFocus to the
menuContentItem only when the popupWindow gets focus.
Task-number: QTBUG-41951
Change-Id: I095700726aab4ac45a62cd37b33a069e294df30e
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I2183a869aef2c949dc1528e7b97e08c7b035c315
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Id7908e45b04358387bf0e3ffd418ea6842ff889d
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dialog wrapper calculate button box width only when there is at least 2
right buttons, which produce wrong button positions in other cases. This
change made Dialog to handle all cases.
[ChangeLog][Dialog] Properly handle width of button box when it has
less than two right buttons
Task-number: QTBUG-49380
Change-Id: Id033803e8b3c15cb465bf942eebc30ca77d58ad6
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I106b1e042434b168333283aa792b67727b8f40b3
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-48991
Change-Id: I2b2ca8270b6c25769d3b3214f052050c25f7f15b
Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
ComboBox checks selected text like a boolean value. This check is
unnecessary and prevents from item with empty text could be selected.
[ChangeLog][ComboBox] ComboBox is now able to select
items with empty text.
Task-number: QTBUG-42127
Change-Id: Ifaa0598d17c85cee099c88f4e03092137ba17c70
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Floating point doesn't quite reliably satisfy certain standard
identities of arithmetic ...
Task-number: QTBUG-42358
Change-Id: I7417feedbfc1fd6f59510e0ee6d07d98ff7ddc46
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I1c9e3edf401b4a6b02bafe4086a57679b4ada79c
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I0f2b1f2b963b2e07adcf241543de9510536dadca
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
By default, it’s not possible to tab into certain controls.
Change-Id: Ia0941e5016926f65ab58a7391d6271d15b0c5248
Task-number: QTBUG-46393
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a menu popup gets closed it usually needs to be destroyed right away
since we don't recycle its contents. There is an exception, however, and
it's when he user triggers a menu item.
In this case, we need to proceed in three steps. First, we hide the menu
popup, then we emit the triggered signal, and when that one returns, the
menu contents can be disposed. If we did all in a single step, we may end
up with a crash since we don't support deleting a QtQuick item while it's
running a signal handler. Delayed deletions don't work either in the case
when the triggered handler ends up running the event loop.
Task-number: QTBUG-45182
Task-number: QTBUG-47682
Task-number: QTBUG-48382
Change-Id: Ic39717e09f38df602f641250cd81cf4931863db6
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
| |
Among other things, we removed one connection object per menu delegate.
We also made the logic more predictable and less dependent on property
changes order.
Task-number: QTBUG-48382
Change-Id: Ic97a7bf9c4ac8ff07f98bdd4a420e19bd228a6f1
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|\
| |
| |
| | |
Change-Id: Iad7030d43a688e9f10761619607ce42b44d54012
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We are obviously deleting the menu popup contents too early. A fix and
ammendment for QTBUG-45182, QTBUG-47682 and QTBUG-48382 is in progress
and will be merged in after 5.5.1.
This effectively reverts 3799188e704e48ff8e9aa72.
Task-number: QTBUG-48382
Change-Id: I38c9e20d710d0bf41810640e5bf83f477abf2934
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
| |\
| | |
| | |
| | | |
Change-Id: I6a887182dbed50c8028bd2dbed71e48d5226fac8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This leads to serious memory/OpenGL context leaks on
Windows. No such thing has been noticed on Linux which
may hint to differences in the backend.
Task-number: QTBUG-47682
Change-Id: I274ed98db348ffe2c78707f2c92b812f272c2723
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ib94de261355ced4072f8c75c988b62c093a129ca
Reviewed-by: Shawn Rutledge <shawn.rutledge@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Iceef723a407f49d36b288e50df3dec9debbe9ba7
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I1b3f8fb8861499e55c34690580ad2d5d15dfa55f
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| | |
The plugin.qmltypes has been regenerate using qmlplugindump in order to
include new components. Since we are still missing a working
dependency handler, some components (QQuickWindowQmlImpl, QQuickWindow,
QWindow) have been manually added, like it was in the previous version.
Change-Id: Ie794710de49c248b13ad36a01d5a02b1cb1ecea1
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The classname in qmldir needs to match the name of the c++
class that represents the plugin. Otherwise qmlimportscanner
will be confused.
Task-number: QTBUG-47489
Change-Id: Iac56803127cad7bf072f29c611936df16dcf32d4
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|/
|
|
|
|
|
|
| |
Otherwise users can trigger shortcuts even when buttons are disabled.
Change-Id: If97c6a3c3df574a4271c53cf7bcfd8fdb1a059d6
Task-number: QTBUG-48144
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS, the virtual keyboard contains buttons for standard
edit actions like cut, copy and paste. When triggered, we
send key events that corresponds to the shortcut
sequence for those actions. With this patch, you can then
trigger the menu items directly from the virtual keyboard.
Change-Id: I350f74942b9ae443387bb253aeafa053e7544f7e
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I9c73dc3714af2e200a1acee57cf38ffbb4126a22
Task-number: QTBUG-44443
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I9cc08b64521f414b50598aead3957347ff30528a
Task-number: QTBUG-45131
Reviewed-by: Christian Stromme <christian.stromme@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
Also, print extra information when the test is about to fail
since it has proven to be a bit flaky lately.
Change-Id: I4042cb99eb2b3fcb3677de63cd425d0ade4bdc34
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
| |
LGPLv3 refers to it but does not include it in its body.
Change-Id: Ib056b47dde3341ef9a52ffff13eed18cf3504738
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
|
|
|
|
|
| |
Change-Id: I7041fbe141f9f95be3e6d5c6a9f0abf543877194
Task-number: QTBUG-44185
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I7de63cea34404712dda41c75819e7bd9ec917215
Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Add the missing includes and helper functions to make the
QtQuickControls module compile on WinCE
Change-Id: I3c614de295c0db616543953a142d796e58a9a11c
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
Reviewed-by: Gunnar Roth
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I48c49e3087308f7ef54514afebee38cd3843c7cc
Reviewed-by: Topi Reiniö <topi.reinio@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
QDoc gets confused if 'readonly' is mentioned as one of the
parameters to \qmlproperty. The read-only qualifier is
already detected from the property declaration, so we don't
have to mention it twice.
Change-Id: I14834aeca5aac99ea55ca9eacbff2bef8c0ee5f1
Task-number: QTBUG-47576
Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
The native menus are deleted because they're usually children
of the menubar. But we still keep references in QCocoaMenuBar
until we manually remove those form the menu list.
Change-Id: I1651852b6ebc578ca308d69299de4c12764f7363
Task-number: QTBUG-47233
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
That parameter is actually delay, so a delay of 1 millisecond was being
passed.
These were found with:
git grep "mouseMove\(.*\, .*\, .*\, Qt.LeftButton\)"
Change-Id: I00172dcd457aa4aae12d98421bc95525235c9570
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
FontDialog is Qt.NonModal by default.
Task-number: QTBUG-47382
Change-Id: Iafa4cbb1f2a7693ff634be2dcb34b5648e1b952d
Reviewed-by: Timur Pocheptsov <Timur.Pocheptsov@digia.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: Ib306f8f647014b399b87ffff13f24277273a6f4f
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a special model that provides more information.
Replace numerical permissions column by a readable, ls-style
string and add size/date columns. On activation, launch
the file using Qt.openUrlExternally() with the local file
URL.
Change-Id: Ic0801e40cc3ad8498129da06670ba7e11bbf8003
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
Previously, we had the accessibility settings in the desktop style
(only!). Now it's been moved into the actual control implementation.
Change-Id: Idb90d164dfd7a72c8188accd9e4fa3b02d567a94
Reviewed-by: Jan Arve Sæther <jan-arve.saether@theqtcompany.com>
|
|
|
|
|
|
|
| |
Fixes a CI crash reproducible at least on Ubuntu
Change-Id: I45a59054c20c3a99da30b79d33e24184bf328db9
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was working on Qt 5.4.1 but got broken by de9145dcd90.
Can't see nothing fundamentally wrong with that commit, problem
was that the code to reposition the popup assumed the contentItem's hight or
width would change every time and connected to hightChanged/widthChanged to
trigger the repositioning. Since de9145dcd90 those signals are only emitted the
first time the popup is shown.
Call updateSize() explicitly.
Task-number: QTBUG-47092
Change-Id: I303bfae80e5cb72e0c24e26365b8d0faa9ddf400
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
The entire module is "new" with 5.5, and there are already \since
statements in place declaring this.
Change-Id: I76bc2941a520a82de0bd9780ac1786d5430acd0f
Reviewed-by: Liang Qi <liang.qi@theqtcompany.com>
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As we keep track of the previous user-selected row,
it can happen that that row is no longer part of the
TreeModelAdaptor items if the user collapses it or
any of its ancestors (collapsing a node doesn't update
the current selection). This will result on the row
index pointing to the wrong entry in the model (or a
completely invalid one).
Instead, we now track the selection with QModelIndexes
making it more robust to branch expansion and collapse
in the view. We'll still need to account for model changes
which means that, in the future, we should invalidate
the previous user-selected item.
Change-Id: I54ba2582e65515eef95d5f8ad755a8c68568d7ad
Task-number: QTBUG-46891
Reviewed-by: Caroline Chao <caroline.chao@theqtcompany.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-46960
Change-Id: I9198cdac67fdc42ad4ff24d07bdf09357d967140
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-46881
Change-Id: I5f994cd99664ffd6d8f05777e2a4f04fa1639b88
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I0722f4a7970623544124a5b1b75abb5b1221d637
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
|
|
|
|
| |
Change-Id: I219d6411e5d94b2072269d4210702597625dcc42
|
|
|
|
|
|
|
|
|
|
| |
We should emit the accepted and rejected signals, not call the accept
and reject slots directly. Also it doesn't make sense to close the
dialog by default for some standard buttons namely Help, Apply and
Reset.
Change-Id: I48a3bc3c870f1d2f97f923fc24c57abd6594073b
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
|