Merge remote-tracking branch 'origin/5.7' into 5.8v5.8.0-alpha1

Change-Id: I4f85412071d34b44f76870753e171e0beae2e7b9

5 files changed, 168 insertions, 1 deletions

diff --git a/tests/auto/controls/data/tst_scrollview.qml b/tests/auto/controls/data/tst_scrollview.qml
index a9148db4..07d6525e 100644
--- a/tests/auto/controls/data/tst_scrollview.qml
+++ b/tests/auto/controls/data/tst_scrollview.qml
@@ -51,6 +51,7 @@
 import QtQuick 2.2
 import QtTest 1.0
 import QtQuick.Controls 1.2
+import QtQuick.Controls.Styles 1.1
 import QtQuickControlsTests 1.0
 
 Item {
@@ -100,6 +101,68 @@ TestCase {
         scrollView.destroy()
     }
 
+    Component {
+        id: dragFetchAppendComponent
+
+        ScrollView {
+            width: 400; height: 400
+            frameVisible: false
+            style: ScrollViewStyle {
+                transientScrollBars: false
+                handle: Rectangle {
+                    implicitWidth: 16; implicitHeight: 16
+                    color: "red"
+                }
+                scrollBarBackground: Item {width: 16 ; height: 16}
+                incrementControl: Rectangle {
+                    width: 16; height: 16
+                    color: "blue"
+                }
+                decrementControl: Rectangle {
+                    width: 16; height: 16
+                    color: "blue"
+                }
+            }
+            ListView {
+                id: view
+
+                verticalLayoutDirection: ListView.BottomToTop
+                model: TestFetchAppendModel { }
+                delegate: Text {
+                    width: view.width
+                    height: 60
+                    verticalAlignment: Text.AlignVCenter
+                    horizontalAlignment: Text.AlignHCenter
+                    text: "Item %1".arg(model.index)
+                }
+            }
+        }
+    }
+
+    function test_dragFetchAppend() {   // QTBUG-50795
+        var scrollView = dragFetchAppendComponent.createObject(container)
+        verify(scrollView !== null, "view created is null")
+        waitForRendering(scrollView)
+        verify(scrollView.flickableItem.contentHeight === 60 * 20)
+
+        // After scrolling to the end, view should ask the model to fetch more
+        // data, content height should increase and scrollbar handle should move
+        // to the center.
+        mouseDrag(scrollView, scrollView.width - 2, scrollView.height - 8 - 16, 0, -scrollView.height + 8 + 16)
+        waitForRendering(scrollView)
+
+        // Move it again to fetch more data from the model.
+        mouseDrag(scrollView, scrollView.width - 2, scrollView.height / 2, 0, -scrollView.height / 2  + 8 + 16)
+        waitForRendering(scrollView)
+
+        mouseRelease(scrollView, scrollView.width - 2, 8 + 16)
+        waitForRendering(scrollView)
+
+        verify(Math.round(scrollView.flickableItem.contentHeight) > 60 * 20)
+        verify(Math.round(scrollView.flickableItem.contentY) < -(60 * 20))
+
+        scrollView.destroy()
+    }
 
     function test_scrollbars() {
         var component = scrollViewComponent
diff --git a/tests/auto/qquicktreemodeladaptor/tst_qquicktreemodeladaptor.cpp b/tests/auto/qquicktreemodeladaptor/tst_qquicktreemodeladaptor.cpp
index 03927fc2..96659a2c 100644
--- a/tests/auto/qquicktreemodeladaptor/tst_qquicktreemodeladaptor.cpp
+++ b/tests/auto/qquicktreemodeladaptor/tst_qquicktreemodeladaptor.cpp
@@ -73,6 +73,7 @@ private slots:
 
     void moveRows_data();
     void moveRows();
+    void reparentOnSameRow();
 
     void selectionForRowRange();
 
@@ -1152,6 +1153,56 @@ void tst_QQuickTreeModelAdaptor::moveRows()
     compareModels(tma, model);
 }
 
+void tst_QQuickTreeModelAdaptor::reparentOnSameRow()
+{
+    TestModel model(2, 1);
+    model.alternateChildlessRows = false;
+    QQuickTreeModelAdaptor1 tma;
+    tma.setModel(&model);
+
+    const QModelIndex &destParent = model.index(0, 0);
+    const QModelIndex &sourceParent = QModelIndex();
+    QVERIFY(destParent.isValid());
+    tma.expand(destParent);
+    QVERIFY(tma.isExpanded(destParent));
+
+    QSignalSpy dataChangedSpy(&tma, SIGNAL(dataChanged(QModelIndex,QModelIndex,QVector<int>)));
+    QSignalSpy rowsMovedSpy(&tma, SIGNAL(rowsMoved(QModelIndex,int,int,QModelIndex,int)));
+    QVERIFY(rowsMovedSpy.isValid());
+    QVERIFY(dataChangedSpy.isValid());
+
+    QVERIFY(model.moveRows(sourceParent, 1, 1, destParent, 2));
+
+    QModelIndex movedIndex = tma.index(3, 0, QModelIndex());
+    QVERIFY(movedIndex.isValid());
+    QCOMPARE(movedIndex.data(QQuickTreeModelAdaptor1::DepthRole).toInt(), 1);
+    QCOMPARE(tma.data(movedIndex, QQuickTreeModelAdaptor1::ModelIndexRole).toModelIndex(), model.index(2, 0, destParent));
+
+    // at least DepthRole and ModeIndexRole changes should have happened for the affected row
+    bool depthChanged = false;
+    bool modelIndexChanged = false;
+    QList<QList<QVariant> > &changes = dataChangedSpy;
+    foreach (QList<QVariant> change, changes) {
+        if (change.at(0) == movedIndex) {
+            if (change.at(2).value<QVector<int> >().contains(QQuickTreeModelAdaptor1::DepthRole))
+                depthChanged = true;
+            if (change.at(2).value<QVector<int> >().contains(QQuickTreeModelAdaptor1::ModelIndexRole))
+                modelIndexChanged = true;
+        }
+    }
+
+    QCOMPARE(depthChanged, true);
+    QCOMPARE(modelIndexChanged, true);
+
+    QCOMPARE(rowsMovedSpy.count(), 0);
+
+    model.moveRow(destParent, 2, QModelIndex(), 1);
+
+    QCOMPARE(rowsMovedSpy.count(), 0);
+    QVERIFY(tma.testConsistency());
+    compareModels(tma, model);
+}
+
 void tst_QQuickTreeModelAdaptor::selectionForRowRange()
 {
     const int ModelRowCount = 9;
diff --git a/tests/auto/shared/testmodel.h b/tests/auto/shared/testmodel.h
index d8ddd80a..6eaab74a 100644
--- a/tests/auto/shared/testmodel.h
+++ b/tests/auto/shared/testmodel.h
@@ -230,7 +230,7 @@ public:
     bool moveRows(const QModelIndex &sourceParent, int sourceRow, int count, const QModelIndex &destinationParent, int destinationChild)
     {
         Q_ASSERT_X(sourceRow >= 0 && sourceRow < rowCount(sourceParent)
-                   && count > 0 && sourceRow + count < rowCount(sourceParent)
+                   && count > 0 && sourceRow + count - 1 < rowCount(sourceParent)
                    && destinationChild >= 0 && destinationChild <= rowCount(destinationParent),
                    Q_FUNC_INFO, "Rows out of range.");
         Q_ASSERT_X(!(sourceParent == destinationParent && destinationChild >= sourceRow && destinationChild < sourceRow + count),
diff --git a/tests/auto/testplugin/testcppmodels.h b/tests/auto/testplugin/testcppmodels.h
index cb1cfb4f..03b598c4 100644
--- a/tests/auto/testplugin/testcppmodels.h
+++ b/tests/auto/testplugin/testcppmodels.h
@@ -88,6 +88,58 @@ private:
     QList<TestObject> m_testobject;
 };
 
+class TestFetchAppendModel : public QAbstractListModel
+{
+    Q_OBJECT
+public:
+    explicit TestFetchAppendModel(QObject *parent = 0)
+        : QAbstractListModel(parent) { }
+
+    virtual int rowCount(const QModelIndex &parent) const
+    {
+        if (parent.isValid()) {
+            return 0;
+        }
+
+        return m_data.size();
+    }
+    virtual QVariant data(const QModelIndex &index, int role) const
+    {
+        if (!index.isValid() || role != Qt::DisplayRole) {
+            return QVariant();
+        }
+
+        return QVariant::fromValue(index.row());
+    }
+
+    virtual bool canFetchMore(const QModelIndex &parent) const
+    {
+        Q_UNUSED(parent)
+
+        return true;
+    }
+    virtual void fetchMore(const QModelIndex & parent)
+    {
+        Q_UNUSED(parent)
+
+        addMoreData();
+    }
+
+private:
+    void addMoreData()
+    {
+        static const int insertCount = 20;
+
+        beginInsertRows(QModelIndex(), m_data.size(), m_data.size() + insertCount - 1);
+        for (int i = 0; i < insertCount; i++) {
+            m_data.append(int());
+        }
+        endInsertRows();
+    }
+
+    QList<int> m_data;
+};
+
 
 #endif // TESTCPPMODELS_H
 
diff --git a/tests/auto/testplugin/testplugin.cpp b/tests/auto/testplugin/testplugin.cpp
index 45573d92..039a59e0 100644
--- a/tests/auto/testplugin/testplugin.cpp
+++ b/tests/auto/testplugin/testplugin.cpp
@@ -40,6 +40,7 @@ void TestPlugin::registerTypes(const char *uri)
     qmlRegisterType<TestObject>(uri, 1, 0, "TestObject");
     qmlRegisterType<TestItemModel>(uri, 1, 0, "TestItemModel");
     qmlRegisterType<TestModel>(uri, 1, 0, "TreeModel");
+    qmlRegisterType<TestFetchAppendModel>(uri, 1, 0, "TestFetchAppendModel");
 }
 
 void TestPlugin::initializeEngine(QQmlEngine *engine, const char * /*uri*/)