diff options
author | Mitch Curtis <mitch.curtis@theqtcompany.com> | 2015-02-17 13:53:44 +0100 |
---|---|---|
committer | Caroline Chao <caroline.chao@theqtcompany.com> | 2015-03-02 13:52:13 +0000 |
commit | f0c227f8a9a5c5e3ed83f86702626092457175aa (patch) | |
tree | 9d5903b76206906a7dc5abff7a8c06bfcfc3f129 /tests/auto/extras/data/tst_picture.qml | |
parent | b80076c53c045076afdba44a975a533d130a7b60 (diff) | |
download | qtquickcontrols-f0c227f8a9a5c5e3ed83f86702626092457175aa.tar.gz |
Merge Extras' styling system into Controls'.
- Removes the duplicated style settings functionality in Extras and
simplifies the installed styles directory structure.
- Extras' Base style is now part of Controls' Base style, eliminating
the need for a separate QtQuick.Extras.Styles import. The cost of
doing this should be negligible: a few QML files and two images.
If we didn't merge Extras' Baste style into Controls', we'd need
extras-specific code in qquickcontrolssettings, as the default style
search path is:
qml/QtQuick/Controls/Styles/
Whereas the Extras Base style would be in:
qml/QtQuick/Extras/Styles/
The Extras Base style can't go into Controls' Base style directory,
either, because otherwise we'd have two qmldir files there.
The Flat style doesn't have this problem because it is all contained
in one plugin and gets installed into its own Flat/ folder.
- Documentation now lists the Extras controls as \since QtQuick.Extras
1.4.
- Adds the customcontrolsstyle auto test to ensure that custom styling
is tested.
Change-Id: I19ca7a8b7e1c1daa85b272f4ccf9a2f05c76e0d9
Reviewed-by: Caroline Chao <caroline.chao@theqtcompany.com>
Reviewed-by: J-P Nurmi <jpnurmi@theqtcompany.com>
Diffstat (limited to 'tests/auto/extras/data/tst_picture.qml')
-rw-r--r-- | tests/auto/extras/data/tst_picture.qml | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/tests/auto/extras/data/tst_picture.qml b/tests/auto/extras/data/tst_picture.qml index bfdcc557..5ddc4406 100644 --- a/tests/auto/extras/data/tst_picture.qml +++ b/tests/auto/extras/data/tst_picture.qml @@ -36,7 +36,7 @@ import QtTest 1.0 import QtQuick 2.4 -import QtQuick.Extras 1.3 +import QtQuick.Extras 1.4 import QtQuick.Extras.Private 1.0 TestCase { @@ -69,7 +69,7 @@ TestCase { } function test_instance() { - picture = Qt.createQmlObject("import QtQuick.Extras 1.3; Picture { }", testCase, ""); + picture = Qt.createQmlObject("import QtQuick.Extras 1.4; Picture { }", testCase, ""); verify(picture, "Picture: failed to create an instance"); } @@ -93,7 +93,7 @@ TestCase { } function test_source(data) { - picture = Qt.createQmlObject("import QtQuick.Extras 1.3; Picture {}", testCase, ""); + picture = Qt.createQmlObject("import QtQuick.Extras 1.4; Picture {}", testCase, ""); verify(picture, "Picture: failed to create an instance"); picture.source = data.tag; picture.width = data.implicitSize.width; @@ -120,14 +120,17 @@ TestCase { } function test_color(data) { - picture = Qt.createQmlObject("import QtQuick.Extras 1.3; Picture {}", testCase, ""); + picture = Qt.createQmlObject("import QtQuick.Extras 1.4; Picture {}", testCase, ""); verify(picture, "Picture: failed to create an instance"); picture.width = pictureDotDatImplicitSize.width; picture.height = pictureDotDatImplicitSize.height; picture.source = "picture.dat"; picture.color = data.color; - waitForRendering(picture); + // For some reason we need two waits here, otherwise the color detected is *sometimes* white instead of black. + // Also, we use an explicit, shorter timeout, otherwise the default (5000 ms) seems to be exhausted. + waitForRendering(picture, 200); + waitForRendering(picture, 200); var pictureImage = grabImage(picture); @@ -144,7 +147,7 @@ TestCase { } function test_size() { - picture = Qt.createQmlObject("import QtQuick.Extras 1.3; Picture {}", testCase, ""); + picture = Qt.createQmlObject("import QtQuick.Extras 1.4; Picture {}", testCase, ""); verify(picture, "Picture: failed to create an instance"); compare(picture.implicitWidth, fontMetrics.height * 4); |