diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2014-02-02 14:09:09 -0800 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-02-04 14:40:21 +0100 |
commit | 83bf3d791488e763b2d32408edab7f8040c7d0ac (patch) | |
tree | 26b8aee72d43379149d91fcb496d4f21ac1a9896 /src/widgets | |
parent | a1df3e8537b7474db08e81bd1f0faebb13caebf4 (diff) | |
download | qtquickcontrols-83bf3d791488e763b2d32408edab7f8040c7d0ac.tar.gz |
Normalize signal & slot signatures in connection
Profiling shows Qt Creator spends 2% of its load time normalizing
Change-Id: I793aea0f46cc74f6466e52d00c0ec868c6603c77
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Diffstat (limited to 'src/widgets')
-rw-r--r-- | src/widgets/qquickqcolordialog.cpp | 8 | ||||
-rw-r--r-- | src/widgets/qquickqfiledialog.cpp | 14 | ||||
-rw-r--r-- | src/widgets/qquickqfontdialog.cpp | 8 | ||||
-rw-r--r-- | src/widgets/qquickqmessagebox.cpp | 4 |
4 files changed, 17 insertions, 17 deletions
diff --git a/src/widgets/qquickqcolordialog.cpp b/src/widgets/qquickqcolordialog.cpp index ee27d147..aa88aaeb 100644 --- a/src/widgets/qquickqcolordialog.cpp +++ b/src/widgets/qquickqcolordialog.cpp @@ -56,8 +56,8 @@ public: QColorDialogHelper() : QPlatformColorDialogHelper() { - connect(&m_dialog, SIGNAL(currentColorChanged(const QColor&)), this, SIGNAL(currentColorChanged(const QColor&))); - connect(&m_dialog, SIGNAL(colorSelected(const QColor&)), this, SIGNAL(colorSelected(const QColor&))); + connect(&m_dialog, SIGNAL(currentColorChanged(QColor)), this, SIGNAL(currentColorChanged(QColor))); + connect(&m_dialog, SIGNAL(colorSelected(QColor)), this, SIGNAL(colorSelected(QColor))); connect(&m_dialog, SIGNAL(accepted()), this, SIGNAL(accept())); connect(&m_dialog, SIGNAL(rejected()), this, SIGNAL(reject())); } @@ -163,8 +163,8 @@ QPlatformColorDialogHelper *QQuickQColorDialog::helper() if (!m_dlgHelper) { m_dlgHelper = new QColorDialogHelper(); - connect(m_dlgHelper, SIGNAL(currentColorChanged(const QColor&)), this, SLOT(setCurrentColor(QColor))); - connect(m_dlgHelper, SIGNAL(colorSelected(const QColor&)), this, SLOT(setColor(QColor))); + connect(m_dlgHelper, SIGNAL(currentColorChanged(QColor)), this, SLOT(setCurrentColor(QColor))); + connect(m_dlgHelper, SIGNAL(colorSelected(QColor)), this, SLOT(setColor(QColor))); connect(m_dlgHelper, SIGNAL(accept()), this, SLOT(accept())); connect(m_dlgHelper, SIGNAL(reject()), this, SLOT(reject())); } diff --git a/src/widgets/qquickqfiledialog.cpp b/src/widgets/qquickqfiledialog.cpp index c3991b4f..9dc967dd 100644 --- a/src/widgets/qquickqfiledialog.cpp +++ b/src/widgets/qquickqfiledialog.cpp @@ -128,8 +128,8 @@ QPlatformFileDialogHelper *QQuickQFileDialog::helper() if (!m_dlgHelper) { m_dlgHelper = new QFileDialogHelper(); - connect(m_dlgHelper, SIGNAL(directoryEntered(const QUrl &)), this, SIGNAL(folderChanged())); - connect(m_dlgHelper, SIGNAL(filterSelected(const QString &)), this, SIGNAL(filterSelected())); + connect(m_dlgHelper, SIGNAL(directoryEntered(QUrl)), this, SIGNAL(folderChanged())); + connect(m_dlgHelper, SIGNAL(filterSelected(QString)), this, SIGNAL(filterSelected())); connect(m_dlgHelper, SIGNAL(accept()), this, SLOT(accept())); connect(m_dlgHelper, SIGNAL(reject()), this, SLOT(reject())); } @@ -140,11 +140,11 @@ QPlatformFileDialogHelper *QQuickQFileDialog::helper() QFileDialogHelper::QFileDialogHelper() : QPlatformFileDialogHelper() { - connect(&m_dialog, SIGNAL(currentChanged(const QString&)), this, SLOT(currentChanged(const QString&))); - connect(&m_dialog, SIGNAL(directoryEntered(const QString&)), this, SLOT(directoryEntered(const QString&))); - connect(&m_dialog, SIGNAL(fileSelected(const QString&)), this, SLOT(fileSelected(const QString&))); - connect(&m_dialog, SIGNAL(filesSelected(const QStringList&)), this, SLOT(filesSelected(const QStringList&))); - connect(&m_dialog, SIGNAL(filterSelected(const QString&)), this, SIGNAL(filterSelected(const QString&))); + connect(&m_dialog, SIGNAL(currentChanged(QString)), this, SLOT(currentChanged(QString))); + connect(&m_dialog, SIGNAL(directoryEntered(QString)), this, SLOT(directoryEntered(QString))); + connect(&m_dialog, SIGNAL(fileSelected(QString)), this, SLOT(fileSelected(QString))); + connect(&m_dialog, SIGNAL(filesSelected(QStringList)), this, SLOT(filesSelected(QStringList))); + connect(&m_dialog, SIGNAL(filterSelected(QString)), this, SIGNAL(filterSelected(QString))); connect(&m_dialog, SIGNAL(accepted()), this, SIGNAL(accept())); connect(&m_dialog, SIGNAL(rejected()), this, SIGNAL(reject())); } diff --git a/src/widgets/qquickqfontdialog.cpp b/src/widgets/qquickqfontdialog.cpp index 6d637e1d..6936aff7 100644 --- a/src/widgets/qquickqfontdialog.cpp +++ b/src/widgets/qquickqfontdialog.cpp @@ -56,8 +56,8 @@ public: QFontDialogHelper() : QPlatformFontDialogHelper() { - connect(&m_dialog, SIGNAL(currentFontChanged(const QFont &)), this, SIGNAL(currentFontChanged(const QFont &))); - connect(&m_dialog, SIGNAL(fontSelected(const QFont &)), this, SIGNAL(fontSelected(const QFont &))); + connect(&m_dialog, SIGNAL(currentFontChanged(QFont)), this, SIGNAL(currentFontChanged(QFont))); + connect(&m_dialog, SIGNAL(fontSelected(QFont)), this, SIGNAL(fontSelected(QFont))); connect(&m_dialog, SIGNAL(accepted()), this, SIGNAL(accept())); connect(&m_dialog, SIGNAL(rejected()), this, SIGNAL(reject())); } @@ -166,8 +166,8 @@ QPlatformFontDialogHelper *QQuickQFontDialog::helper() if (!m_dlgHelper) { m_dlgHelper = new QFontDialogHelper(); - connect(m_dlgHelper, SIGNAL(currentFontChanged(const QFont &)), this, SLOT(setFont(const QFont &))); - connect(m_dlgHelper, SIGNAL(fontSelected(const QFont &)), this, SLOT(setFont(const QFont &))); + connect(m_dlgHelper, SIGNAL(currentFontChanged(QFont)), this, SLOT(setFont(QFont))); + connect(m_dlgHelper, SIGNAL(fontSelected(QFont)), this, SLOT(setFont(QFont))); connect(m_dlgHelper, SIGNAL(accept()), this, SLOT(accept())); connect(m_dlgHelper, SIGNAL(reject()), this, SLOT(reject())); } diff --git a/src/widgets/qquickqmessagebox.cpp b/src/widgets/qquickqmessagebox.cpp index 1b92efc5..5d734011 100644 --- a/src/widgets/qquickqmessagebox.cpp +++ b/src/widgets/qquickqmessagebox.cpp @@ -134,8 +134,8 @@ QPlatformDialogHelper *QQuickQMessageBox::helper() // dismissed by closing the window rather than by one of its button widgets. connect(helper, SIGNAL(accept()), this, SLOT(accept())); connect(helper, SIGNAL(reject()), this, SLOT(reject())); - connect(helper, SIGNAL(clicked(QMessageDialogOptions::StandardButton, QMessageDialogOptions::ButtonRole)), - this, SLOT(click(QMessageDialogOptions::StandardButton, QMessageDialogOptions::ButtonRole))); + connect(helper, SIGNAL(clicked(QMessageDialogOptions::StandardButton,QMessageDialogOptions::ButtonRole)), + this, SLOT(click(QMessageDialogOptions::StandardButton,QMessageDialogOptions::ButtonRole))); } return QQuickAbstractMessageDialog::m_dlgHelper; |