summaryrefslogtreecommitdiff
path: root/src/dialogs/qquickfiledialog_p.h
diff options
context:
space:
mode:
authorShawn Rutledge <shawn.rutledge@digia.com>2014-04-09 14:07:15 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-04-15 17:47:28 +0200
commit6d438f3b5ca9fd94889461ca481bba387904af94 (patch)
tree48f2982c0a896257e2d422ee577f32b2b594821f /src/dialogs/qquickfiledialog_p.h
parentf42ef1db6a111fd420776da2c620be9cefba7f14 (diff)
downloadqtquickcontrols-6d438f3b5ca9fd94889461ca481bba387904af94.tar.gz
Dialogs: implementation prop renamed to contentItem; API cleanup
- contentItem is a common name for an item inside something such as a window or a flickable. We now consider it adequate API that you can directly set this to some item which you want to fill the whole dialog instead of adding an item as a child of the default property and being subject to the dialog's margins and space reservation for buttons. - contentItem MUST be an Item. Allowing the old "implementation" property to alternatively be a ready-made Window was just a hypothetical use case, but if anyone made use of that, then it would be a problem to have that kind of dialog on a GUI that cannot have windows (such as Android or EGLFS). So there's no point in having the possibility as long as we cannot emulate windows as items. - standardButtonsRightModel and standardButtonsLeftModel are implementation details so they should not be exposed as properties which Creator can discover; users shouldn't depend on them. Task-number: QTBUG-38056 Change-Id: Iefa3def314353495cfe8d1ef9f775a8e46d5bcf4 Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Diffstat (limited to 'src/dialogs/qquickfiledialog_p.h')
-rw-r--r--src/dialogs/qquickfiledialog_p.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/dialogs/qquickfiledialog_p.h b/src/dialogs/qquickfiledialog_p.h
index 0cfef472..1d2f37ab 100644
--- a/src/dialogs/qquickfiledialog_p.h
+++ b/src/dialogs/qquickfiledialog_p.h
@@ -62,9 +62,9 @@ QT_BEGIN_NAMESPACE
class QQuickFileDialog : public QQuickAbstractFileDialog
{
Q_OBJECT
- Q_PROPERTY(QObject* implementation READ qmlImplementation WRITE setQmlImplementation DESIGNABLE false)
+ Q_PROPERTY(QQuickItem* contentItem READ contentItem WRITE setContentItem DESIGNABLE false)
Q_PROPERTY(QJSValue shortcuts READ shortcuts CONSTANT)
- Q_CLASSINFO("DefaultProperty", "implementation") // AbstractFileDialog in QML can have only one child
+ Q_CLASSINFO("DefaultProperty", "contentItem") // AbstractFileDialog in QML can have only one child
public:
explicit QQuickFileDialog(QObject *parent = 0);