summaryrefslogtreecommitdiff
path: root/src/controls/TabView.qml
diff options
context:
space:
mode:
authorSimon Hausmann <simon.hausmann@digia.com>2014-01-06 15:41:03 +0100
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-01-08 13:20:18 +0100
commitc549c7795884d1e858aa7963a550b74c76a2f02d (patch)
treee0c0b6c3b57210d1a20fee34ab0c30046402c326 /src/controls/TabView.qml
parentc76129020bc229c6dfeadbf1db7aae13b5cb84d8 (diff)
downloadqtquickcontrols-c549c7795884d1e858aa7963a550b74c76a2f02d.tar.gz
Remove workaround for ownership issue with newly created tabs
The workaround for specifying the loader as a parent for newly created tabs can be removed, now that QTBUG-35913 is fixed and the visual parent ensures that its visual children stay alive. Change-Id: Ide3fc79c7a7465bd585bfd2bc66de4389aa7bc1d Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Diffstat (limited to 'src/controls/TabView.qml')
-rw-r--r--src/controls/TabView.qml4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/controls/TabView.qml b/src/controls/TabView.qml
index e20bcf22..fb31ca67 100644
--- a/src/controls/TabView.qml
+++ b/src/controls/TabView.qml
@@ -95,9 +95,7 @@ FocusScope {
Returns the newly added tab.
*/
function insertTab(index, title, component) {
- // 'loader' parent is a pending workaround while waiting for:
- // https://codereview.qt-project.org/#change,65788
- var tab = tabcomp.createObject(loader)
+ var tab = tabcomp.createObject()
tab.sourceComponent = component
tab.title = title
// insert at appropriate index first, then set the parent to