diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2013-01-25 13:39:28 -0800 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-01-25 22:48:56 +0100 |
commit | a45d35c07f9eed27fc286ab5fbc00789d45259b5 (patch) | |
tree | 46cd28b8d77279055e7eecbd11777e946f5356f1 /src/multimedia/audio/qaudiosystemplugin.h | |
parent | 35393a6469a5d886c415e947be788b206c7ea76d (diff) | |
download | qtmultimedia-a45d35c07f9eed27fc286ab5fbc00789d45259b5.tar.gz |
Add virtual destructors to two classes with other virtuals
Classes with virtuals are used polymorphically (why have virtuals
otherwise?), so they need virtual destructors to be deleted
properly. Unless they are never deleted using objects of those two
classes -- but why have the interface in the first place if that's the
case?
This is binary incompatible change. It was agreed upon in the mailing
list.
Change-Id: I697e4bd53251452a0e6b0c09edd08c4835f90cbd
Discussed-on: http://lists.qt-project.org/pipermail/development/2012-December/008908.html
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Diffstat (limited to 'src/multimedia/audio/qaudiosystemplugin.h')
-rw-r--r-- | src/multimedia/audio/qaudiosystemplugin.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/multimedia/audio/qaudiosystemplugin.h b/src/multimedia/audio/qaudiosystemplugin.h index 7a8a4606a..b2e1dd17b 100644 --- a/src/multimedia/audio/qaudiosystemplugin.h +++ b/src/multimedia/audio/qaudiosystemplugin.h @@ -66,6 +66,7 @@ struct Q_MULTIMEDIA_EXPORT QAudioSystemFactoryInterface virtual QAbstractAudioInput* createInput(const QByteArray& device) = 0; virtual QAbstractAudioOutput* createOutput(const QByteArray& device) = 0; virtual QAbstractAudioDeviceInfo* createDeviceInfo(const QByteArray& device, QAudio::Mode mode) = 0; + virtual ~QAudioSystemFactoryInterface(); }; #define QAudioSystemFactoryInterface_iid \ |