diff options
| author | Yoann Lopes <yoann.lopes@theqtcompany.com> | 2015-03-18 16:08:56 +0100 |
|---|---|---|
| committer | Yoann Lopes <yoann.lopes@theqtcompany.com> | 2015-03-24 16:03:25 +0000 |
| commit | d046bc67c74fef252cb213b8b9d5a1ab55f862e2 (patch) | |
| tree | 61b5fcd6f44eb484301336312ac160e3ba5c4985 | |
| parent | 4f7e5bf169868dfd0428a7f966e51dcac5a50178 (diff) | |
| download | qtmultimedia-d046bc67c74fef252cb213b8b9d5a1ab55f862e2.tar.gz | |
GStreamer: don't use ximagesink in QGstreamerVideoWidget.
When xvimagesink is not available, we were falling back to ximagesink.
That element doesn't provide some important features: it doesn't scale
frames to the window size and doesn't support brightness, contrast, hue
and saturation adjustments. That kind of makes it useless, at least
on its own. We would need to use at least a 'videoscale' element
together with it to have it working properly.
We're better off letting QVideoWidget fall back to QVideoRendererControl
when xvimagesink is not available.
Change-Id: Ic8c62fbefa3227430e3bae24630c8b3944aabb47
Reviewed-by: Christian Stromme <christian.stromme@theqtcompany.com>
| -rw-r--r-- | src/gsttools/qgstreamervideowidget.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/gsttools/qgstreamervideowidget.cpp b/src/gsttools/qgstreamervideowidget.cpp index 496018748..b26369a96 100644 --- a/src/gsttools/qgstreamervideowidget.cpp +++ b/src/gsttools/qgstreamervideowidget.cpp @@ -95,9 +95,6 @@ QGstreamerVideoWidgetControl::QGstreamerVideoWidgetControl(QObject *parent) { m_videoSink = gst_element_factory_make ("xvimagesink", NULL); - if (!m_videoSink) - m_videoSink = gst_element_factory_make ("ximagesink", NULL); - if (m_videoSink) { // Check if the xv sink is usable if (gst_element_set_state(m_videoSink, GST_STATE_READY) != GST_STATE_CHANGE_SUCCESS) { |