DirectShow: Don't seek if playback is stopped

If the playback is already stopped, and after that
new position is requested twice, e.g.
stop();
setPosition(0);
setPosition(0);

this causes the playback to start.

Need to postpone setting of new position until play is requested.

Also no need to emit positionChanged when position is not changed.

Fixes: QTBUG-68778
Change-Id: Ib62942ee155d9c8ed2310132dcc6b501dfef1a04
Reviewed-by: Christian Strømme <christian.stromme@qt.io>

1 files changed, 5 insertions, 3 deletions

diff --git a/src/plugins/directshow/player/directshowplayercontrol.cpp b/src/plugins/directshow/player/directshowplayercontrol.cpp
index 14f272f17..87bd53bc4 100644
--- a/src/plugins/directshow/player/directshowplayercontrol.cpp
+++ b/src/plugins/directshow/player/directshowplayercontrol.cpp
@@ -102,9 +102,11 @@ void DirectShowPlayerControl::setPosition(qint64 position)
         emit mediaStatusChanged(m_status);
     }
 
-    if (m_state == QMediaPlayer::StoppedState && m_pendingPosition != position) {
-        m_pendingPosition = position;
-        emit positionChanged(m_pendingPosition);
+    if (m_state == QMediaPlayer::StoppedState) {
+        if (m_pendingPosition != position) {
+            m_pendingPosition = position;
+            emit positionChanged(m_pendingPosition);
+        }
         return;
     }