diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-11-06 16:13:14 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-11-06 18:56:47 +0000 |
| commit | 05a58a81db51564f93397dcf8f7cd37c8d4d1a9d (patch) | |
| tree | 96895e931c5fee2861203907020faec4fc36f762 | |
| parent | cce3e8a019a3272ff422b1cdb1ce11bb7b00feea (diff) | |
| download | qtmultimedia-05a58a81db51564f93397dcf8f7cd37c8d4d1a9d.tar.gz | |
DirectShow: Fix compiler warnings
Fix:
player\directshowiosource.cpp:100:22: warning: unused variable 'count' [-Wunused-variable]
static const int count = sizeof(directshow_subtypes) / sizeof(GUID);
player\directshowplayerservice.cpp: In member function 'virtual QMediaControl* DirectShowPlayerService::requestControl(const char*)':
player\directshowplayerservice.cpp:237:27: warning: 'filter' may be used uninitialized in this function [-Wmaybe-uninitialized]
setVideoOutput(filter);
Change-Id: I0a9098db182d3954d50d5b23ca00424ee691f60d
Reviewed-by: Christian Stromme <christian.stromme@qt.io>
| -rw-r--r-- | src/plugins/directshow/player/directshowiosource.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/directshow/player/directshowplayerservice.cpp | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/plugins/directshow/player/directshowiosource.cpp b/src/plugins/directshow/player/directshowiosource.cpp index 31e9a1300..d5833fafc 100644 --- a/src/plugins/directshow/player/directshowiosource.cpp +++ b/src/plugins/directshow/player/directshowiosource.cpp @@ -97,8 +97,6 @@ DirectShowIOSource::DirectShowIOSource(DirectShowEventLoop *loop) 0, // pbFormat }; - static const int count = sizeof(directshow_subtypes) / sizeof(GUID); - for (const auto &directshowSubtype : directshow_subtypes) { type.subtype = directshowSubtype; m_supportedMediaTypes.append(DirectShowMediaType(type)); diff --git a/src/plugins/directshow/player/directshowplayerservice.cpp b/src/plugins/directshow/player/directshowplayerservice.cpp index 27108063d..08d99d735 100644 --- a/src/plugins/directshow/player/directshowplayerservice.cpp +++ b/src/plugins/directshow/player/directshowplayerservice.cpp @@ -216,7 +216,7 @@ QMediaControl *DirectShowPlayerService::requestControl(const char *name) } } else if (qstrcmp(name, QVideoWindowControl_iid) == 0) { if (!m_videoRendererControl && !m_videoWindowControl) { - IBaseFilter *filter; + IBaseFilter *filter{}; #if QT_CONFIG(evr) if (!qgetenv("QT_DIRECTSHOW_NO_EVR").toInt()) { |