| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
The test passes locally and has XPASSed in CI as well.
Change-Id: I27b0041a3233793827cc3dd7271e6def7482e714
Reviewed-by: Doris Verria <doris.verria@qt.io>
|
|
|
|
|
|
|
|
|
| |
Our ARM macOS machines in CI might not be configured correctly. Ignore
them for now.
Pick-to: 6.2
Change-Id: Id3b4554c3795283d38b731a0a2c30f409cb25d9b
Reviewed-by: Doris Verria <doris.verria@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Make containers const where they obviously should be, iterate over
references where it's clearly possible.
Cherry-pick of 2c8c5dca44aba5612cc67b04dd3c7e5fc4919b19.
Change-Id: Ie55a58873b48bbb60ac49790db612f85777e6ceb
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
| |
They pass locally on macOS, so perhaps they only won't work on iOS.
Change-Id: I79f59e4c67aca8842ae18e8cf5a237c3976bb3d1
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
| |
Qt Quick changes to flicking/panning behavior seem to break this test.
Change-Id: I5f79355addde3a2d0815142dd9b035080b7d46e8
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
| |
Change-Id: If98f86af595d2b05bbed28f10fbbc5e056f5c56e
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
|
|
|
|
|
|
|
|
| |
The nokia geoservice plugin is linked in, which already defines the
relevant symbols.
Change-Id: I58ac5b268b2aa2c2dcb0d46ae83b3502daea60fa
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Replace various deprecated APIs with their supported Qt 6 versions.
Most notably, replace QScopedPointer with std::unique_ptr, as the
code frequently use deprecated QScopedPointer::swap.
Change-Id: If9cb0be89423fd310073709eb390401d74240153
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
| |
This commit re-enables all QML-related unit tests.
Task-number: QTBUG-96795
Change-Id: I43f5e8b7d7cadc9e4ea975275b5154a499eeabb4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://doc.qt.io/qt-6/qtpositioning-changes-qt6.html#c
This is part of a bigger work to port QtLocation maps to Qt6.
Task-number: QTBUG-96795
Change-Id: I9c14bd39d2da95a0be6542be432b79e26906c5ed
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build src/location/maps and src/location/places with a minimum subset
of required src/location/declarativemaps files.
Also build all plugins except mapbox-gl.
Enable all non-QML unit-tests.
Task-number: QTBUG-97769
Change-Id: I7c70584376c688efd2e1d046186732a7399e12d9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that our CI does not support repos without
any tests. This is treated like an error and leads to
integration failure.
This patch fixes it by disabling tests in
coin/module_config.yaml. This config should be fixed
when QtLocation tests are enabled
Pick-to: 6.2
Task-number: QTBUG-97084
Change-Id: Ib06e865fe2836806bbbee34345f06b471dd48660
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed for subsequent change that will check and error out if the
version is lower than 3.16. We do that to ensure all policies
introduced by CMake up to version 3.16 have their behavior set to
NEW.
Pick-to: 6.2
Task-number: QTBUG-95018
Change-Id: I19e81ab7d8fd570a32aa9181799d77a2eea73ab8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inspired by CodeChecker warning about dead code.
Fix some copy-paste issues which could lead to incorrect shortest
path estimation when it crosses the -180/180 degree line.
As a drive-by: remove the unneeded initialization of a variable, that
is anyway initialized later. Just to silence another CodeChecker
warning.
Pick-to: 6.2
Change-Id: I9ebd5900a5ca331ef5846a06cf6415a2f1093400
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interpolation for the West and East directions were actually
confused. When the CoordinateAnimaion.East direction was selected, the
interpolation was done in West direction and vice versa.
This patch fixes the issue.
[ChangeLog][CoordinateAnimation][Important Behavior Change] The value
of direction property for CoordinateAnimation is now handled correctly.
Previously the values were confused, so specifying
CoordinateAnimation.East direction was actually leading to moving West
and vice versa.
Pick-to: 6.2
Change-Id: I8e73fc4ad5cabd80bca38c624c70919e54c55127
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The qt6_qml_type_registration() command will become internal. Update
the examples, tests and docs to no longer call this command and use
the new QML CMake API available from Qt 6.2 instead.
Task-number: QTBUG-95093
Pick-to: 6.2
Change-Id: Ibd62ccb4e2723a64d8a2c4418982037419d19855
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes the "Bundled_Clip2Tri not found" error during static
QtPositioning build.
Fix backend plugins so that they get automatically linked in static
build.
Fixes: QTBUG-95582
Pick-to: 6.2
Change-Id: Iea31c23a055689d9b8f6471345558b330795f597
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-95170
Pick-to: 6.2
Change-Id: I041d949a1b5d3097f756befb1d03ed3734665f82
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
| |
Amends bc9ddc25379b969b8e751a192ba66093a7b7dbc2
Pick-to: 6.2
Task-number: QTBUG-90819
Change-Id: I91d61a86d7ea79b371de7586b3406bd3b3d3c66b
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Applying qRound() to check if the minutes/seconds should overflow was
not the right solution in some cases. It could lead to incorrect
overflows, and so - to wrong conversion results.
The actual logic of overflow is related to the behavior of QString::number.
This patch fixes the logic and also introduces some minor optimizations.
After overflow, the minutes or seconds value is always 0.0, because
the actual minutes/seconds value is always in range [0; 60). This allows
us to get rid of some checks.
Fixes: QTBUG-95221
Pick-to: 6.2 5.15
Change-Id: Ie3dcb6cef226b04c43dd973c09c4ae297c583f3b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: I6b867a27095c26dbc803609b7d0da6d23cd46249
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: I837faa1ae9ebcfb0fba170dbfcc0dbd5be2d8fc2
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds qHash overloads to QGeoShape hierarchy, allowing to use
the classes as keys in QHash.
Note that the actual qHash overload is required only for the base type.
All the derived classes are correctly hashed using the virtual method
in private d_ptr.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: I186f9d396e698187ebf0363d96c19e324db10905
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add move-constructor and move-assignment operator, as well as a swap
method. Specialize the type as shared using Q_DECLARE_SHARED.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: Idcb42414b3d60526e7cd55ea3ead53324c7cbc58
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add move-constructor and move-assignment operator, as well as a swap
method. Specialize the type as shared using Q_DECLARE_SHARED.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: Ie5e3bd319f9386c7e864122994a5dbcf0fb81240
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add move-constructor and move-assignment operator, as well as a swap
method. Specialize the type as shared using Q_DECLARE_SHARED.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: I6ed041c54c9979d90b475c1d98806b5912220fc2
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes all streaming operators in QtPositioning to
hidden friends, so that they can be found only by ADL and do not
pollute the global namespace.
It also updates couple of tests to make sure that we cover the
streaming operators with test cases.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: Ie78b31301d9fb6f658e82114d9637b197e72710a
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][QtPositioning][QGeoAreaMonitorSource] Add virtual methods
to set and get custom parameters. Helps to configure and control
backend-specific behavior at runtime.
Task-number: QTBUG-95163
Pick-to: 6.2
Change-Id: I77bac8336ec6c7398a98047c8b557e3480106ce4
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were two problems:
1. The deserialization method was still assuming that QList uses int to
index the elements, so it tried to extract the polygon and path size
as int, while it was serialized as qsizetype.
2. The QGeoPath didn't serialize and deserialize its width - it was
simply lost.
This patch fixes both problems and adds some unit-tests to cover these
cases.
Pick-to: 6.2
Change-Id: If0ac87731b4481fde6b91e71fb121b3e916b0bfe
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are several bugreports regarding this test being flaky. They all
are old, and the test is quite stable now.
Still we can increase the timeout without breaking the test logic.
This will make the test even more stable under high CI load.
Fixes: QTBUG-57678
Fixes: QTBUG-83077
Pick-to: 6.2
Change-Id: If973c96750cfb079c076c47bcf4d0828a04c3e01
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-73055
Pick-to: 6.2
Change-Id: Ie485af90ee9abea64aaf29a3402c761c99e10ede
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8559b1ee70bfbcd47467d1bf53ec5bb5f011d7de.
Commit 477bf208ce39cfd0427f16fe26f4f02119262928 updates the
dependencies, so that now we have a propert revision of
qtdeclarative with the fixes for the broken test. The test can
be unblacklisted.
Task-number: QTBUG-93983
Change-Id: Ib169b7b778185a1595069b3d3632c0fdd7d83c0e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-93983
Change-Id: I2aa140a3f4247e9eb72da8b6be7efffb128b9900
Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests for QGeoPositionInfoSource and QGeoSatelliteInfoSource had
the updated intervals of 7000 msec and more. According to the comments
in the code, initially it was caused by the symbian emulator, that had
a minimumUpdateInterval of 5000 msec. Currently this emulator is not
used in our CI, and the minimumUpdateInterval for all existing plugins
is not greater than 1000 msec.
This patch reduces all the intervals, which allows to reduce the total
test execution time by more than 3 times (from 930+ seconds to around
270 seconds on my local machine).
Note: this patch does not change the timeouts in the
QTRY_*_WITH_TIMEOUT calls, because they do not always stay blocked for
the whole specified timeout. Keeping large timeouts will prevent the
tests from flaky failing due to I/O operations being slow in case of
high CI load.
Fixes: QTBUG-93030
Change-Id: I0fac431448b435302dec050a9448d31e1345b287
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Minimum update interval is reduced to 200ms instead of 1 second. This
allows to save some time on running the unit tests.
Task-number: QTBUG-93030
Change-Id: I85cbac0fed49fc58059ed40461a386c694c5f73f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QGeoAreaMonitorPolling class overrides QObject::connectNotify() and
QObject::disconnectNotify() to check, if it has any connected objects
and decide, if it needs to start/stop position monitoring.
Previously it used QObject::isSignalConnected() to perform the check.
However this method locks a QObject's mutex, so it's not safe to call
it from QObject::disconnectNotify(), because the latter is called
from a QObject's destructor, which is also locking a QObject's mutex.
Both locks use signalSlotLock static method from qobject.cpp to
determine, which mutex to lock. The selection is made based on the
object's address. At some rare case this can lead to selecting the
same mutex. And as a result we get a deadlock, when trying to lock
the same mutex for the second time.
This patch updates the logic of the overridden methods in
QGeoAreaMonitorPolling. They do not use the
QObject::isSignalConnected() method, but implement a custom solution
to track the number of connections. This solution requires
synchronization, because connectNotify() and disconnectNotify() can
be triggered from different threads.
Fixes: QTBUG-93420
Fixes: QTBUG-91434
Change-Id: I45ba03e238edc136f1bb42ca6b11a528ab5c22e8
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tst_QGeoAreaMonitorSource test can randomly hang on some CI
configurations (gcc-armv7 and new macOS 11.1 arm). It heavily
uses the LogFilePositionSource, which reads NMEA data from file.
This patch is an attempt to minimize file I/O by reading the file
only once, and providing the cached file contents to the position
source instance using QList<QByteArray>.
This minimizes file I/O for the test, and also allows to tune
the timeouts to reduce the total execution time.
Task-number: QTBUG-91434
Change-Id: Id83647aee71d8435ea60c2f07a52790a3fc28e34
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
| |
This patch introduces binding support for "active" property
Task-number: QTBUG-89874
Change-Id: Idcfba6012743b43e168a423e8adf7eee3ec94ace
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit ports most of the properties in QDeclarativePositionSource
to new property system.
* "active" property will be corever in the next patch.
* "updateInterval" and "preferredPositioningMethods" properties are not
converted to bindables because they have custom getters and setters,
which makes the code for porting them complicated and adds memory
overhead. However these properties are normally set once and not
updated, so there is no real benefit from converting them.
Task-number: QTBUG-89874
Change-Id: If087405c4515725ba304dd18a880cb25fbad20c0
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-93761
Change-Id: Ia8634b52f8a9e9e0832fccda40f0c0448d1e808d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When introducing a dummy.source plugin for the tests, the priority was
selected the same, as for the test.source plugin. As a result, the
algorithm for selecting the default source during the test run could
pick any of them. When dummy.source was picked, the
preferredMethodsBinding test could not execute correctly, because the
dummy.source has different supported positioning methods.
This patch fixes the problem in 2 ways:
* test.source is now directly selected in the preferredMethodsBinding()
test
* the priorities of the dummy.source and test.source plugins are
adjusted in such a way, that test.source is picked if
createDefaultSource() call is used.
Change-Id: Ibec456f4679207a161c2cf97c267055d75bbd03c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Also introduced a couple of documentation fixes
Task-number: QTBUG-89874
Change-Id: Icb902784378cf2847c6a5dab23dbf1acbb228e8a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Signals of QDeclarativeGeoLocation class are removed
because they were only needed for QML. With the new
bindable properties we do not need them any more.
Task-number: QTBUG-89874
Change-Id: I084fbde129d0bf3a1d7ad496f7fa25274593989f
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-89874
Change-Id: I5d390cdea5189eda09d58b4e3bdac412f669bd91
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic of active state updates was broken.
For example, calling update() and then stop() was immediately switching
to inactive state, while the position source was still waiting for a
single position request to complete.
This patch fixes this and some other logic errors and adds several unit
tests to cover different scenarios of calling these methods.
Change-Id: I5cea19c711744a1b57dd0427a41119d789f4033b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-89874
Change-Id: I390119d8f25d5523b879ac0c7eecd32cb04481d8
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Signals of QDeclarativePosition class are removed because they
were only needed for QML. With the new bindable properties we
do not need them any more.
[ChangeLog][QtPositioning][Position] horizontalAccuracy and
verticalAccuracy properties are no longer writable. This is
done to align with the other properties of the class, which
are read-only. There is no real usecase for making them
writable.
Task-number: QTBUG-89874
Change-Id: I9d14ce8c558c7b50d1e1dd8a46a599cdd4811f5b
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Extend the QML tests to check the bindings. Required to make sure
that we do not break the behavior during migrating to new property
binding system.
Task-number: QTBUG-89874
Change-Id: I140b07a05944a30d5dbca910b015e3c00bc9e587
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
|
|
|
|
|
|
|
|
|
| |
This patch also introduces some basic unit-tests for
QGeoCoordinateObject
Task-number: QTBUG-89874
Change-Id: Id6df04fab4368658db10645bb8a667ec5f7ab3b0
Reviewed-by: Sona Kurazyan <sona.kurazyan@qt.io>
|
|
|
|
|
|
| |
Change-Id: I2bc2775478f94f283d1d8863e9821255ccdaf79b
Reviewed-by: Juha Vuolle <juha.vuolle@insta.fi>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|