summaryrefslogtreecommitdiff
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Blacklist declarative_core::Place::test_emptyPlace() and test_saveload()Liang Qi2017-12-061-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Try to get qt5 dev integrated without qtdeclarative 5.10->dev merge. Perhaps the issue is gone when that merge landed later. Task-number: QTBUG-64986 Change-Id: Ic258fd87769ed7e299b8fdfd5536464a4f1001a4 Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
| * | | Introduce WaypointPaolo Angelelli2017-11-302-5/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch replaces QGeoCoordinate with Waypoint as mean to specify waypoints in a RouteQuery. This patch also adds a new invokable to RouteQuery, waypointObjects, to return QDeclarativeGeoWaypoints instead of QGeoCooordinates. NOTE: If, by 5.11, support to perform implicit conversions in method invocations based on converters registered in the metatype system will be added, this method could/should be removed, and QDeclarativeGeoWaypoint objects should be return as QVariants from the waypoints() getter, as they could be used in place of QGeoCoordinate when passing them as arguments. Task-number: QTBUG-64066 Change-Id: I77747f53cdcbabe6430580b60fa59d4afe8c650a Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * | | Allow to specify extra parameters in RouteQuery using MapParametersPaolo Angelelli2017-11-292-2/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch works on top of the previous one, and passes the content of the map parameters as a QMap<QString, QVariantMap>, where the key is the parameter type and the value is a map<property name, property value> of all properties of the map parameter except for the property "type". To achieve this, a new list property, quickChildren, has been added to RouteQuery, to pick up Map Parameters declared inside the query Change-Id: I364f5438e8f4cfc42430bfe448d96519c407eb74 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * | | Enable previously disabled tests due to unsupported QList<int> in QMLPaolo Angelelli2017-11-291-19/+11
| | | | | | | | | | | | | | | | | | | | Change-Id: I27002d3703b34fb27befa493a680b7c2befe0ac0 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * | | Implement QGeoCodingManagerEngineMapboxBruno de Oliveira Abinader2017-11-291-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements QtLocation's Geocoding functionality, providing forward and reverse geocoding based on Mapbox web services APIs [1]. New 'mapbox' plugin features: - "OnlineGeocodingFeature" - "ReverseGeocodingFeature" - "LocalizedGeocodingFeature" [1] https://www.mapbox.com/api-documentation Change-Id: Icaaf06373bd5c2b5abc5aed3cea46364664cae8f Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
| * | | Implement QPlaceManagerEngineMapboxBruno de Oliveira Abinader2017-11-291-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements QtLocation's Places functionality, providing points of interests (POIs) support based on Mapbox web services APIs [1]. New 'mapbox' plugin features: - OnlinePlacesFeature - PlaceRecommendationsFeature - SearchSuggestionsFeature - LocalizedPlacesFeature Place icons are kindly provided via Mapbox Maki under CC0 license [2]. [1] https://www.mapbox.com/api-documentation [2] https://www.mapbox.com/maki Change-Id: Ice51abe184908250f584a9c08f70d28e95c30683 Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
| * | | Merge remote-tracking branch 'origin/5.10' into devLiang Qi2017-11-202-3/+25
| |\ \ \ | | |/ / | | | | | | | | Change-Id: I9adfdf056dd04f33e9fbd01bcb2ca2ad75e95007
| | * | Update to new QRandomGenerator APIv5.10.0-beta4Thiago Macieira2017-11-031-3/+3
| | | | | | | | | | | | | | | | | | | | Change-Id: I69f37f9304f24709a823fffd14e676c097712329 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| | * | Merge remote-tracking branch 'origin/5.9' into 5.10v5.10.0-beta3Liang Qi2017-10-261-0/+22
| | |\ \ | | | |/ | | | | | | | | | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I9a3d7ec0bb203ac8b5bd483af3973510ca33c4a9
| | | * Fix Map.fromCoordinate returning wrong values during tiltingPaolo Angelelli2017-09-211-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-63251 Change-Id: I7ceeeebb30007c5d97d61e057c8ec6e827177b19 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
| * | | Allow to specify extra parameters in QGeoRouteQueryPaolo Angelelli2017-11-132-0/+28
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These parameters should be in the form of a QMap<QString, QVariantMap>, where the key is the parameter type, and the value is a map of <property name, property value>. These parameters are supposed to be backend specific, and documented per-plugin. Change-Id: I180b67900b58b933b31bf2efd96842e345df2387 Reviewed-by: Bruno de Oliveira Abinader <brunoabinader@gmail.com> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * | Merge remote-tracking branch 'origin/5.9' into 5.10v5.10.0-beta1Paolo Angelelli2017-09-111-14/+2
| |\ \ | | |/ | | | | | | Change-Id: Ibcf748d5f0d172ad5c77bdcd41806009ff6914e3
| | * Remove HERE plugin from testsPaolo Angelelli2017-09-091-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | It keeps causing errors saying that host requires autentication, every now and then. Change-Id: I9fc96aee8793ca865cbcc88c7340f2363d08fc1f Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | | Fix enabling polymorphic pimpl in QGeoRoute/Segment/ManeuverPaolo Angelelli2017-10-197-5/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change 8ac6377e62af803b567449cdf30c669b92114cc4 allowed to subclass private implementations of these 3 classes. However, the pimpl was kept in a QExplicitlySharedDataPointer for the first two, and QSharedDataPointer for the last class. Failing to specialize the clone method of the pointer would result in incorrect detach behavior, which would however only be visible with the third class (the first two never call detach() internally, and the line QEXPECT_FAIL("", "QGeoRoute equality operators broken", Continue); in the tests make it clear. This change also adds the equals virtual method also to QGeoRouteSegment and QGeoManeuver private implementations. Change-Id: If51dafebb19e4cb2d1bcf40c2b6f136f804198e0 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | | Merge remote-tracking branch 'origin/dev' into wip/navigationPaolo Angelelli2017-09-117-11/+51
|\ \ \ | |/ / | | | | | | Change-Id: I764e0c54168b4d4f4fc029d69a10e915332c457d
| * | Merge remote-tracking branch 'origin/5.9' into devPaolo Angelelli2017-08-273-1/+37
| |\ \ | | |/ | | | | | | | | | | | | | | | Conflicts: tests/auto/geotestplugin/qgeotiledmappingmanagerengine_test.h Change-Id: I4940db79ebe500ff7e37ded42c7d29d7ccfb6253
| | * Fix PluginParameter not working with script as property valuesPaolo Angelelli2017-08-233-1/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch introduces the undocumented QDeclarativeGeoServiceProviderParameter::initialized signal, to signal to the parent when a parameter becomes fully initialized, so that the parent QDeclarativeGeoServiceProvider can attach. Task-number: QTBUG-62075 Change-Id: Ie3615abf31d19f39587c5e54b202f8f2c4a711cc Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
| * | Enable tests for boot2qtSami Nurmenniemi2017-08-154-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tests for boot2qt were disabled with commit cc7fb64d321c4884caee0cfd29bd2de0b1b3eaeb. The tests can be enabled since qtdeclarative now fallbacks to software renderer if OpenGL is not supported. Also some timings needed to be relaxed for the tests to pass when running on Qemu. Task-number: QTBUG-60268 Change-Id: I8f933511c956b728a76870231a58ed89398a75ba Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
* | | Make QGeoRoute extensiblePaolo Angelelli2017-08-242-32/+93
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes it possible to subclass QGeoRoute, QGeoRouteSegment or QGeoRouteManeuver, with custom private implementations. It also attempts to minimize the cost that creating a QDeclarativeGeoRoute currently has, by deferring the initialization of QDeclarativeGeoRoute::segments_ to the first access, and also populating the list only to the requested point. Change-Id: I4c87391bcc380ddca6523c748ebb97d2a44ed9d2 Reviewed-by: BogDan Vatra <bogdan@kdab.com>
* | Merge remote-tracking branch 'origin/5.9' into devPaolo Angelelli2017-08-102-6/+47
|\ \ | |/ | | | | | | | | | | Conflicts: tests/auto/declarative_ui/tst_map.qml Change-Id: If408b8242b39f78926b5373393f3b1f65b262499
| * Fix visible region computation in QGeoProjectionWebMercatorPaolo Angelelli2017-08-091-0/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the visible region is calculated as the intersection between the viewing frustum and the map plane clipped against the map extended rectangle in mercator space (from -1 to 2 in x coords, 0 to 1 in y coords). The result is correct in the extended mercator space. However, this may lead to overlapping coordinates when converted back to latitude and longitude. For this reason, this patch changes the clipping geometry to be the map un-extended rectangle centered around the current map center. The result is a geometry that never wraps around or overlaps, thus removing the need for handling separately the case when the map is fully visible when returning the visible region. Task-number: QTBUG-57690 Change-Id: I8396c40a123ce94bff4388dfefbd8a694657b8bd Reviewed-by: BogDan Vatra <bogdan@kdab.com>
| * Fix MapFlick::test_flick_diagonal autotestPaolo Angelelli2017-08-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | init() is currently setting zoomLevel to 0. This prevents the map from flicking diagonally as there's no room for that when the map is fully visible vertically. This test is currently passing in CI for unclear reasons, but it's failing locally. Change-Id: I0bb7c703a6cd2d4b5f440ce629c3933cf41268f6 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add invokables to add/remove mapItemViewsPaolo Angelelli2017-08-071-0/+77
| | | | | | | | | | | | | | | | | | | | | | | | This patch adds two new methods to QDeclarativeGeoMap, to allow users to add or remove MapItemViews at runtime. [ChangeLog][QtLocation][Map] Added methods to add or remove MapItemViews at runtime. Task-number: QTBUG-55782 Change-Id: I4e612a9476a864331f61d49dac811a8069ae010f Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add QGeoPolygon to QtPositioningPaolo Angelelli2017-08-043-0/+411
| | | | | | | | | | | | | | | | | | | | | | This patch introduces a new QGeoShape, QGeoPolygon, together with helper functions in the location singleton (QtPositioning.*) to create and convert geopolygons from QML. [ChangeLog][QtPositioning][QGeoPolygon] Added QGeoPolygon shape. Change-Id: I111c576d7428f2a953f0459d16c25eea7ab2bd7c Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
* | Add setPath overload to QDeclarativePolylineMapItemPaolo Angelelli2017-08-031-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a Q_INVOKABLE setPath overload that takes a QGeoPath. This can be beneficial when a path is already available and should be set without going through javascript array conversion. This method should come handy also when pushing polyline data from C++. [ChangeLog][QtLocation][MapPolyline] Added setPath overload taking a QGeoPath. Change-Id: I6916500473865b8234b48e8df08dfb465a2a75d2 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add alignCoordinateToPoint methodPaolo Angelelli2017-08-031-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This method effectively extends the functionalities offered by the center qml property, allowing to set a coordinate to an item position other than the center of the item. This is useful in those applications where the center of the scene (e.g., a cursor) is not to be place exactly in the center of the map. [ChangeLog][QtLocation][QDeclarativeGeoMap] Added alignCoordinateToPoint method to QDeclarativeGeoMap. Change-Id: I68a3d12e8376b83c4c1775a3af5e2125d3e71d63 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add setBearing overload to rotate around a coordinatePaolo Angelelli2017-08-031-0/+27
| | | | | | | | | | | | | | | | | | | | | | This patch adds an overload for setBearing in QDeclarativeGeoMap to rotate the map around a specific QGeoCoordinate. [ChangeLog][QtLocation][QDeclarativeGeoMap] Added setBearing overload to rotate the map around a given QGeoCoordinate. Change-Id: I5d2428d852b0c3537f4a1cdb1925c059788c45c5 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add camera capabilities + metadata to QGeoMapType/QDeclarativeGeoMapTypePaolo Angelelli2017-07-316-48/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch enriches QGeoMapType/QDeclarativeGeoMapType embedding into this object the camera capabilities for this type, that are then exposed via a new QML Type, CameraCapabilities, and custom metadata in form of a QVariantMap, that can be accessed via the new metadata property. [ChangeLog][QtLocation][QDeclarativeGeoMapType] Added CameraCapabilities and metadata properties to QDeclarativeGeoMapType. Task-number: QTBUG-58931 Change-Id: I97a8852fbb3bbac88fdbf0d47e8247ea7ed1f31e Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
* | Re-enable QGeoAreaMonitor::debug testAlex Blasche2017-07-301-1/+0
| | | | | | | | | | | | | | The test was disabled to facilitate CI integration. Change-Id: Ib61cb3a778e9134ed4fe07a98d38f438c1f22beb Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
* | Adapt tests to the new QDateTime debug output behaviorPaolo Angelelli2017-07-181-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | Invalid QDateTimes (like the default-constructed ones) now output "QDateTime(Invalid)". Temporarily the test is disabled until qt5.git integration passes such that the QDateTime debug operator stream becomes available in the Qt CI. Change-Id: I3c461e55f0300b8bc040761b8c181fe8abf63abe Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
* | Merge remote-tracking branch 'origin/5.9' into devLiang Qi2017-07-062-0/+4448
|\ \ | |/ | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I3241efba9c3a32a4a097a67fd6432c45aad8e6ef
| * Update binary compatibility files for Qt5.9.0 for QtLocationMilla Pohjanheimo2017-06-271-0/+4446
| | | | | | | | | | | | | | Binary compatibility files updated Change-Id: Icb554c390a2c662a724d68d33909838f2a3e23e7 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Blacklist tst_QGeoTiledMap::fetchTiles on b2qtPaolo Angelelli2017-06-171-0/+2
| | | | | | | | | | | | | | | | | | This test has, in the last week, started to fail more often than not. Since it's very likely to be a CI problem, blacklisting it for now. Task-number: QTBUG-61485 Change-Id: Ifb68274f83b7ecc1652394623454230b527b2002 Reviewed-by: Liang Qi <liang.qi@qt.io>
* | Use QRandomGenerator instead of q?randThiago Macieira2017-06-301-5/+3
| | | | | | | | | | Change-Id: Icd0e0d4b27cb4e5eb892fffd14b5285d43f4afbf Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Add QGeoPath::sizePaolo Angelelli2017-06-071-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | A way to retrieve the size of the path is missing, as the path property turns out not to be accessible to QML. This patch adds a Q_INVOKABLE method to expose it. [ChangeLog][QtPositioning][QGeoPath] Add ::size() to QGeoPath to retrieve the number of coordinates in the path. Change-Id: Ifa7a640113cba71f23e36626a84c8b2fe473a07e Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* | Merge remote-tracking branch 'origin/5.9' into devLiang Qi2017-06-0718-40/+99
|\ \ | |/ | | | | | | | | | | | | Conflicts: .qmake.conf src/plugins/geoservices/geoservices.pro Change-Id: Ie82dd22c588e5cba409fc1ef31a65968ce9f719b
| * Fix for incorrect QGeoPathPrivate::containsPaolo Angelelli2017-06-061-3/+3
| | | | | | | | | | Change-Id: I4067d6df69aad0af9495a29532a34f0a7e992596 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Add mean to create qgeopath in locationsingletonPaolo Angelelli2017-06-051-0/+29
| | | | | | | | | | | | | | | | | | As currently there is no way to create a pre-filled qgeopath, this patch adds an overload to QtPositioning.geopath() to pass parameters to the constructor. Change-Id: I05af4dbef07bd62e9e2eace7105b5255e8a392fa Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Merge remote-tracking branch 'gerrit/5.9.0' into 5.9Alex Blasche2017-05-093-22/+34
| |\ | | | | | | | | | Change-Id: I0cb953c2ef6d6efaf6e1c181693bd9f30432fd9a
| | * Add pluginName to QGeoMapType and check against it in setActiveMapTypePaolo Angelelli2017-05-073-22/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a QByteArray member to QGeoMapType with the name of the plugin providing that map type. This value is then used to validate what is passed to QDeclarativeGeoMap::setActiveMapType to see if it's a map type for the currently set plugin. Change-Id: If15b67c32150f0c3c2815d28e26fc37138d4cf71 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * | Disable/blacklist failing tests for boot2qtSami Nurmenniemi2017-05-051-0/+3
| |/ | | | | | | | | | | | | | | | | | | Currently boot2qt is tested with QEMU and some tests fail. Disabling them for now to make it possible to enable qt5 tests for Coin. Task-number: QTBUG-60266 Change-Id: Ib12fe4787bf5f5c672be96233205da3184c2920d Reviewed-by: Alex Blasche <alexander.blasche@qt.io> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
| * Bound check QGeoTileSpec against min/max ZL before requesting itPaolo Angelelli2017-04-121-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until now we have not honored the min/max zoom levels specified in QGeoCameraCapabilities when requesting tiles. As a result we have often fired requests for non-existing tile layers. This change complements the added support for individual camera caps for each map type, and makes the tile fetcher honor the bounds defined in the camera capabilities. This also allows to set larger zoom levels in the renderer, overzooming existing tiles, without the fetcher firing requests for invalid resources Change-Id: Ic8a523a114147109f7ef8af3510a3ab78d06d714 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Replace QGeoMapType argument of cameraCapabilitiesPaolo Angelelli2017-04-121-3/+3
| | | | | | | | | | | | | | | | | | | | Since the only part of QGeoMapType used in the method is mapId, there's no need to pass the whole map type as argument. The benefit is that the camera caps can be requested solely based on the info in QGeoTileSpec. Change-Id: Iafd0e2a1d4d45fbf02b862efe56841001cbebd75 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Fix Clang's inconsistent override warningThiago Macieira2017-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | This is not just a regular test. This is a plugin that does load(qt_plugin). qgeotiledmappingmanagerengine_test.h:89:14: error: 'createMap' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] Change-Id: I523b0abacd5148b2bf08fffd14b488ffa441e68b Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
| * Add mapReady to test case start conditionsKarol Polak2017-04-1110-10/+23
| | | | | | | | | | | | | | | | | | | | It is reasonable to add mapReady property to the condition for the start of test cases where it is required that the map is initialized. This covers the case when one of the initialization steps runs asynchronously. Change-Id: I2eff52dbe3a7bec0b2f3fb26d607398829b5c9f2 Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
| * Fix warning about unused parameter only used in Q_ASSERTThiago Macieira2017-04-111-0/+1
| | | | | | | | | | | | | | | | | | | | Somehow MSVC still sees it as unused, despite our best efforts in Q_ASSERT. So add Q_UNUSED. qdeclarativepinchgenerator.cpp(218) : warning C4100: 'event' : unreferenced formal parameter Change-Id: I523b0abacd5148b2bf08fffd14b46aa8f8409f42 Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
* | Simplify a mathematical expressionEdward Welbourne2017-03-211-2/+2
|/ | | | | | | | | | Squaring a number, doubling it and taking the square root is just a roundabout way of multiplying the number by sqrt(2); so do that instead, saving some computational cost and probably reducing the amount of rounding errors that can creep in. Change-Id: I1abf3c2de318f48f80536379156ace8f25a6acaf Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
* Skip Flick autotests altogether on windows 32bitPaolo Angelelli2017-03-152-0/+12
| | | | | | | | Apparently these cause a test crash Task-number: QTBUG-59503 Change-Id: I3982eaf68503f791faf25ec4b57f7a592d8a2242 Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
* Merge remote-tracking branch 'origin/5.8' into 5.9Liang Qi2017-03-1014-1/+29
|\ | | | | | | Change-Id: Ibd6d68ced4edbd96fb67fe61244b83d597df5775
| * Don't try to set library paths if !QT_CONFIG(library)Ulf Hermann2017-03-0713-0/+26
| | | | | | | | | | | | Change-Id: I1774d2b4c637f5057691f43275e10f19b986c722 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io>