| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Crash caused by storing pointer to a node that could be deleted elsewhere
Fixes: QTBUG-85260
Change-Id: I871123322fac84b8bf91e9bab8ecad08e75c2854
Reviewed-by: Paolo Angelelli <paolo.angelelli.qt@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids conflicts for static builds, where the system might
also provide a clipper2tri, clipper, or poly2tri library.
[ChangeLog][General] The generated clipper2tri, clipper,
poly2tri libraries have been renamed to qt_clipper2tri, qt_clipper,
qt_poly2tri. This avoids conflicts for static builds.
Fixes: QTBUG-86248
Change-Id: I38261633acef1d3be0cb5b67b3b5bf3262258a95
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
(cherry picked from commit 6b2cf7e9d150b7be709fcd688c5045949cedc3d9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
| |
Because we want to deprecate FollowRedirectsAttribute
Change-Id: I3453b120a442dea3624ff2a3f49a2eb565bde762
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take in commits
d3101bbc2 Update Qt redirection handling
5dbbb966f [qt] Remove libc++ attribution
9d155e652 [qt] Document deps/optional dependency
255935c14 [qt] Add zlib to mapbox-gl license
a7f15a826 [qt] Improve third-party license documenation
[ChangeLog][Third-Party Code] Update and extend third-party
documentation for Mapbox GL plugin dependencies:
libc++, Optional, Mapbox GL Native, Boost, CSS Color Parser,
cURL Parse Date, Earcut Polygon Triangulation Library,
geojson-cpp, geojson-vt-cpp, geometry.hpp, kdbush.hpp,
polylabel, protozero, RapidJSON, shelf-pack-cpp, supercluster.hpp,
tao_tuple, unique_resource, variant, Vector Tile Library,
Wagyu Geometry Processing Library, nunicode.
Change-Id: Icb55f9aaa2d96dd973aced90a73208eb8c0be209
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 7769ea903f87efc4ad55530a2749f104eddff2e4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][Third-Party Code] Added actual license text of Boost
Software License (used in Clipper Polygon Clipping Library)
Change-Id: Ie4bfc92541eaac3844a8a75044e2ba60a89adaaa
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
(cherry picked from commit e69a08a91334df9830d196c48b24f487775e798f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
A use of deprecated qrand() was in a comment, so remove it.
A use of QT_BEGIN_HEADER wasn't matched by QT_END_HEADER and it's now
a no-op anyway.
Change-Id: Ie79c181e5f194c00949bfd7d2372f2d246b53180
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
(cherry picked from commit 354d59cd8e7972525e5978d970ef5e64edb14898)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found by Clang 10:
error: expression does not compute the number of elements in this array; element type is 'const MapStyleData',
not 'QGeoMapType::MapStyle' [- Werror,-Wsizeof-array-div]
Instead, just use range-for.
Task-number: QTBUG-83666
Change-Id: I99ab0f318b1c43b89888fffd160b589c5543b9d4
Coverity-Id: 226105
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit 275efcc6c493e01fcbb623de4a277cffd584fa58)
|
|
|
|
|
|
|
|
|
|
| |
qgeocodereplyosm.cpp:115:21: error: loop variable 'k' of type 'const QString' creates a copy from type 'const QString' [-Werror,-Wrange-loop- construct]
Task-number: QTBUG-83666
Change-Id: I99ab0f318b1c43b89888fffd160b4a12bee11723
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 8b0c9024b1eb9b6a4ad2e440d6e7856ca3a09e80)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|
|
|
|
|
|
|
|
| |
/home/tjmaciei/src/qt/qt5/qtlocation/src/plugins/geoservices/mapbox/qplacesearchreplymapbox.cpp:107:98: warning: ‘QString::SkipEmptyParts’ is deprecated [-Wdeprecated-declarations]
Change-Id: Ib3333a58f37746f3b935fffd1607e152af50f386
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 3ca1149275e1e63e11c8d97f696e05bf73d2e076)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
|\
| |
| |
| | |
Change-Id: Ied8bd656df6a6ad2c3d913905b32f8e08fd9d7e0
|
| |
| |
| |
| |
| |
| |
| | |
Needed to compile with GCC 9 and 10.
Change-Id: I99ab0f318b1c43b89888fffd160bf42e51e9a0d1
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: If9ee065e8d2cbca6ca0ff64415c509caa655a2e6
Reviewed-by: Paolo Angelelli <paolo.angelelli.qt@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Change-Id: Iab6e89c016eb25ea99edcdc88e1191604157b4b9
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
(cherry picked from commit 22895ccf70a5f0932972f5b363fd9001e19616bd)
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
comparison of two values with different enumeration types
in switch statement ('QVariant::Type' and 'QMetaType::Type')
Change-Id: I40bff89a773d4c312825133fd8c00e32e469953a
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Fixes developer build with clang 7.
Change-Id: I45e532541de0f3acc6cdd00231ed7d3aa2264e48
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|/
|
|
|
|
|
|
| |
Fixes developer build with clang 7.
Change-Id: I551a5b90d02f5ccb9a7e2e0f9e455d593237a562
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Paolo Angelelli <paolo.angelelli.qt@gmail.com>
|
|
|
|
|
|
|
| |
This was introduced by 5a4ffa0de0ecc666a514ef60f0149a76d25b040d
Change-Id: Icccf0c8cd3154c102fd93b79e81199e043f7d0bb
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|
|
|
|
| |
Change-Id: I5ec9c700a0b69a556512efbd0bfd79c4c2119f9a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
| |
Conincidentally the patch fixes a few other minor deprecation warnings
in the same file too.
Change-Id: Iaf6221cd35cca95415b7d5383477b8c2bcfe92b0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
|\
| |
| |
| | |
Change-Id: I8b84b78bf234556b7162066b8401630da2afb311
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using a static ComPtr<IGeoLocationStatics> in requestAccess might cause
a crash on exit as this pointer might be cleaned up after the application
has exited. Make sure, that this pointer is deleted together with the
rest by making it part of the d pointer.
Fixes: QTBUG-80711
Change-Id: I93c09a4549967195101de07b3cef430f8cd52229
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Added support for custom Mapbox API base URLs.
Fixes: QTBUG-82655
Change-Id: Ieebcc834f8aeaeb223b036100e5edadd55749101
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
and remove ugly cast
Task-number: QTBUG-82605
Change-Id: I8220ead34731b488f8350229447e7f2e723f9c11
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In a preparation for final cleanup in dev/Qt6.
This amends the recent change in QtNetwork where
we deprecated ambiguous signal overload.
Also, fix old SIGNAL to use the proper name.
Task-number: QTBUG-82605
Change-Id: Ifc92ce4569ba15ac5429fe379f134a6dbe3a5f73
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
serialnmea QIOPipePrivate initialization accessed QIOPipe via
q_ptr before the object was constructed.
[ChangeLog][QtPositioning][serialnmea plugin]
Fixed serialnmea plugin initialization when used with serial port.
Fixes: QTBUG-82819
Change-Id: I3ff2de381a124f6b25f19327a39f1b001ef4899a
Reviewed-by: Paolo Angelelli <paolo.angelelli.qt@gmail.com>
|
|\ \
| |/
| |
| | |
Change-Id: I72fa0c1d41db884c752820a8d1fb5a7aa55762bc
|
| |
| |
| |
| |
| | |
Change-Id: Ifc34a27c89d7d8a63e66e9858f8e6dd3cd9522ab
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|\ \
| |/
| |
| | |
Change-Id: I66502770edaa22deb2644ce5071df4894c4d0f97
|
| |
| |
| |
| |
| |
| |
| | |
Fixes: QTBUG-82417
Change-Id: Id9be6f9e248612bce3a17a65d5f73f7ec4c9f45f
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit b482674e51c097fccffa1e1cc32b4843ad393894.
Reason for revert: naming in QProcess is considered to be the correct one.
Change-Id: I6722adfc06b351c76fb432628a678c4ce887d594
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I3b030728b32af6e340738583f78b2cfb0d2df11a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I8716c94b2c3f1fb995e933fe5be736e94ff161ce
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change introduces a metric-based implementation of the
Ramer-Douglas-Peucker line simplification algorithm to generate a
LOD pyramid for the polyline geometries.
This comes with a related property (in MapItemBase), lodThreshold,
that can be used to change the threshold after which no simplification
will be used.
By default the value of this property is 0, meaning that the
behavior will be unchanged and no LOD will be used.
This change also introduces LOD on map polyine objects QSG, for which
no property is introduced, and there's a default threshold set to
zoom level 12 (which appear to produce acceptable results).
Finally, this patch makes use of a threadpool with 1 thread
to enqueue geometry simplification tasks, which would otherwise
freeze the UI when computing for the first time.
Support for geometry simplification is currently added only to polylines.
It might be of interest extending it to polygons as well, once
a proper strategy for handling the simplification of inner holes has
been identified.
Finally, extending it to circles could be of interest, while potentially
bringing only minor benefits, as circle geometries are currently fixed
to 128 vertices.
Also adds a MapObject-based delegate to the geojson viewer example.
Task-number: QTBUG-46652
Task-number: QTBUG-38459
Task-number: QTBUG-49303
Change-Id: I64b5db4577962db17e5388812909285c9356ef0d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch changes the implementation of the scenegraph-based
mapobjects (those created by QGeoTiledMap) to be the recently
introduced one sporting shader-based map projection.
This is much faster than the previous, but may introduce small glitches
at this time (mostly on minified polylines).
Adding polyline LOD simplification will solve this problem.
Compared to equivalent Map Items (that is, Map Items backed by the
same underlying implementation), map objects now are approximately
1.5x faster.
This measure has been gathered using medium-size polygons (contained
in the file 10_countries.json from the geojson_viewer example).
The difference is caused by the additional QtQuick geometry related
operations (essentially projecting the bounding box for each item)
present in MapItems.
Smaller polygons may therefore yield larger improvements, larger polygons
the opposite.
Change-Id: I3fc92b02b74a3a4d001e69755949a98f80d8a3d3
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
The new approach introduces a root node for all objects, that is
repopulated at every repaint.
Change-Id: I4562e1aaa18999a03e8c38fe3bf59fe41f14dd70
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this change, all the geo-to-screen conversion,
and the triangulation operations for geo polylines
and geo polygon are performed either at set time
or in the shader.
A separate bounding box geometry is processed
in the old way to provide a correct QtQuick Item
geometry, that can be used for nesting mouse areas,
performing translations, input event delivery, etc.
With this approach, performance are improved by more
than one order of magnitude in average, but complex
geometries will of course benefit more.
It also adds correct rendering support for polygons
with holes, previously only rendered correctly
by the MapboxGL plugin.
The polyline shader has basic miter joins. The miter is
skipped if the angle is too sharp to avoid complicating
the implementation.
This shader introduces some glitches when the polyline
is minified, for which the real fix is to
have LOD for the geometry, and render simplified
geometries at low zoom levels (added in a subsequent patch).
Note: this approach, at least in its current implementation,
does not support enabling layers on individual items, only
on the Map element.
Task-number: QTBUG-49303
Task-number: QTBUG-38459
Change-Id: I0c2dc0bf364d32f74ca7c4014f6d66e6219c8ae4
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Problem resulting in failure when calling the contains() method.
This patch caches the leftbound that is used in many other
methods.
This patch also fixes the copy constructor, now correctly
converting rectangles and circles into polygons.
Tests are added in a subsequent patch.
[ChangeLog][QtPositioning][QGeoPolygon] Fixed contains method.
Change-Id: I324e5a6e9bf981f830a8bb88e5f2abedb5ece5dd
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|\ \
| |/
| |
| | |
Change-Id: Iae2b08cdf4f64d69bedeabf4633fd34b44a02ad0
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
startSatelliteUpdates() and lastKnownPosition() were not checking
Android permissions before trying to access positioning data.
Task-number: QTBUG-81689
Change-Id: Ia4d75920b7b07c6782d80a483a3e3961ed9149f5
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Iefab6ee7738f422de9d491f70e7461b30e73c624
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|\ \
| |/
| |
| | |
Change-Id: I81acc98f1602d20d810e5d792fc670bdaa8b1821
|
| |
| |
| |
| |
| |
| |
| |
| | |
Update instance of old code using JNI_VERSION_1_4 to make the code
consistent.
Change-Id: Icdb8d152c69f32f1050b51bdb7985acc3364fbf4
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I1705757d3530ed595912dba726cab50f003f103d
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Set parent for incubated objects in MapObjectView to the view.
Also properly set component completed when removing the view from
a map and then readding it.
Finally silence the useless warning about MapObjectView
being unsupported, as the default MOV is basically what's wanted.
Change-Id: Iecbc345ced99754d0d09112b4b30eaca2bb078e5
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also emitting signals when the parent is changed internally
(e.g., in a MapObjectView).
Not revisioning it since it is used both in QtLocation
and in Qt.labs.location, and setting it to 15 would break
the property in map objects.
Change-Id: Ib11b18b7fcc507b5a11481f84f2bf0bd8c9f558e
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a slot directly connected to the socket's signal. This means,
deleting the socket from the slot leaves the socket's code that was
emitting with an invalid 'this' pointer.
Fixes: QTBUG-81069
Change-Id: I5b915f8d103809b80d1af34655eaa5231bddc7a6
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Which is QNetworkReply::error(). Use QNetworkReply::networkError()
instead.
Task-number: QTBUG-80369
Change-Id: Id41166a72c0d14bc77d9ec853db2f665617195ee
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This patch also parents it with the object also fixing memory leaks.
Change-Id: I74a21176b1d2450b10a21f92321520ca2c6e88e0
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: Iccbd3c3f2162973d407a31b02ea6911f3c1d5b31
|
| |\
| | |
| | |
| | | |
Change-Id: Ic904924227e0276e59381548fc54ee51117ddb5a
|