| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Triggered by usage of a virtual method in superclass destructor.
Change-Id: If99e523e42fd13686ae43c0083a74e1b68221fc7
Fixes: QTBUG-67638
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
(cherry picked from commit 1ac41150501d3c5cc4a9a6ed9c93729687666553)
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
|
| |
Otherwise it becomes problematic to start up applications in absence
of network.
Change-Id: Ia543b88bd56bb6c93c803a66e345be1610a4dfe0
Reviewed-by: Tuomas Vaarala <tuomas.vaarala@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Add space, fixing:
declarativemaps\qdeclarativegeomapitemview.cpp(143): warning C4138: '*/' found outside of comment
declarativemaps\qdeclarativegeomapitemview.cpp(148): warning C4138: '*/' found outside of comment
declarativemaps\qdeclarativegeomapitemview.cpp(153): warning C4138: '*/' found outside of comment
Change-Id: Ia63ebb4553661bac1af4dce1adf00befbaa34a87
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some plugins request map data for some map types over HTTPS.
Without SSL support (Qt built without SSL support, or missing OpenSSL
libraries) this typically translates into blank maps.
This is very evident on the MapViewer example.
This patch makes sure that the example displays a notice when this
situation happens.
[ChangeLog] Added a notice to the
MapViewer example to inform when a HTTPS-based map is selected without
SSL support.
Change-Id: I85428bb0536f33089a0e6045301c089fafe69d74
Fixes: QTBUG-74195
Fixes: QTBUG-74294
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the views are explicitly destroyed, leading to
issues, in particular for views declared inside the Map.
Change it to simply remove these views from the map.
Child views will be destroyed in ~QObject.
[ChangeLog] Fixed crash when destroying Maps containing
MapItemViews.
Change-Id: Iff9b1afd6b17b55671b1f999b1bf69f172a05483
Fixes: QTBUG-69195
Fixes: QTBUG-74337
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, the method computes a closed-loop length.
Being this public API, the only thing that can be done is to properly
document the behavior.
[ChangeLog][QtPositioning] Documented QGeoPath::length behavior properly.
Change-Id: Ie48a51ab0d11ec68851c2ea26b8c6f6894be8b61
Fixes: QTBUG-71358
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
A missing '.' was causing to index the wrong tile specs for all map
types.
[ChangeLog] Fixed incorrect indexing of Mapbox
tiles in the cache.
Change-Id: Ic22dd60f4a608b31d071520bae750efddb48d59a
Fixes: QTBUG-70438
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
|
|
|
|
|
| |
Change-Id: I4369e71bbef0c218b35ef3449c5a1615fbf2cb4d
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
| |
BSD was disabled by 5241d8c727d8e45d0266d486958e6e566563e1c8.
Fixes: QTBUG-73714
Change-Id: I31ceb62caa19b231cbf6304138f68c8efdcc65db
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
| |
Change-Id: I0ada3ad1bbb27f3947497adf4bfeb1469f4a6256
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setPreferredPositioningMethods and setUpdateInterval are called by init so
these functions should not assert in initializing state.
Additionally the early exit condition in setPreferredPositioningMethods
has to be the same as in setUpdateInterval. Both cases have to return
early if the locator has not been initialized. This initialization
happens in init, so both states, Initializing and Initialized, are fine
for further handling.
Change-Id: I4ef8db7178c38299328041a8d163a1b9bbecc5b1
Reviewed-by: Andre de la Rocha <andre.rocha@qt.io>
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
| |
Change-Id: I823bd3ebbd74096fc7319147dc7d4ca6ef10e414
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loading the plugin without access to the location service will
work and not error out. It is still possible to enable location service
later and the backend will work as expected.
This patch changes the behavior so that the pop up asking for access to
the user's location data is no longer shown when the plugin is loaded, but
when the backend is actually used for the first time.
Change-Id: I23100f7867610c6f23b2d2ea5c15c268468949a9
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The locator's status is only updated while a positioning session is
active so it does not always reflect the correct state. By checking the
access we have a more reliable way to reflect the current state.
Task-number: QTBUG-66427
Change-Id: I75d2274c9efd29bf070913246738bf18a9ec5edc
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-66427
Change-Id: I6cccb1d62c116e762e073e996e5932c7351787d9
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
|
|
|
| |
Doing their initialization near the end of init() is too late because
parts of init (namely setUpdateInterval and
setPreferredPositioningMethods) rely on them.
Change-Id: I81ea1db53aa531248f2c49b8f53f2c33b5fb954e
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
| |
Change-Id: Ic90cf82b9c07377875408d0c485aa8af987323c4
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
|
|
|
| |
- Use override where applicable
- Use declaration initialization if possible
- Do not use temporary variables which are not used
Change-Id: I68311dfc090fa6a217814a7f801fef6764778cab
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The access to location services can change while the application is
running so checking the access only once does not work.
If access is not granted set the proper error code.
Change-Id: I00d82dd166d049363de1dc9b0ca7015bc494baf5
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
| |
Change-Id: Iaad7abbb668d6d0542c3697dae3544f7d8fe5c5a
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Querying the position source's status is error prone as it is only updated
if position tracking is active. Instead we can react on changes for this
status and get updated information when it is available.
Change-Id: I18d55faf6163568243d2e05d3c63f13e9e45f413
Reviewed-by: Andre de la Rocha <andre.rocha@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
No incubation cancellation required when an object is removed: the DM
takes care of that.
Handle also the case of itemCreated called during synchronous object
creation, that fires the callback in the middle of the ->object
call.
Task-number: QTBUG-71264
Change-Id: I058a101c754f22f4b6fbcbd7f6f7ded36f3c129b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
| |
This patch fixes the case when one QGeoRectangle contains the
second, and wraps around.
Change-Id: I7110c1864082c502845754fab2dc4e783455a446
Fixes: QTBUG-72935
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
| |
Change-Id: Ie6e1b7a21818a10b893b161183da2dd447e41ec5
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
|
| |
This workaround is currently needed until QTBUG-72930 gets fixed in
qtdeclarative.
Change-Id: Id75fa2048dd6e012c99f61cdc07cfedbe8c6bf83
Fixes: QTBUG-61509
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This case was not a problem when the only incubation mode was
Asynchronous, because the test for m_map was done in createdItem.
Now that Synchronous is supported too, this check has to be done earlier
or else instantiated items will never be added to the map.
Change-Id: Ifaa033fb0b64cabe74df395fcb387d162cd02b80
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
|
|
|
|
|
|
|
|
|
|
|
| |
- If more than 1 action is done inside runOnXamlThread any error should
cause a "top level" error.
- If every possible error inside runOnXamlThread gives a proper error
message we do not need another error message outside of the block.
Change-Id: I910f9e4bc7984e1c7e1f358eee975738ffa3bb2f
Reviewed-by: Andre de la Rocha <andre.rocha@qt.io>
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is useful because on several platforms supportedPositioningMethods()
returns NoPositioningMethods while the user has disabled the Location service.
At the same time the platforms can only support dynamic
supportedPositioningMethodsChanged() notifications after startUpdates() was called.
Blocking changes to this property would have been counterproductive as startUpdates() would
always fail and notification would not be possible.
This affects at least WinRT and Android and Apple platforms need still
further investigation.
Task-number: QTBUG-66427
Change-Id: Ie03a3ef9c9476d7be3547661eaa87678fdb7b39c
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This signal was added in Qt 5.12 but never emitted on Android.
Due to implementation issues this signal is emitted for each
provider change (e.g. twice if network and gps provider were disabled
when the entire location service is disabled)
Task-number: QTBUG-66427
Change-Id: I820b3187bfd8b8ab4facb053e2019e4f5c9736d0
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
In particular the differing levels of support on various platforms
needed documentation.
Task-number: QTBUG-66427
Change-Id: I4c390d14ad69e2f1630e883c8f0a34cbca028a03
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far this method returned all existing positioning methods and not
the available methods. Availability is defined by customer settings
like turning location off or only enabling GPS based positioning.
Task-number: QTBUG-66427
Change-Id: Id5b58ee4cc0274bae90ed2e363cb5cf2a287dc05
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When "uturn" comes from OSRM, Qt returns UTurnLeft since Right Hand
Traffic is in use in most countries.
This commit allows qml to set traffic side to return correct u-turn
direction.
Task-number: QTBUG-72462
Change-Id: Ifaa002b063159b4e4ee563d007721ba7a4a587a4
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This enables the following code:
QGeoCoordinate coord(foo, bar);
QVariant v; v.setValue(coord)
qDebug() << v;
Change-Id: I3cc66c359d6be8b8ab9471170ae8763e08c3b3e9
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes: QTBUG-62682
Fixes: QTBUG-68331
Change-Id: Ibd08934e2b6da06a6b6ff24419e53b87fb2eaa20
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|
|
|
|
|
|
|
|
| |
Android's platform API supports this piece of information since
API version 26.
Fixes: QTBUG-64689
Change-Id: I09cce4979f3f754cb9af11281de2fe0050b74da1
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|
|
|
|
|
|
|
|
| |
Since Android uses a new NDK/compiler since 5.12 there were many more warnings
which had serious implications. Examples are potentially flawed downcasts,
nullptr warnings and old style casting operators.
Change-Id: I53989fa9120c8b7e865d23255d1fcdf229e7f2f3
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
Change-Id: Ifd3514a958d0df4320b253c26e3da3a632088be8
|
| |
| |
| |
| |
| |
| |
| |
| | |
Apparently unable to resolve QPointers to pointers
Change-Id: I04b3b7698ea083f83bc2713530656ca8b3f3ac28
Fixes: QTBUG-69512
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In this case, only border geometry was marked dirty, producing a
misplaced polygon.
Fixes: QTBUG-70886
Change-Id: Ied39e523a584976871a655e436daf8c2700458b6
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Order of touch events are not sorted on some platform. When touch point
1 and
2 are swapped, map is rotated 180 degrees in a moment
Change-Id: I9c308b805a6ca54519f26a9ff19217de7f947c17
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If an entry in the results had no categories specified at all then it
would end up including this in the results even if a specific category
was requested to match against.
Change-Id: I506b40b73ec07608bd2b2562d92065376fbb67c9
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
| |
| |
| |
| |
| |
| | |
Fixes: QTBUG-72291
Change-Id: Id2c2ce04e12f1470b08e93ec3512ab39b4054f7d
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
qtlocation/src/plugins/position/android/src/qgeopositioninfosource_android.cpp:226:
warning: implicit conversion loses integer precision: 'qint64' (aka 'long long') to 'const int'
Change-Id: I64df529028aac88f1b6e05c72cfba0a9ed6c9a7f
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
|\ \
| | |
| | |
| | | |
Change-Id: I53b052e12532392192d73da7006b204539cad57c
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The original name was correct as clear would need to reset more
properties which is was not the goal of this method.
Change-Id: Iac43a61e4b8bf57220c88d627b33578612c4ddad
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This patch updates the Nokia geo service plugin code to use
QRegularExpression in place of QRegExp which is to be considered
deprecated.
Change-Id: Idc7459351c6f1a1b12ba1528c426fced324039a1
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
GCC 4.8 doesn't like using QPointer in signal connections.
Change-Id: I9504efb259712a65427ef1366ca562882085404e
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
cb19e1f7e3cc2cfee3b8fcbdfa5cd151826dadac fixed a bogus comparison in
an if statement.
However, the correct condition is actually a bug, and should be removed
altogether. The previously incorrect condition was always testing
to false so the problem wasn't triggered.
Task-number: QTBUG-72180
Change-Id: Ia00b55596173474e8c0fe3b0c374490620c6917f
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This patch introduces a new macro, QT_LOCATION_DEBUG, that, when
fed via qmake command line, changes the scope of some members,
adds some extra members and some extra data dumping into these
members.
In this way external code can inspect the state of the renderer
in order to debug it.
The patch also moves a few classes into separate files, as well
as privately exporting them.
Change-Id: I32a042863f78dcd10f94b0b7fe8b90f3fc486891
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to MSDN GeoLocator's default ReportInterval is 1 second or as
frequent as the hardware can support – whichever is shorter. By using that
functionality we can support minimumUpdateInterval "properly".
Change-Id: Id54197babeec04c8fc0a309930b192e36d9138f8
Reviewed-by: Miguel Costa <miguel.costa@qt.io>
|