diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-14 21:44:54 +0200 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-09-20 13:42:10 +0200 |
| commit | b95c358b83557ba7590dc5d52e26b691977b051b (patch) | |
| tree | 78c89f0411bfcd9d947ffbca1a111ea8a66fe1db /src/plugins/geoservices/osm/qgeocodereplyosm.h | |
| parent | 30bb5ed1308b9110a3903bee9d254e5b759d37f5 (diff) | |
| download | qtlocation-b95c358b83557ba7590dc5d52e26b691977b051b.tar.gz | |
Cleanup: de-virtualize QGeoCodeReplyPrivate
The only call to the single virtual function, extraData(), was commented
out. The subclass in the OSM plugin only wrote extra data for debug runs
and the subclass in the mock plugin is never used to test anything anyway.
So remove all this overhead. As a drive-by, refactor to member
initialization and use qsizetype for members that refer to indices in a
QList.
Change-Id: I600b4637bc367ae45d51b2a7f9a3ae0b78fb77c4
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
(cherry picked from commit ff4207b1a41db4d23d4d0183152776e73f252a3a)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/plugins/geoservices/osm/qgeocodereplyosm.h')
| -rw-r--r-- | src/plugins/geoservices/osm/qgeocodereplyosm.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/plugins/geoservices/osm/qgeocodereplyosm.h b/src/plugins/geoservices/osm/qgeocodereplyosm.h index f00a8bb2..a82d3e71 100644 --- a/src/plugins/geoservices/osm/qgeocodereplyosm.h +++ b/src/plugins/geoservices/osm/qgeocodereplyosm.h @@ -62,16 +62,6 @@ private: bool m_includeExtraData = false; }; -class QGeoCodeReplyOsmPrivate : public QGeoCodeReplyPrivate -{ -public: - QGeoCodeReplyOsmPrivate(); - ~QGeoCodeReplyOsmPrivate(); - QVariantMap extraData() const override; - - QVariantMap m_extraData; -}; - QT_END_NAMESPACE #endif // QGEOCODEREPLYOSM_H |