diff options
author | abcd <qt-info@nokia.com> | 2011-08-22 14:39:26 +1000 |
---|---|---|
committer | abcd <qt_abcd1@ovi.com> | 2011-08-22 10:22:36 +0200 |
commit | 69d4a69261da1758b1a21c28a09fdd5006c51890 (patch) | |
tree | daaac27f39281bd5ff98915f3753dae1aec93453 /src/location/places/places.pri | |
parent | 2c829671005e6572ae6e048aa337bb8b3ca639f9 (diff) | |
download | qtlocation-69d4a69261da1758b1a21c28a09fdd5006c51890.tar.gz |
Introduce Content class and rename PlaceMediaObject to PlaceImage
Paging is now implemented in terms of content objects, things like
images, reviews etc should inherit off the QPlaceContent class.
The main advantage of this change in C++ is that the paging code will
not be duplicated for different content types, also we have less
symbols which is good for plugin loading times.
For now, in QML we still retain separate specialized models. In future
it might be possible to just have a single model class to hold
different content types. There will still however need to be
separate model instances for say reviews and images.
PlaceMediaObject has been renamed to PlaceImage because currently
all we provide are images. It is anticipated that if there are
new media types like video we would introduce QPlaceVideo and have
it inherit off QPlaceContent. It is suboptimal to try define
a generic media object right now when we do not have a clear idea
about the use cases of each possible media type.
A future change will have QPlaceReview inherit off QPlaceContent.
Change-Id: Ia6cf5092e246374ed639694d7653e30429c94cc2
Reviewed-on: http://codereview.qt.nokia.com/3284
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron McCarthy <aaron.mccarthy@nokia.com>
Reviewed-by: abcd <qt_abcd1@ovi.com>
Diffstat (limited to 'src/location/places/places.pri')
-rw-r--r-- | src/location/places/places.pri | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/location/places/places.pri b/src/location/places/places.pri index 08e052d8..b8756ec3 100644 --- a/src/location/places/places.pri +++ b/src/location/places/places.pri @@ -5,8 +5,10 @@ PUBLIC_HEADERS += \ #data classes places/qplaceattribute.h \ places/qplacecategory.h \ + places/qplacecontent.h \ + places/qplacecontentreply.h \ places/qplacedescription.h \ - places/qplacemediaobject.h \ + places/qplaceimage.h \ places/qplacepaginationlist.h \ places/qplaceperiod.h \ places/qplacerating.h \ @@ -20,7 +22,6 @@ PUBLIC_HEADERS += \ #reply classes places/qplacereply.h \ places/qplacedetailsreply.h \ - places/qplacemediareply.h \ places/qplacereviewreply.h \ places/qplacesavereply.h \ places/qplacesearchreply.h \ @@ -33,8 +34,9 @@ PUBLIC_HEADERS += \ PRIVATE_HEADERS += \ places/qplaceattribute_p.h \ places/qplacecategory_p.h \ + places/qplacecontent_p.h \ places/qplacedescription_p.h \ - places/qplacemediaobject_p.h \ + places/qplaceimage_p.h \ places/qplaceperiod_p.h \ places/qplacerating_p.h \ places/qplacereview_p.h \ @@ -48,9 +50,11 @@ SOURCES += \ #data classes places/qplaceattribute.cpp \ places/qplacecategory.cpp \ + places/qplacecontent.cpp \ + places/qplacecontentreply.cpp \ places/qplacedescription.cpp \ #result - places/qplacemediaobject.cpp \ + places/qplaceimage.cpp \ places/qplaceperiod.cpp \ places/qplacerating.cpp \ places/qplacereview.cpp \ @@ -64,7 +68,6 @@ SOURCES += \ #reply classes places/qplacereply.cpp \ places/qplacedetailsreply.cpp \ - places/qplacemediareply.cpp \ places/qplacereviewreply.cpp \ places/qplacesearchreply.cpp \ places/qplacetextpredictionreply.cpp \ |