diff options
author | Paolo Angelelli <paolo.angelelli@qt.io> | 2017-02-09 11:22:01 +0100 |
---|---|---|
committer | Paolo Angelelli <paolo.angelelli@qt.io> | 2017-02-13 15:26:45 +0000 |
commit | 68520449fe15682fe8fcd666860f6ae86493ebf5 (patch) | |
tree | fb8f466f12e2bc70fffa2fc5d9ebeb07958570db /src/location/declarativemaps/qdeclarativerectanglemapitem.cpp | |
parent | 96508ffb32c03850033b41f1eb50e3ca9144408c (diff) | |
download | qtlocation-68520449fe15682fe8fcd666860f6ae86493ebf5.tar.gz |
Remove dirty geo* flags from map itemsv5.9.0-alpha1
The recommended way for a plugin to get notification for when to update
items is to connect to the item's signals.
Therefore these introduced dirty flags that would have to be checked
in a loop can be removed.
Change-Id: I28c9b236b3a2e6296a89649b604381a2001a0b20
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Diffstat (limited to 'src/location/declarativemaps/qdeclarativerectanglemapitem.cpp')
-rw-r--r-- | src/location/declarativemaps/qdeclarativerectanglemapitem.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/location/declarativemaps/qdeclarativerectanglemapitem.cpp b/src/location/declarativemaps/qdeclarativerectanglemapitem.cpp index b151d135..03f7f846 100644 --- a/src/location/declarativemaps/qdeclarativerectanglemapitem.cpp +++ b/src/location/declarativemaps/qdeclarativerectanglemapitem.cpp @@ -122,10 +122,6 @@ QDeclarativeRectangleMapItem::QDeclarativeRectangleMapItem(QQuickItem *parent) this, SLOT(markSourceDirtyAndUpdate())); QObject::connect(&border_, SIGNAL(widthChanged(qreal)), this, SLOT(markSourceDirtyAndUpdate())); - QObject::connect(&border_, SIGNAL(colorChanged(QColor)), - this, SLOT(markGeoMaterialDirty())); - QObject::connect(&border_, SIGNAL(widthChanged(qreal)), - this, SLOT(markGeoMaterialDirty())); } QDeclarativeRectangleMapItem::~QDeclarativeRectangleMapItem() @@ -171,7 +167,6 @@ void QDeclarativeRectangleMapItem::setTopLeft(const QGeoCoordinate &topLeft) return; rectangle_.setTopLeft(topLeft); - markGeoGeometryDirty(); markSourceDirtyAndUpdate(); emit topLeftChanged(topLeft); } @@ -203,7 +198,6 @@ void QDeclarativeRectangleMapItem::setBottomRight(const QGeoCoordinate &bottomRi return; rectangle_.setBottomRight(bottomRight); - markGeoGeometryDirty(); markSourceDirtyAndUpdate(); emit bottomRightChanged(bottomRight); } @@ -230,7 +224,6 @@ void QDeclarativeRectangleMapItem::setColor(const QColor &color) return; color_ = color; dirtyMaterial_ = true; - geoMaterialDirty_ = true; polishAndUpdate(); emit colorChanged(color_); } @@ -378,7 +371,6 @@ void QDeclarativeRectangleMapItem::geometryChanged(const QRectF &newGeometry, co rectangle_.translate(offsetLati, offsetLongi); geometry_.setPreserveGeometry(true, rectangle_.topLeft()); borderGeometry_.setPreserveGeometry(true, rectangle_.topLeft()); - markGeoGeometryDirty(); markSourceDirtyAndUpdate(); emit topLeftChanged(rectangle_.topLeft()); emit bottomRightChanged(rectangle_.bottomRight()); |