summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Blasche <alexander.blasche@digia.com>2014-02-10 11:19:12 +0100
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-02-10 12:22:01 +0100
commit63c8b3bca03586994c2b59c262e9cb3a9b12b363 (patch)
tree3069eaf8372821dc170b71dc14f5a90bad464bef
parent900cb0bbbaf1a4b248db220dc2f889f98795afec (diff)
downloadqtlocation-63c8b3bca03586994c2b59c262e9cb3a9b12b363.tar.gz
Mark QNmeaPositionInfoSource tests as insignificant on Windows.
The local TCP socket required by these tests regularly fails on the Windows CI due to heavy load. Change-Id: I65e6150b8c735aec85e643cf1702344ff707723d Reviewed-by: Aaron McCarthy <mccarthy.aaron@gmail.com> Reviewed-by: Alex Blasche <alexander.blasche@digia.com>
-rw-r--r--tests/auto/qnmeapositioninfosource/dummynmeapositioninfosource/dummynmeapositioninfosource.pro8
-rw-r--r--tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime/qnmeapositioninfosource_realtime.pro8
-rw-r--r--tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime_generic/qnmeapositioninfosource_realtime_generic.pro8
-rw-r--r--tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation/qnmeapositioninfosource_simulation.pro8
-rw-r--r--tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation_generic/qnmeapositioninfosource_simulation_generic.pro8
5 files changed, 40 insertions, 0 deletions
diff --git a/tests/auto/qnmeapositioninfosource/dummynmeapositioninfosource/dummynmeapositioninfosource.pro b/tests/auto/qnmeapositioninfosource/dummynmeapositioninfosource/dummynmeapositioninfosource.pro
index b8338f90..f2645820 100644
--- a/tests/auto/qnmeapositioninfosource/dummynmeapositioninfosource/dummynmeapositioninfosource.pro
+++ b/tests/auto/qnmeapositioninfosource/dummynmeapositioninfosource/dummynmeapositioninfosource.pro
@@ -14,3 +14,11 @@ SOURCES += ../../utils/qlocationtestutils.cpp \
../qnmeapositioninfosourceproxyfactory.cpp \
tst_dummynmeapositioninfosource.cpp
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
+
+# This test relies on a working local QTcpSocket(Server). When the CI is under
+# heavy load the socket code cannot establish a connection which leads to flaky
+# test results. We make this test insiginficant as there is currently no known
+# solution to this problem. On the positive side QNmeaPositionInfoSource
+# does not have a platform specific implementation. Other platforms should provide
+# a close enough test approximation.
+win32:CONFIG+=insignificant_test
diff --git a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime/qnmeapositioninfosource_realtime.pro b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime/qnmeapositioninfosource_realtime.pro
index 83e6bf16..cb721b29 100644
--- a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime/qnmeapositioninfosource_realtime.pro
+++ b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime/qnmeapositioninfosource_realtime.pro
@@ -16,3 +16,11 @@ SOURCES += ../../utils/qlocationtestutils.cpp \
../tst_qnmeapositioninfosource.cpp \
tst_qnmeapositioninfosource_realtime.cpp
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
+
+# This test relies on a working local QTcpSocket(Server). When the CI is under
+# heavy load the socket code cannot establish a connection which leads to flaky
+# test results. We make this test insiginficant as there is currently no known
+# solution to this problem. On the positive side QNmeaPositionInfoSource
+# does not have a platform specific implementation. Other platforms should provide
+# a close enough test approximation.
+win32:CONFIG+=insignificant_test
diff --git a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime_generic/qnmeapositioninfosource_realtime_generic.pro b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime_generic/qnmeapositioninfosource_realtime_generic.pro
index ca1c258f..c6105d82 100644
--- a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime_generic/qnmeapositioninfosource_realtime_generic.pro
+++ b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_realtime_generic/qnmeapositioninfosource_realtime_generic.pro
@@ -17,3 +17,11 @@ SOURCES += ../../utils/qlocationtestutils.cpp \
../tst_qnmeapositioninfosource.cpp \
tst_qnmeapositioninfosource_realtime_generic.cpp
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
+
+# This test relies on a working local QTcpSocket(Server). When the CI is under
+# heavy load the socket code cannot establish a connection which leads to flaky
+# test results. We make this test insiginficant as there is currently no known
+# solution to this problem. On the positive side QNmeaPositionInfoSource
+# does not have a platform specific implementation. Other platforms should provide
+# a close enough test approximation.
+win32:CONFIG+=insignificant_test
diff --git a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation/qnmeapositioninfosource_simulation.pro b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation/qnmeapositioninfosource_simulation.pro
index 655a5f10..d1f8941d 100644
--- a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation/qnmeapositioninfosource_simulation.pro
+++ b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation/qnmeapositioninfosource_simulation.pro
@@ -16,3 +16,11 @@ SOURCES += ../../utils/qlocationtestutils.cpp \
../tst_qnmeapositioninfosource.cpp \
tst_qnmeapositioninfosource_simulation.cpp
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
+
+# This test relies on a working local QTcpSocket(Server). When the CI is under
+# heavy load the socket code cannot establish a connection which leads to flaky
+# test results. We make this test insiginficant as there is currently no known
+# solution to this problem. On the positive side QNmeaPositionInfoSource
+# does not have a platform specific implementation. Other platforms should provide
+# a close enough test approximation.
+win32:CONFIG+=insignificant_test
diff --git a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation_generic/qnmeapositioninfosource_simulation_generic.pro b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation_generic/qnmeapositioninfosource_simulation_generic.pro
index cf94e7f8..f3bd50a0 100644
--- a/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation_generic/qnmeapositioninfosource_simulation_generic.pro
+++ b/tests/auto/qnmeapositioninfosource/qnmeapositioninfosource_simulation_generic/qnmeapositioninfosource_simulation_generic.pro
@@ -17,3 +17,11 @@ SOURCES += ../../utils/qlocationtestutils.cpp \
../tst_qnmeapositioninfosource.cpp \
tst_qnmeapositioninfosource_simulation_generic.cpp
DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0
+
+# This test relies on a working local QTcpSocket(Server). When the CI is under
+# heavy load the socket code cannot establish a connection which leads to flaky
+# test results. We make this test insiginficant as there is currently no known
+# solution to this problem. On the positive side QNmeaPositionInfoSource
+# does not have a platform specific implementation. Other platforms should provide
+# a close enough test approximation.
+win32:CONFIG+=insignificant_test