diff options
author | Ivan Solovev <ivan.solovev@qt.io> | 2021-07-29 11:34:16 +0200 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-07-29 11:28:07 +0000 |
commit | ade8147da038ebaae230a38a6e0f16364fc0edbe (patch) | |
tree | 1c7f3496eafb443bdd064e943591d7c0905ba527 /.qmake.conf | |
parent | 89ababe4075f9e816ecd3c3e569fc6517d5e7244 (diff) | |
download | qtlocation-ade8147da038ebaae230a38a6e0f16364fc0edbe.tar.gz |
QGeoCoordinate: fix toString() conversion
Applying qRound() to check if the minutes/seconds should overflow was
not the right solution in some cases. It could lead to incorrect
overflows, and so - to wrong conversion results.
The actual logic of overflow is related to the behavior of QString::number.
This patch fixes the logic and also introduces some minor optimizations.
After overflow, the minutes or seconds value is always 0.0, because
the actual minutes/seconds value is always in range [0; 60). This allows
us to get rid of some checks.
Fixes: QTBUG-95221
Change-Id: Ie3dcb6cef226b04c43dd973c09c4ae297c583f3b
Reviewed-by: Alex Blasche <alexander.blasche@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
(cherry picked from commit 15f06eca6a5085ce14d2eb0b743c5a06365068ea)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to '.qmake.conf')
0 files changed, 0 insertions, 0 deletions